@Oli-Ullmann yeah that's my lack of mod matrix knowledge talking. ha

@David-Healey Looking forward to getting into expansions. Glad you're around for questions! 😂

... slowly backs away from web views ...

image.gif

@DJJD12345 These are two separate commands. cd is the change directory command. Run that one first. Then do the git checkout command.

@Goodflow said in Midi Overlay Panels in Compiled Plugin Crashing DAWS?:

Line 40:

class MidiOverlayFactory: public DeletedAtShutdown

gets changed to

class MidiOverlayFactory

I was having the same crash and was fixed with this. Thanks!
Seems to work on mac, windows & linux. @Christoph-Hart maybe this could be included in the dev branch?

@iamlamprey Done https://github.com/christophhart/HISE/pull/813

@David-Healey 😂 Best way to learn!

@Christoph-Hart

I'm still getting a crash when loading files into the wavetable creator and resample mode. It doesn't seem to happen when I use one of the other resynthesis modes.

> HISE Debug.exe!juce::MemoryBlock::MemoryBlock(const juce::MemoryBlock & other) Line 42 C++ HISE Debug.exe!hise::getMemoryBlockFromWavetableData(const juce::ValueTree & v, int channelIndex) Line 1324 C++ HISE Debug.exe!hise::WavetableSound::WavetableSound(const juce::ValueTree & wavetableData, hise::Processor * parent) Line 1357 C++ HISE Debug.exe!hise::SampleMapToWavetableConverter::rebuildPreviewBuffersInternal() Line 712 C++ HISE Debug.exe!hise::SampleMapToWavetableConverter::refreshCurrentWavetable(bool forceReanalysis) Line 1597 C++ HISE Debug.exe!hise::SampleMapToWavetableConverter::setCurrentIndex(int index, juce::NotificationType n) Line 1637 C++ HISE Debug.exe!hise::SampleMapToWavetableConverter::parseSampleMap(const juce::ValueTree & sampleMapTree) Line 854 C++ HISE Debug.exe!hise::WavetableConverterDialog::loadSampleMap::__l2::<lambda>() Line 787 C++ [External Code] HISE Debug.exe!hise::WavetableConverterDialog::run::__l2::<lambda>(std::function<void __cdecl(void)> & f) Line 942 C++ [External Code] HISE Debug.exe!hise::LockfreeQueue<std::function<void __cdecl(void)>>::callForEveryElementInQueue(const std::function<bool __cdecl(std::function<void __cdecl(void)> &)> & f) Line 1316 C++ HISE Debug.exe!hise::WavetableConverterDialog::run() Line 936 C++ HISE Debug.exe!hise::DialogWindowWithBackgroundThread::LoadingThread::run() Line 397 C++ HISE Debug.exe!juce::Thread::threadEntryPoint() Line 96 C++ HISE Debug.exe!juce::juce_threadEntryPoint(void * userData) Line 118 C++ HISE Debug.exe!juce::threadEntryProc(void * userData) Line 66 C++ HISE Debug.exe!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 C++ [External Code]

That's the debugger callstack in VS2022. The main error I get is Exception thrown: read access violation.
other was nullptr.

It makes no difference as to whether I use a SampleMap in a sampler, or I drag and drop the sample directly into the creator.

Is this anything you know about or could investigate??

it's fixed now.

@udalilprofile
This bug has already been discussed twice in the forum. Do not use the latest commit to compile HISE.

Use this commit: cf3fc78

You can do this as follows:

Clone HISE in the usual way with git clone https://github.com/christophhart/HISE.git Set the head to the last working commit: git reset --hard cf3fc78

Now you can compile HISE without errors.

PS. Use the develop branch.

@d-healey Strange... I just need masks and proper blur too at the moment. And those layer limitations are bad 🙁

Graphics in general is a point that people are still asking for improvement and I understand Hise is not meant to be a photoshop clone. But when you hit limitations... I'd like to re-use OpenGL as well but not confident enough to deal with plateform specific issues... Well, it's one or the other I guess 🤷♂

@Felix-W said in Sampler.setSoundPropertyForSelection(); seems to have a bug.:

@CatABC said in Sampler.setSoundPropertyForSelection(); seems to have a bug.:

@ulrik

@d-healey said in Sampler.setSoundPropertyForSelection(); seems to have a bug.:

@CatABC Use constants instead of magic numbers

Sadly, I tried using constants, but the problem persists. Also, if I swap the positions of HIGH_KEY and LOW_KEY, and need to move the smaller value to the larger value, the contradiction still occurs.

const var ComboBox1 = Content.getComponent("ComboBox1"); const var ROOT = 2; const var LOW_KEY = 3; const var HIGH_KEY = 4; const var C1 = 36; const var D1 = 38; const var E1 = 40; const var B3 = 71; inline function onComboBox1Control(component, value) { Sampler.selectSounds("C3"); if (value == 1) { Sampler.setSoundPropertyForSelection(ROOT, C1); Sampler.setSoundPropertyForSelection(HIGH_KEY, C1); Sampler.setSoundPropertyForSelection(LOW_KEY, C1); } if (value == 2) { Sampler.setSoundPropertyForSelection(ROOT, D1); Sampler.setSoundPropertyForSelection(HIGH_KEY,D1); Sampler.setSoundPropertyForSelection(LOW_KEY, D1); } if (value == 3) { Sampler.setSoundPropertyForSelection(ROOT, E1); Sampler.setSoundPropertyForSelection(HIGH_KEY,E1); Sampler.setSoundPropertyForSelection(LOW_KEY, E1); } if (value == 4) { Sampler.setSoundPropertyForSelection(ROOT, B3); Sampler.setSoundPropertyForSelection(LOW_KEY, B3); Sampler.setSoundPropertyForSelection(HIGH_KEY, B3); } }; Content.getComponent("ComboBox1").setControlCallback(onComboBox1Control);

Ultimately, I set up two methods to call different methods depending on whether the value in the combobox increases or decreases.😹

Wow, this method is so cool! Thank you for the code comments; they really enlightened me.

@Oli-Ullmann Yes I think you're correct. I checked the docs and there is a line about it not meant to be a dynamic state.

@Dan-Korneff I haven't ran into that one. Do you have a minimal test project?

@Orvillain said in [bug] SlotFX.setBypassed no worky:

What is the benefit of using const, in my situation?

I think the best answer is from Christoph

it yields a huge performance boost (because it can resolve the function call on compile time).
There is absolutely no reason to not declare UI widgets, references to modules (via Synth.getModulator() etc.) not as const

reg is good for accessing script level variables in midi callbacks and anywhere else where you would have had to use a script level var. But the more reg you have (and you only get 32 per namespace) the worse the performance gets. Internally reg is like a predefined array that HISE is keeping track of. So the more values you add the more data it needs to go through each time to you access it.

Another addition to Javascript: Use reg instead of var when declaring temporary variables which are accessed in the MIDI (or audio) callbacks. It tells the interpreter to store this in a fixed size container with faster access times:
If you have a script with lots of variables, the interpreter must search the entire array for every variable access (so the 23 - 40 ms are depending on how many other variables are defined in the script while the access time to reg slots stay the same).

It's also possible since you're storing them in an object rather than as direct references that const gives no performance benefit. But it's still good practice to use a const here. It makes it clear to other developers who might see your code (or your future self) that this variable is not meant to be reassigned, and it also prevents it being reassigned accidentality.