Bug: HardcodedSynth Volume Glitch

[griffinboy]

The hardcoded module volume slider seems to be modulating the first parameter in my hardcoded network (c++ node)

In addition to this, the volume slider forgets its value when I save and reload the project, opening at a default -12 every time. This could be tied to the above issue, where it seems this slider has become a modulator.

[Christoph Hart]

@griffinboy Yeah I noticed that too. I think I've fixed that though with one of the latest commits - are you on the latest state?

Might be possible that I haven't pushed the fix though.

[griffinboy]

@Christoph-Hart
I'll get back to you! I'm a version behind

[griffinboy]

@Christoph-Hart

The issue is still present in the latest build

[griffinboy]

@Christoph-Hart

HiseSnippet 878.3oc0Ws0aSCCE1dsFsV.I.wC6w7.OLPHTSuvEwCL1ZGTAsTsNP7Fx04jUqkXG43LnBw+M9Iw+.vNocIEJkQfMD8gpdtM+4ykOe1HkjAwwREBW+vYQ.BeEx3YB8z8lR4BT+tH7kIGBw5tIggyP6NKhFGCdHLtxyrNfqUEk94KOYWZ.UvfbUHzajbF7RdHWmqczNufGDrO0CNjGVv616zmIE6ICjIFvTgz.EQYGSOBFRstsAA8bZ7TD9NjGAS.VKZi1tM7630tkO.Ma+vV2usamNslzpyCZ1dB0sIEguTOOtVpFqoZHFgqtqza13ox2KxNf2vi4SB.qfKZr4jyTuuLvydEsZQ6MkG3MZQVJFgvjQ44rJY4raRFv83mpOO2csTCN4QTLAh2XY3UYI34VDdMJ.uU.IbAHUMCRWmLlo3Q5bKY0x9BMn7ol5TQnj4KB+YxdRiCB88BoGC6qLBmFv1sZz3tNlut8i8SDLMWJbjhgRM7Jw12t9GqWq9mp678l78WoM6wnjAAfZklssFp0E31hjvIf5tNmPCRfSczb8WNmR944zhkbV1stfiRQeAW+pHP7yZDPySUle859coZpsPLWmwuHPo4VHf6BmXFCxJK0Hcg3i0xHyfvOTyLcKRuj.pd4VH6f1bClbvR0MawQDy0yJNH9Wqu5rBwqSFw0roqFiarBLZxTmGXb9z3UI878AlNGfUI6+1ymQuhGesEonmSUdLogCIkIMEAakqzIUKDyiAk6ZXTQnyHiJBsZFUD56YTGB52KUGaI4GJcDKjprNZR2RRSdoyKZxpmsZ05g2+ASeKwpeZu0XdXT.zSbBDXnXRw3MLbJ9zj.8BsK2UMPJjQSkBNqXqwAfVwO5HPUD6q7B8Ts17PbtlatyAP.PiKzocqcdIW.TkIOAkLW39a+B2JqWaQxfqicTv4Ootcg1lsVFzJmIFz+53s7roWnotMI89fVQc+Uu47OtBOGlM+WAyCjIZt3nATyX+GL6EMLIbr4cAFXfnP.A1ckvaX2pIStgU1BnwfvKU3qlOyM5ZkwyM5tv3ExYDRYJ46XYaAZYF1LUi4dKR++DpQFXkcbQoaFVbhIz7Fy6Xrk+S8CA1rrA1prA1trA1orAd+xF3CJafO7WGncEfmlnkgYDfHzfQ8RWqFi6InlN9TtFz2.DdO26N

Set the hardcoded synth volume to full.
Save as a project, and close Hise.

When you reopen the project, the volume will be reset to default (bug)
In addition to this, the volume seems to still act as a modulator on the 1st param inside any loaded hardcoded module.

[griffinboy]

@griffinboy
@Christoph-Hart

Sorry to bother: issue is still persisting for me! I don't know if anyone else is having this issue?

[Dan Korneff]

@griffinboy Are you saying that parameter 0 for hardcoded effects are defaulting to the value of the synth volume? (-12dB)

[griffinboy]

@Dan-Korneff

I reload the project and the volume for the hardcoded module is defaulted to -12
In addition to that, the parameter also seems to be acting as a modulator for the 1st parameter in the hardcoded fx slot

I'm on the latest build (updated yesterday)

[griffinboy]

@griffinboy
@Christoph-Hart

Sorry to bump this again!
Am I the only one experiencing this issue?

[dannytaurus]

@griffinboy I tested your snippet and it happens the same here.

Has this only started happening recently?

I noticed the HardcodedModules files were changed about 2 weeks ago by this commit. It seems to deal with both the parameter offset and the getting the default value, so it could be the culprit.

- fixed remove matrix modulation connection via slider popup · christophhart/HISE@b1d5266

The open source framework for sample based instruments - - fixed remove matrix modulation connection via slider popup · christophhart/HISE@b1d5266

GitHub (github.com)

[Christoph Hart]

@dannytaurus hardcodedsynth was added there so it‘s not a regression.

It‘s a simple fix I just forgot to offset the parameter index for the amount of internal sound generator parameters (voice count, pan, etc).

[griffinboy]

This post is deleted!

[Christoph Hart]

So now it should be fixed - I haven't tested it because I was too lazy to make a node with parameters, but I'm fairly confident that I can no-look fix this :)

[griffinboy]

@Christoph-Hart

No good sorry!

Still defaults to -12db when reloading a project, and still acts as a modulator on the 1st param

[Christoph Hart]

@griffinboy Ah, no I think the issue is that you have a parameter called Gain in your network and this will override the actual "Gain" parameter of the sound generator.

I'm adding a safety check that will complain if you use reserved parameter IDs or other keywords (I already did that with Type as this will mess up your entire module tree, but since there are different reserved keywords for different module types this needs to be checked at runtime when you load the networks).

EDIT: Oops, no that's not the reason, I used the wrong enum for the offset so my fix didn't do anything. So much about no-look fixing...

Now it should be fixed.

[griffinboy]

@Christoph-Hart

Seems fixed, thank you!