[Bug] Moving sample to RR group sets it to 0

[d.healey]

I just noticed if I select a sample in the mapping editor and click the +- buttons (or enter a number manually) to move it to another RR group, it gets set to group 0.

[d.healey]

@Christoph-Hart Just been looking into this. The problem is triggered because you removed the range for the RR Group so it's just falling back to 0

HISE/hi_core/hi_sampler/sampler/ModulatorSamplerSound.cpp at develop · christophhart/HISE

The open source framework for sample based instruments - HISE/hi_core/hi_sampler/sampler/ModulatorSamplerSound.cpp at develop · christophhart/HISE

GitHub (github.com)

I assume this was done while you were implementing the complex group handler. As a workaround I've just set a range of 1 - 100 but what's the proper solution here?

[Christoph Hart]

@d-healey That should be OK, but shouldn't it be 1 - 127? If you're doing legato transitions the old way, you might want to set the round robin group to the start note and 100 might be too low. And I'm pretty sure that RR group 0 is not valid for ... reasons.

[d.healey]

@Christoph-Hart Huh, I think you're misunderstanding the issue - ignore my hacky workaround :p

Prior to the advanced group thingy you could select a sample in the mapping editor and press the RRGroup + or - button to move it to another group.

In the current develop branch pressing one of those buttons will trigger the jassert at the line above and stick the sample in the non-existent group 0.

[Christoph Hart]

@d-healey but if you return a proper range in the function, it doesn‘t reset to zero, no? Because that‘s as good a fix as I would do it…

[d.healey]

@Christoph-Hart Correct, but it should match the number of groups the user has set, which is the previous behaviour - I can do this but I figured you'd changed it for a reason.