@Morphoice happens here too, no idea why

@Morphoice The solution I used was to keep track of all note on events, then if you ever receive two note ons in a row on the same note you know you've received some illegal MIDI.

It's pretty easy if on noteOn you check and store the event ID to an array (or MIDIlist I suppose) like

onNoteOn { if (events[Message.getNoteNumber()]){ Console.print(You've just received some illegal MIDI!); } else { events[Message.getNoteNumber()] = Message.getEventId(); } } onRelease { events[Message.getNoteNumber()] = undefined; }

How you handle the lawbreakers is up to you, but at a minimum it's best to stop everything on that note, as this situation breaks the assumption that every note on will have a corresponding note off.

In my case I'm using artificial events, so stopping them all is easy. I don't actually know how you'd go about stopping the normal events.

Give Synth.allNotesOff() a try, I know that doesn't affect notes with a timestamp in the future but I assume it works on stuck regular events.

It would be nice if we got this built in similar to setfixnoteonafternoteoff

@sletz Well, I just discovered that https://github.com/grame-cncm/faust/tree/master-dev-ocpp-od-fir-2-FIR. branch is still quite buggy, so no need to rush 😧

@Morphoice

You can map it to a function of best fit using python / matlab.
Ask chat gpt how to do this from a table of data.

Alternatively you could create a lookup table of accurate values.

I didn't realize you were going for analog tracking, that's a different case to digital, yes.
The tracking lookup only happens once per note, so you don't have to worry about efficiency here. Envelopes by comparison need optimization as they are applied per sample.

@aaronventure my bad, it was the detune thing from the example, triggering two notes at once

@aaronventure yes thats actually the one I was referring to it should be smooth already.

@aaronventure that certainly looks cool but would be inconsistent with the UI of the other plugins I made so far. Also my resources are very limited and I'd rather spend them on making a good sounding plugin right now and getting all the copy protection and distribution sorted before indulging in fancy lens flares ;)))))

@d-healey it's just intended as a nudge to upgrade, not a sort of copy protection. I guess those not able or willing to license a plugin AND able to crack/bypass wont be kept by any sort of method anyways, will they?

@aaronventure also held keys just stop when the sustain pedal is released, even though the key is still pressed. this happens with faust envelopes

@Morphoice that depends on where the file is, right? but if you're gonna do it from the packages installer, then yeah you'll need elevated permissions.

@aaronventure Thats exactly what I would like to do. I've been trying to figure that out from the start. I know thats ambitious for a noob but i've figured out most of the stuff I need to know to get started. Im alot more comfortable on the design and audio side than scripting so im currently trying to learn as much as I can from everyone here. Thanks everyone!

@Lindon no worries.

@VirtualVirgin everything is calculated in faust. there is an input for aftertouch pressure and an aftertouch intensity knob that goes from -1 to +1 where at 0 aftertouch has no effect and on +1 it opens the filter (on -1 it should close the filter respectively)

@clevername27 thank you kindly. but it is far from done or perfect, we still need to get a lot of things sorted that HISe either can't do or no one could tell me how to. The polyphonic aftertouch being one of them.

@Christoph-Hart bump

@Christoph-Hart you gotta be kidding me. I didn't know there was an inbuilt one. How great is HISE?!

@sletz fixed thanks