Modulating ShapeFX Gain

[dannytaurus]

@Christoph-Hart Do you have any objection to me adding modulation to Shape FX Gain param?

The Drive param in Polyshape FX already has modulation. I just want it for ShapeFX too.

If you don't want a PR, I'll just do it in my fork.

Also, if it's terrible idea for some performance or complexity reason, let me know!

[Oli Ullmann]

@dannytaurus
I tried modulating it using the matrixTargetId (slider), and it produced some unpleasant crackling noises. Maybe that's why modulation isn't intended for this...

[David Healey]

@Oli-Ullmann Probably will work with smoothing.

[Oli Ullmann]

@David-Healey
Yes, maybe.

[HISEnberg]

@dannytaurus I believe the majority of this module exists as separate nodes in Scriptnode (math.algorithmName). My understanding has always been that the ShapeFx module is somewhat dated and would be deprecated except that it is in use in older projects. I.e. you could get away with recreating everything inside Scriptnode already without needing to modify this module (whatever is easiest in your case however).

[Christoph Hart]

@HISEnberg this. The structure of the shape FX module is somewhat limited and you can easily create whatever wave shaper + signal flow you want in scriptnode and if you compile it down to C++ it's about as efficient as the inbuilt wave shaper.

[dannytaurus]

@HISEnberg @Christoph-Hart Ah, I just found out that ShapeFX isn't voice-aware, and I wanted to modulate the Gain with an envelope.

ScriptFX it is then...