Alright, the z-order should be fixed now, it also monitors the slider's visibility and hides itself when the parent slider is hidden.

If we could get a delete button in the Mod Matrix itself for each row that would be super useful!

Yes good point, noted.

@toxonic yeah I‘ve removed the mda effects a long time ago. There‘s enough stuff in scriptnode to replace it.

@DanH said in Matrix Modulation System - Last Call for bugs fixes & changes!!:

I'm not 100% sure that other devs show the accumulated mod range.... actually some do, some don't, but not either / or, they display it on top of the current mod range.

I'm pretty sure that's the case, otherwise you end up with invisible modulation that is super annoying.

@DanH yes that's intended, otherwise you will never get back the behaviour of showing the accumulated mod value. How would you do this instead?

@DanH not sure what you mean, the draggers are just like any other component, no?

@DanH It's pushed now.

You can just load the exlusive mod snippet posted above, the changes should apply without modifications (I assume nobody is using this feature in a product yet so I don't care about backwards compatibility).

Well it shouldn’t be a straight accumulation (aka addition) because a positive value can compensate a negative one perfectly, drawing no arc at all, while the modulation actually moves following the combined value

The range display covers the min max value while the modulation value combines it.

If you have two modulators, one set to -25% intensity, the other to 25% intensity (both in unipolar mode), and the value is at 50% position, then the modulation range will cover 25% to 75%. If both modulators crank out 1.0 as mod value, then the modulation value will sit right in the middle where the value is supposed to be.

That being said there might be a few edge cases and combination of modes & intensity where the math doesn't math, but in general that should already be the case.

Alright, so now it looks like this:

1. When you select any source, it will show persistently only the draggers for each target that is associated with the source without hovering / exiting.
2. The modulation display will switch from showing the entire range & value to the currently selected source
3. Click on the selected source to switch back to showing the entire modulation value.

This mode is only engaged once you define a function for the setExclusiveSourceCallback() method of the script matrix so the default behaviour won't change.

@Christoph-Hart Ah now I understand yes that might make sense.

So basically would could happen is that we use some kind of "solo" mode for the modulation ring display around the knob:

• if a exlusive source is selected, then it will show the modulation for the given source only
• if no exclusive source is selected, then it will show the entire modulation

For this to work you need to be able to untick the exclusive source, but I've added that anyways to the matrix draggers now.

I'll post an video to show how this would work...

Currently it's like this (or it's supposed to be like this minus a few glitches):

I'm referring to the default LAF seen below, but all that can be customized

grey ring around knob = modulation range of all connections combined. This factors in all intensities and applies them correctly using their respective mode.
bluish ring around knob = current modulation value (not present here as there is no voice currently but you get the point)
purple ring around popup slider (the big thin ring on the bottom) = modulation range of the current selection

I don't think you need to switch the display on the knob between the modulation of the selected source, as this is covered by the (now permanent) hover popup.

@DanH but in all the examples you showed the mod dragger also shows the intensity range not the mod value, no?

This shows a bipolar mod range for this given mod, just like the other examples.

The MacOS build of Projucer has not been codesigned/notarized so it gets flagged by gatekeeper

Was the previous build codesigned & notarized?

The export setup Wizard has not been updated so it's still looking in tools/projucer

Good catch!

there's no way to show just the mod range of the 'currently selected source'

Ideally the ring around the knob shows the accumulated mod value while the hover popup shows the range for the selected source.

@Christoph-Hart ah nevermind I read your previous post. No that's a separate fix and involves fiddling with the math that calculates the mod value. If you can come up with a minimal example that breaks the range display for multiple mod sources, it would help.

@DanH what do you mean? the range is a property of the target, no?

@DanH ah yes, so they are still created & deleted on hover / exit. I need to check the code, but it should be possible to remove that logic and move it to the selection, so we get this behaviour:

if(EXLUSIVE_MOD_SOURCE == true)
{
     onSelectMod => show / hide mod sources
}
else
{
     onHoverOrExit => show / hide mod sources
}

@DanH isn't this precisely what this example is doing?

https://docs.hise.dev/tutorials/ui/index.html#exclusive-matrix-modulation-source

@Oli-Ullmann said in Exclude UI elements from updateConnectedComponentsFromModuleState():

The attack slider is saveInPreset

That's your problem. You're basically saving it twice. Just set saveInPreset to false and let the module state do its job. You can use this method

https://docs.hise.dev/scripting/scripting-api/userpresethandler/index.html#updateconnectedcomponentsfrommodulestate

to update all sliders after the preset has been loaded.

@johannesagust you're not using the latest build. Make sure that you've pulled the latest develop build. The custom layer should have these things:

Does this feature work as expected for everyone else?

That thing is fresh out the oven so I guess nobody is using it at the moment :) If you don't want to guineau-pig this, then I would suggest you stick to the old setEnableRoundRobin(false) way of handling group logic.

@Oli-Ullmann Ideally you just create one GitHub issue per bug, then I'll slap the mod-matrix label to it so I can filter the issue list and work my way through it.

I've already added the label to a few issues from Greg.