@d-healey said in [bug] Macro control modulator index off by 1:

@tsempire

this makes the Pitch ?

Nothing to do with pitch

😂

@ulrik I think it's 'cos synth group has some voice handling functionality that silent synth lacks.

We can get around the need for the group by adding a voice manager to the original network:

HiseSnippet 2289.3oc6Zs0aaibEdnjGaKGm3jMtcytnEP.sEHKRhfHkDkzVfsxwWhEZ7kX4MMsuDLgbrEgoH4RRYa0EEXeq+BJ5q8s9ZequleB8s92n+BZ6YtPQRYIYYkXassKMfglKblu4Lmy24Lmg666ZPCBb8QJ4NrmGEorLtUOmv1q2lX4fZtARYdbHMHD87ddjf.pIRQI6KXsojaND+4e8qdNwl3XPiqBgdsqkA8kVcrBiqc+F+ZKa6sHlzCs5jn2kazzv0YcWa2t.NxhKh7HFmPNltKg0sLX.DaZZE552Jj.fAoL2ycM60ps6YNh9+Zq.q2YSYETQsfART8Vt1lLDypEsdaKay8iVuAHjxB6Gu5yJV8qh2wxzpe8wRg6yaHe7ajTdnjIM7xlBdpIgWwDvaHPRIAjlS.oGfaY3a4EF2BCO2A2zIj5eDAD6IghnuHk2iW2E5fSXgNjSna4CE5+BOVuXwmlG92W7KOpqiQnkqSdWmccCo6473uXoucobK8GVJ+fMczQCsM1z36ZaS8GZyrcZ+w8hO1oam2Q8eZ9SI1co86Hr7SKSwiVllbK2PrpSzQWmlNVg64QcFkh.RJpXxeIpfoOjK8uqT5eHgMYVfLdQL+2pHNfSpyaRBIHEJtpVgzOmt2S9M+NqpNddd5qyK2b8Zcq+F6e6V0DkOrp9ZO4nsauco9su2SJzUOrrnL7uidBanpKJiPecyMXSmDx.5gUjG0OzhIrT1fdJX+ITfxg2fFbRnqGuuc7bcXqUkEtzE34wKtedidwEZ13LKyv18q36NoQap0wsiM0e+wM7hDvMMY5v7gL+lNmRsAXB6BWTQGLwbM6ZSBSa2wHajM.JNoT1YZzNAVg8RRF8QyXbRg3Cv6aEZzd3XLyPvHroccfQIE1cwadzQTivX.NGdq2b8vWkb5WTL8eN9E1tuiXGKn.0S.ITAu0OU1b99smueGTGiSl+wj5jwahcxnjcbNUTmRmJyMy4TYR0ie3E1ZBtAs1Txj.l2Q.yUDzFQrFRqsAoRRhwcbcb8Z65XYjTO4.Znu0wGS8SEzhkmqMwejqr0BCgnPj07W7l6O03.pMkDjRmRzINh13Fj8WhjDy6u.qUNdJqOv6IwwUg2Qcx2sFmR0mhkhHvXL+LMM9ivQR0YBndeATW.u11az5.opO+22Tp9q20+zTzsaPMH8tPsorSPn+1eTZT7RJfxjcbaf37BCW+JJ+WazpaPXLo+2sZge16GhI2lFtvlCcJ2.tD0Z7DprbWoZcdtSlYOk46EgOwtvrG.WFy29mUkeqfkJiyrBv6EQWMqJBGaXwY+e6vhOvsankyw6P.xW3TT3c61oED2oAElcGGpM67rJYXm7TTtHqLSBzh5XxK7efGYiprxJxFUiZL4RL2goNJGOANReZhZb.By7rpoAVACDnclq8.sixIwSwWky+O+0Qz4y+81nyuEOHbprRkKBisr53MPr4eBPpeDoqc3GbDJWdD4vypWHh7+8euwKgSRR7u9hPPYhCmLQDB4+9aBLx9+MIvXbhnEwaddnOQcFb2SBMsaRncS3eqeRYQ6RCOy0+Dt0m72vAijQQF3EU0Z11tmwRvokTKlun30tuqcuHlG9Jk5Gv6wB3hEf+PhWKB9q0wsKKEoh0v1jfCIV1LWkPPgd.H2yoEzYtORPWTYWNYCdKhAHb6sOgkZzGfMhRqUAijQ8Fi238KlTlMHQNMExJ.Sc3YpkcAHYYsyj.YkylX3bCL.mvLEBzEldeZgDMe0lMl7vlddTJl2vJvylz64cACSAKXpZfxMcLomyrTeFK2tDeRGZHU5xMpDLU6X47ZQZywLIOZGx48KWFJ2Jj50x52yKqBkEW.EmMue+X0iRLnyGOnyi0ROp4fJfmTi7pvLqVT7nVtdQUUcfy+D5YBInnCZZ0qWrbEcMsRkqUsVE4ktrkO8a5B678hfyBXM9ThF0pTMEdlGqpOhk4x7AO+ALc2QuXGqDTcjRvW.V7idPm6xFT1fr.d+1Leso53UdTlmGFyfPI9pKPnD52KfIsMCFP099XpL5hBhVuRZ13jyE2YNqDPSlQbrOfIKg1aDL47.nVmwbSdHw+XZHOGXIqPdSLNTd7sAoKB8kgK1UgrB9TVvzusCwgvB5o+rwZbYLKl577vsSOeWX3QWUSzLIMQ2Dh41DBTVj7PPvj1lM2vMuFbaMGVc5rtTqWUuppdMU8xZUJoUR5HSFf2GlFVTpYDGbeRXMtdWVyi4I9JMC0sBRVPjykXpqREmJIbtnjijbmpxsyZJWTZPhvxCw5kJoUnJLR0KWRubkZkldcHQxNG4pbpHiuCN9DOiTS+iBMOePiipuOwURJ1AoiRQ09nXp1z85JQ4lIE0hxG5pLEG4ZcCc6.KZdhLR6GI4rhFKq+x3lAul0pAoOgALZSyMrOjKD8tXdvhIxJyJxZ3Yjo8Obqmyr4UIyO7AFbKe97T2y3Jh4+SwaS7MM.RGy3y0A.fgjOOts7wMleq2nNHmUz4HWBGzErpCHmg5HnE4LMDYtlD7RhR1hazRzASwsWsHtbYUV4fnKuZU7ypB9pXO0JVWSuhZopH+nDU8PrZEUguNc0hkpnVQGFpvtNRufZEKWUsrVoZ5LmW5ZHOVP2Ad9ThYzT6QbFnBl5AR4GwvZ4R0KVoJL100.+nfWxiiPUkBBPUQud4Z0pnU45gKXRRNPVrVhTCvUBDIFfGbZbdA3yqHq.xSVdgDQ9I3DJAV1gxuyjbXQgwwthPwGmSV4+7q9yMdURi8zIR7QMdUWh8.1ZxaS8C0N7Rx63bSHYwON9Lp2NYcLkI6RBj9YxOsjn7B2G2bH+Sh9vShZN9KPYJSfLBMz03WK+jIDBgSAe4hwMw2QADvRxis8rw84J8kC9kn7Qa2F8QTDlJwfYl0DgC9EMbsHBGuyUFovrcB5+LrjiIOOEQyzX8d3WcKAvahjReSLGcHF9tu0Pb8nLB0E40.qaG92CeN7Nrx4GxWfbGHv52ZXjdntvKpMsuXoo8EKOsuXko8E0m1Wr5z9h0t7WjctG4IVY1Fvgy2eSAmoxlNLBTtYB5+RI3Fhp

Lots of good information on this here.

If you ever figure out how to modulate parameters within a hardcoded network, please let me know! So far this has eluded me.

@ulrik The same scenario except the Filter and Table Envelope is inside a "Sine Wave Generator" instead of a "Silent Synth"

Hise will crash on Note On

@d-healey Ok, so we need a way to have a static object without crashing the leak-detector and/or pluginval. There must be a way, there are other static objects in JUCE itself. I wonder how the ImageCache class does things.

@Christoph-Hart what are the implications of this for compiled plugins? Is this only something that is of concern for working in the HISE IDE?

@ulrik 3.6.2, 23 Sep 2023 built. I just downloaded the release from "develop" commit and the crash still happens. Anyways I gave up with that, I just tried to use it because I have more experience in web programming, but I decided to learn more about hise scripting :cowboy_hat_face: Anyways I think that is important to report the bug.

@d-healey For me the only thing different was having to create those two folders manually. Everything else works the same.

Yeah the problem with that is that I changed the way how icon path data is handled (I tried to reduce the binary size of HISE by putting all path data into one translation unit), however I need to update all places where I use the icons and if I forgot something, it will be an empty icon like here.

I get an assertion if I try to render a path like that in my debug builds, however it appears that I haven't opened that particular window for quite some time :)

@Christoph-Hart thank you now i know EXACTLY how to exact my revenge :smiling_face_with_horns:

@d-healey It seems like you were getting the same issue as me. I guess, that one bit was fixed, but there will be other bits to take care of. OK, I'll leave that for the end and consult my buddy, Chatty.

@aaronventure Thank you! Got it.

@Christoph-Hart when I open the project in Visual Studio, I get a bunch of errors off the bat.

Severity Code Description Project File Line Suppression State Error (active) E0020 identifier "activeMessage" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 90 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 26 Error (active) E0262 not a class or struct name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 26 Error (active) E0260 explicit type is missing ('int' assumed) My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 29 Error (active) E0020 identifier "AsyncUpdater" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 29 Error (active) E0065 expected a ';' My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 29 Error (active) E0864 Atomic is not a template My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 38 Error (active) E0260 explicit type is missing ('int' assumed) My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 40 Error (active) E0757 function "juce::<error>::AsyncUpdaterMessage" is not a type name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 40 Error (active) E0065 expected a ';' My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 41 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 44 Error (active) E0020 identifier "activeMessage" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 46 Error (active) E0079 expected a type specifier My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 46 Error (active) E0258 'this' may only be used inside a nonstatic member function My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 46 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 49 Error (active) E0020 identifier "jassert" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 55 Error (active) E0020 identifier "isUpdatePending" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 55 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 56 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 57 Error (active) E0020 identifier "activeMessage" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 59 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 62 Error (active) E0020 identifier "JUCE_ASSERT_MESSAGE_MANAGER_EXISTS" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 66 Error (active) E0065 expected a ';' My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 68 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 74 Error (active) E0020 identifier "activeMessage" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 76 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 79 Error (active) E0020 identifier "JUCE_ASSERT_MESSAGE_MANAGER_IS_LOCKED" is undefined My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 82 Error (active) E0065 expected a ';' My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 84 Error (active) E0276 name followed by '::' must be a class or namespace name My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 88 Error (active) E1670 a type qualifier is not allowed on a nonmember function My Test Plugin_SharedCode C:\Users\Dan\Documents\GitHub\HISE\JUCE\modules\juce_events\broadcasters\juce_AsyncUpdater.cpp 88

Am I doing something silly? or is this something else.