HISE Sampler VSTs Crash? Across multiple brands (FL Win)

[dannytaurus]

@Straticah I can't reproduce in FL Studio on Mac. Is this only happening on Windows?

What versions of FL Studio are affected?

Have you been able to narrow it down to a specific HISE commit, or approx date range of commits?

[bendurso]

@Straticah I can't also reproduce it on mac with my plugins. Not sure about windows, I don't have FL Studio installed on my windows computer.

[Straticah]

Yes this issue is on FL-WIN only it seems - like always :)

[HISEnberg]

@Straticah Not happening for me on FL on Windows either (at least for my plugins). Are you using a lot of image files? It sounds like FL Studio crapping out trying to load resources from disk. This may be a DAW related issue rather than a HISE one (I know you say it happens in other DAWs however)?

Also are you using a Webview for this plugin? I imagine that may be the commonalitybetween Fraction and CUBE?

[Allen]

is the "make bridged" enabled ?

I havent encountered any crashes in FL Studio(Windows) so far with my plugins but i found if i double click the open button, the display window will glitch when the plugin is loaded as bridged.

[Straticah]

@HISEnberg

We are using a Webview same goes for Cube - correct. I was assuming the data refers to expansions because FX never produce this issue.

A build without bebview will be worth a test!

[bendurso]

@Straticah Oh webview on Windows could be a trigger. I had to remove the webview on windows because the plugin was loading so slowly.

I made a post a time ago about it: https://forum.hise.audio/topic/13464/webview-doesn-t-work-on-compiled-plugin-in-windows/18

[Straticah]

@bendurso It is loading slow indeed but not much slower than other VSTs.

The webview works like a charm so far (which is surprising) but it could be the issue.

Might have been coincidence theat the only HISE "other brand" vst i had installed was with a webview aswell? :D

Will know more once i bypass webview from my build...

[dannytaurus]

@Straticah said in HISE Sampler VSTs Crash? Across multiple brands.:

A build without bebview will be worth a test!

100%

[HISEnberg]

@Straticah Yea I suspect this is your culprit:

https://forum.juce.com/t/br-webview-freezes-daw/64917

Do you have enablePersistence set to true?

Do you get any useful information when running your plugin through pluginval?

[Straticah]

@HISEnberg Guys you were right the webview is the thing that crashes Lunacy audio Cube and also my plugin...

Pluginval shows no error all working fine there.

In order to NOT crash i had to remove (not only hide+deactivate) the webview panel + its code.

Seems like something thats not fixible from my side - and that a more "famous" vst has this issue gives me less hope that i will be able to solve this 🫠

[David Healey]

@Straticah I think Mndala is also using webview, does that crash for you?

[Straticah]

@David-Healey it does yes:

[David Healey]

@Straticah I'll let them know

[Straticah]

@David-Healey thank you :)

If anybody gets some insight on this - it will probably help a dozen HISE + WV plugins.

[HISEnberg]

@Christoph-Hart a good candidate for the your new Claude/Ralph system? This one is a bit over my head unfortunatley... Maybe just confirming the Webview is always running on the right thread and it is properly addressing race conditions in FL? Just a reminder the issue sounds very similar to this one: https://forum.juce.com/t/br-webview-freezes-daw/64917

[Straticah]

@HISEnberg @Christoph-Hart So the only solution right now is to remove webview from my VST?

I mean its possible to rebuild the browser in HISE, but want to check before i do.

There is more than 1000 people using the VST right now - getting a fix/workaround from my side is kind of expected from me.

[HISEnberg]

@Straticah It will require some careful edits to the HISE source code to properly fix. I haven't had time to investigate it personally. You could try deferring any callbacks to your Webview before it is launched. If you use Content.callAfterDelay(int milliSeconds, var function, var thisObject), it may give the host time to respond to multiple instances of the webview loading simultaneously. If this does work it will only act as a sort of bandaid to the root issue.

[Christoph Hart]

@Straticah Can you try to make a minimal example that crashes FL Studio? You can start with the webview examples in the hise_tutorial.

Ripping out the webview for your preset browser would be the wrong move, let's see if we can fix that.

[HISEnberg]

@Christoph-Hart This already happens with any of the examples from the hise_tutorial actually. Just export one of them on a Windows machine, load it in FL Studio, and click on it a bunch of times. You'll receive the same crash report (why users click on it a bunch of times is beyond me, but this is FL Studio we are talking about).