Please Increase parameter limit on Scriptnode custom nodes!

[griffinboy]

@griffinboy
@Christoph-Hart

Sorry! I'd really find this useful

[HISEnberg]

@griffinboy I'm bumping this too! I'm working on something that is definitely going to go past this limit!

[griffinboy]

@HISEnberg

Yep, definitely need support for obese nodes

[HISEnberg]

@griffinboy it's the only way to get those fat sounds

[modularsamples]

What if you used global cables instead of sliderpacks? As a bonus it should be easier to keep track of your connections.

[Orvillain]

This looks like it is probably the same thing I ran into:
https://forum.hise.audio/topic/9760/do-snex-nodes-have-a-limit-of-9-parameters

Chris extended it to 16 iirc. This is changeable, but you have to add a bunch of switch statements to HISE and recompile. I'll dig out where I've done this to increase the parameter count myself.

[Orvillain]

I think it is this:
file:///hi_scripting/scripting/scriptnode/snex_nodes/SnexSource.cpp

Look for these lines:

case 8: p = parameter::inner<SnexSource::ParameterHandler, 8>(pHandler); break;
	case 9: p = parameter::inner<SnexSource::ParameterHandler, 9>(pHandler); break;
	case 10: p = parameter::inner<SnexSource::ParameterHandler, 10>(pHandler); break;
	case 11: p = parameter::inner<SnexSource::ParameterHandler, 11>(pHandler); break;
	case 12: p = parameter::inner<SnexSource::ParameterHandler, 12>(pHandler); break;
	case 13: p = parameter::inner<SnexSource::ParameterHandler, 13>(pHandler); break;
	case 14: p = parameter::inner<SnexSource::ParameterHandler, 14>(pHandler); break;
	case 15: p = parameter::inner<SnexSource::ParameterHandler, 15>(pHandler); break;
	case 16: p = parameter::inner<SnexSource::ParameterHandler, 16>(pHandler); break;
	default:
		jassertfalse;
	}

Add as many cases as you need and just increment the integer.

[griffinboy]

@Orvillain

Thank you very much, super good.

However I would wish it to be changed in the official version of hise, as I like to share nodes and I'm trying to keep the amount of source code tampering to a minimum - some of my nodes already require changing a few things in the Hise Source.

[Orvillain]

@griffinboy said in Please Increase parameter limit on Scriptnode custom nodes!:

@Orvillain

Thank you very much, super good.

However I would wish it to be changed in the official version of hise, as I like to share nodes and I'm trying to keep the amount of source code tampering to a minimum - some of my nodes already require changing a few things in the Hise Source.

@Christoph-Hart - it might be worth considering updating the code so that a global variable determines the number of supported parameters, much like the NUM_MAX_CHANNELS variable???

[griffinboy]

@Christoph-Hart

Can we get something like this please?

[Orvillain]

@griffinboy I looked into this, and it seems like dynamically altering the switch based on a global parameter is not that straight forward. So I think the simplest solution is as Christoph did in the past, which was to manually extend the cases, as I also suggested.

The problem is..... 16 was enough for me in that moment, but maybe not the next.... and for you, you need at least 40 or so... and for the next guy, he might be a madman and want 128....

There has to be a better solution to this, but I'm not sure what it is. Maybe storing each case in a table and using it to build the switch out at compile time, but my c++ knowledge isn't good enough for that!

[griffinboy]

@Orvillain

That should be possible

@Christoph-Hart ?