Latest version of HISE breaks existing presets....

@Lindon Well I just noticed a very similar problem with my project. Every time I hit compile my pan knob was getting set to -23 and my volume to -97db. These values are not in any presets or the project xml.

I disabled isPluginParameter and the issue is gone. But now they are not plugin parameters...

As soon as I reenable that setting the issue returns.

I tried to recreate it in a minimal project but no luck.

Oli Ullmann

@David-Healey
Is this an older project that you created with an older version of HISE, or is it a project that you started with a newer version of HISE?

David Healey

@Oli-Ullmann Older project. I'm seeing other weird behaviour too with any knob that has isPluginParameter enabled. In one case moving a knob is moving another knob even though there is no connection between them that I have made. Again, disabling isPluginParameter fixes it.

David Healey

Ok I managed to make a minimal snippet.

@Lindon are you using Macros?

I found if you have a knob connected to a macro it will control another knob that has isPluginParameter enabled. Even if that second knob is not connected to the macro and the first knob doesn't have isPluginParameter enabled. There are some crossed wires somewhere.

HiseSnippet 896.3ocsVE0aaaCDlzILawasXsnur2zioCEEVMNNonOTuDmr40kTsozhsmBnIohILEofDUW8FJP9az9OYu4eR6ev1QIEK4lfDGCL8PPNd2Q9wu6tO5fTCSjkYRQ31mNMQfveMIbp1N9fwToFMb.BuAwJhSP6OMglkI3HLdsev4Cu45nhu+4k6SUTMSTuDB8VijI9YYrzVuZP+WIUpinbwox3FQ2s+PlQefQYxAbrFoCJgxlPOWbB0EVKB5GoYiQ3uiv3cYcY8F00mRi10eTOwn8720WrGaG9yYLJamQL+s2lBn9PtzZRCsTqHC1z8M7ogiM+gt7.dqLSNRIbF9nP3jKWFcvXohGbIojgP30Cpon0JonGQNVxkyWulp9lBGd0YzjzvstIH4eGfDtAjVuDROfDxRkI1ZON77UjgZqHMhB0llPoLVDdF4.CDf19zX5DwQofw7D1pWmNOwC9yieQTtlYkFsmQehwJdsdqG29uZuY6Oz16ycEEcs9bGSpQoDoWqaW6P5Mk3V573Qhzm38NpJWLOP35uHmtwxworxaci.M5gZo80IhJ6iLJtiqb++Uq.nJZCpEspPHDpsnRb+pJQnRxEoHIrIeA4UZyHeTA3qZ6u3ieauYnkN4msPxP5+TezaFNfZot9gJ3.PLQjZkNl.OP7NXBrr6XSx.Q1DqIo.uwIFsC736eqH980CoC5Os13j9Y1oNdcih.QwRNWIBLYRWcqNtmMKyJRBk+YAx+zGce+8Kiapd76yhouuoxQVdTjDVgP736ihjp3LK.ugwff.B+PxaxDdbQDMWY8xl.akRpmH3mZJTJjYAp7yk5.ZJHd.8x.UzJ1vqXAlbjP4peyIg6cqLeM5t3WZPBWDsjjPP+ZRfP7eZGzBD.B0j.lcV+KI.31bWu8wTVpYdS0ljic1dPK7UUL.sJCOWQsKJf4j1qb3tDMUMbRCZ3xMsoz+cPUqyMppsrP7Aj.okM95wXqqAitgz+GvX0aA2ibXTjfYqA35ji9sUU3+VN9e0jak5yOlBsDtIjSxiCg2LYB3z0ZgB1bBtkSepztiy1w.gBMuv3eguJm9NabkS+KcV1BcFqrGx8ZyWVrBfIcwqw0MUWQQBF.jmwXKtUWIwOWJyM.rTIt8plX2UMwcV0D6spIt6pl3d2dhteax2maMwkiMHzwAGV7BBFenlBcfEcqn+CL6E4pE

Move knob2 and observe knob1 is moved, there is no connection between them that I have made.

dannytaurus

@David-Healey I'm sure this was reported elsewhere recently...

David Healey

Ok I managed to "fix it".

Add this HISE_MACROS_ARE_PLUGIN_PARAMETERS=1 in the project's extra definitions. No need to recompile or anything.

It seems backwards to me though, surely 0 should disable it (0 is the default value).

dannytaurus

@David-Healey It was here: https://forum.hise.audio/topic/14121/issue-macro-taking-the-priority

But I see you found the answer anyway. Maybe post over there too, I'm not sure of that post was ever resolved?

David Healey

@dannytaurus Actually it's not the solution because now all macro's are exposed as plugin parameters which I don't want.

dannytaurus

@David-Healey Yeah, I think Christoph said as much in that other post.

David Healey

@dannytaurus @Christoph-Hart Yeah there's a bug here that is making plugin parameters and macros together unusable unless you want macros to also be plugin parameters.

Lindon

@David-Healey so yes I'm using Macros in the offending project, and like you I DONT want them a plugin params...

Oli Ullmann

@David-Healey @Lindon @dannytaurus
Macros are new to me, but I now use them as modulators. So far, I haven't had the problems you've had with this approach. Maybe this approach is something for you. It has the advantage that I can use the macros within the new modulation system.

I create a MacroModulator in the GlobalModulatorContainer.
In the MacroModulator, I select Macro 1 as the target.
I select the MacroModulator as the processorId and MacroValue as the parameterId.
To be able to modulate the macro itself, I assign the matrixTargetId.

The user can assign the macros in the finished plug-in as modulators.

Lindon

@Oli-Ullmann Sadly - see below I don't think this is flexible enough or fits with my current approach to using macros...

@David-Healey
I might be OK with this solution as I don't actual use or include Macro controls in my interface, so as usual (when will I ever learn?) I'm doing it a bit different to most people....here's an explanation:

First there's a set of Macro Modulation Sources: every one of them is an LFO:

I "just" define these as macros like this in the code:

	const NUM_MACROS = 6;
	reg mpos;
	
	Engine.setFrontendMacros(["LFO1", "LFO2", "LFO3", "LFO4", "LFO5", "LFO6"]);

Each LFO gets a UI to manage the LFO itself..only:

..and the user can thus freely assign/unassign them to any UI widget they like, by right clicking on a widget, here the Voice 1 Pan control:

When they are assigned the UI control looks like this (using LAF):

Its pretty simple but it seems to be upsetting HISE post April 6th....meanwhile when I get some space I will build a recent version of HISE and try your fix....

Oli Ullmann

@Lindon
If I understand correctly, your project would actually be very easy to implement with the new modulation system, and you wouldn't even need macros anymore. However, you would have to rebuild your project, of course... It would take some work, but it would make it super easy to add new modulators in future updates, if you wanted to.

But maybe I'm misunderstanding something. :-)

David Healey

@Lindon Yeah I'm not using macro modulators in mine. I'm just using the macro knob's as a way to make one knob on the ui control multiple modulator parameters without me having to script it.

Latest version of HISE breaks existing presets....

15

2.1k

13.2k

114.3k