Latest version of HISE breaks existing presets....

[Lindon]

@Lindon

so I took this example:

Interface: we are setting the Master volume to:26.90000152587891
Interface: we are setting the Master volume to:9.500000953674316
Interface: we are setting the Master volume to:26.90000152587891

where (As in all other cases) the middle value is correct... and looked thru the preset for the middle value:

correctly found here:

    <Control type="ScriptSlider" id="MasterVolume" value="9.500000953674316"/>

and the outer value: 26.90000152587891

..and I cant find anything set to this in the preset.....so its not I think copying some other widgets value..

[dannytaurus]

@Lindon Which commit of HISE were you using before?

[Lindon]

@dannytaurus 3+ months old - cant remember...

[David Healey]

With your master volume, are you doing the save in DAW trick so that you can change presets without the volume level changing?

[Lindon]

@David-Healey said in Latest version of HISE breaks existing presets....:

With your master volume, are you doing the save in DAW trick so that you can change presets without the volume level changing?

nope...

[Lindon]

@Lindon I reloaded the Old HISE version and tried with that this is what we see in the console:

Interface: we are setting the Master volume to:5.100000858306885
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-3.799999237060547
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-8.799999237060547
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-3.499999046325684
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback

So working fine there....

[dannytaurus]

@Lindon said in Latest version of HISE breaks existing presets....:

Interface: we are loading a preset for version:30100.0

What is this line?

[dannytaurus]

@Lindon Which HISE commit is the older version?

[Lindon]

@dannytaurus this is a console.print of the preset evaluation fo r 2.5 version management - it is basically saying "Im doing nothing.."

I completely remooved the preset post load function just to make sure it wasnt this that was playing silly, it wasnt...

[dannytaurus]

@Lindon So we're getting multiple callbacks in the newer version of HISE. If you know the commit of the older version, it will make tracking down the bug a lot easier.

[Lindon]

@dannytaurus said in Latest version of HISE breaks existing presets....:

@Lindon So we're getting multiple callbacks in the newer version of HISE. If you know the commit of the older version, it will make tracking down the bug a lot easier.

yes it would....

but meanwhile - I made an entirely new preset and saved it......to check if it was affected by this problem...

Not only was it not affected - but all other presets now start to work properly....

Interface: we are setting the Master volume to:-7.799999237060547
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-11.79999923706055
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-8.59999942779541
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-5.59999942779541
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:3.700001001358032
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0

Worrying

[Lindon]

@Lindon close and re-open HISE and its broken again...

[Lindon]

@Lindon this is what the about HISe box shows me:

so pre having a hash available...

so the date on the HISE binary is 19th feb 2025... so very old...

hacking back thru HISE versions now...

starting July 28th....builds...but has the bug!! - so this is quite old....
May 2025....builds..but still has the bug. -- getting a bad feeling about this...
April 1st -... builds and does not have the bug.... OK so somewhere between 1.April and 14 May 2025....a total of 14 commits.....
12th April......builds but has the bug.....
7th April....builds..but has the bug...
3rd April....builds and works fine....so theres only 4 commits between here and the next not working one....and theres a fairly obvious candidate...

[Oli Ullmann]

@David-Healey said in Latest version of HISE breaks existing presets....:

With your master volume, are you doing the save in DAW trick so that you can change presets without the volume level changing?

Can you tell me more about this? What kind of trick is it? Is there a thread about it in the forum?

Maybe it will help with my current problem: The modulation data of the new modulation system is not loaded when reloading a DAW project with a plug-in compiled with HISE.

Many thanks,
Oli

[David Healey]

@Oli-Ullmann said in Latest version of HISE breaks existing presets....:

Is there a thread about it in the forum?

https://forum.hise.audio/topic/6410/restoring-properties-with-daw-session

It's not working for me recently. I need to investigate if it's a bug in my code or something's changed in HISE.

[Lindon]

@Lindon

OK found then commit that is breaking my projects.....

its 7th April 2025... which includes the commit

"- rewrote plugin parameter system to use unified base class for all automation types"

So I suspect this is the culprit.

@Christoph-Hart ??? any chance of looking at this? If you cant get it to fail I can send you my project.....

[David Healey]

@Lindon This one https://github.com/christophhart/HISE/commit/a92a701de79edee8bd3ae1268e234a582a6973b2

[Oli Ullmann]

@David-Healey
Thank you very much! I'll take a look at that. :-)

[Lindon]

@David-Healey yep - I think so....

[David Healey]

@Lindon Well I just noticed a very similar problem with my project. Every time I hit compile my pan knob was getting set to -23 and my volume to -97db. These values are not in any presets or the project xml.

I disabled isPluginParameter and the issue is gone. But now they are not plugin parameters...

As soon as I reenable that setting the issue returns.

I tried to recreate it in a minimal project but no luck.