Mask does not scale properly on HiDPI or Retina display

[ustk]

@d-healey It does not seem to be related, or at least it does not solve the problem

[David Healey]

@Natan I don't know, I don't use Master branch :p

[ustk]

@d-healey I think the paint routine does take into account the zoom factor, but the layer part might miss this rescaling somehow. I'll have another look at the source but I'm not confident I can find anything...

[whoopsydoodle]

Is there an update to this in 2024?

It seems to still be an issue. I'm using a mask and even just zooming the view in and out inside hise, the mask keeps it's absolute pixel dimensions, completely moving around within my interface relative to everything else. This bug makes using masks completely pointless.

[aaronventure]

@whoopsydoodle nope, still a bug. You could refer to the scaling ratio as a dimensions modifier when drawing your mask.

Though that's only a bandaid.

[prehm]

does this mean masks are basically unusable?
i really need this feature..

[ustk]

@prehm Unfortunately yes, like blur and maybe some other graphic functions...

[prehm]

@ustk
That’s a bummer.
What’s wrong with blur? Seemed fine the one time I tried it

[ustk]

@prehm Very CPU heavy like shadows, except text shadow because it uses a different algorithm that we wait to be applied to other functions. I think the blur has a strange behaviour when scaling too...

[aaronventure]

@prehm It uses the old JUCE routine for drawing blur, which is about 100x slower than the melatonin version that HISE is still missing, and it's still done on the CPU.

If you want fancy graphics and visual effects, use a WebView and enjoy all the modern frontend tech.

[prehm]

@aaronventure
Cool, thanks for the hint.
I am new to programming so I‘ll have to read into that..

[Christoph Hart]

It uses the old JUCE routine for drawing blur, which is about 100x slower than the melatonin version that HISE is still missing, and it's still done on the CPU.

FYI, I have replaced the shadow functions in the scripting Graphics object with the melatonin routines in the upcoming batch of commits.

But if you want to be 100% accurate, the melatonin shadow is also rendered on the CPU but it's highly optimized withs lots of dirty tricks. The default JUCE implementation (or my failed attempt of replacing it with another algorithm) is just unoptimized code.

[ustk]

@Christoph-Hart So the shadow is optimised, but not yet the blur, right?

[David Healey]

Is the mask/zoom issue fixed yet?

[ustk]

@d-healey Might not be...

HiseSnippet 957.3ocsV8taaaCDmzIrn1aEXEXO.B8SJEAt1N9eCECKINwaFKNUHtqXCCCEzTTVDglTfhpotE8cXOp6MX6njbr7p61fwp9ffu69c28iGu6jCLZFOMUaP3FubUBGg+RxrUJa7nXpPglbABWmLSIRR3Vz4qRnoo7PDFev26LiqeHJ+4O9tyoRphw2nBgdkVv3WIVJrazFb5OJjxwzP9KEKqft6oSXZ0HsTmAT4.RKTBkcKcA+ZpCVMB5GnowH7SImLnOMpyfAbdT+VeyfAQ8Gvnc37tmzs67P57NCGxF1avPD9AWFJrZyLK0xSQ3COWGtZVr9NUQBdkHULWxcBsQyfLWndrVF5NhNsnQwBYXv5ZTJBhRvlJ1AEUrulLUDJtW+lJ2WkavaiGUKf3ZaSuC1hdsqRuVUn2NnDtBkNrfROlLiYDI1MVb74KHSTVtIhB2SUoRAVTs3ZjQZ.gx1bI8V9XCHbuG98a05XO30QOuQC3tJ058FpwKQI89Vu0tsfaGoWlnUff+S.aOwgtBblvvj7JdvLb37GPsw9.zByMoggmYX9+ZqlPJye0t70uAxG6MEf2LXh2S853hOjmloba.T2s2nyrBE2OJSwrBsxewQMdei5tbSgzZiEoNVdklQkmqyTgo98fL.godi5KZFAcmmIk9sdaT4Sgkm8rRp6.k5NktNU.13wsxebvVzLzPuK+rT.9XOZNqWG847EB0UzUbieDUlxKbpZ350KJZS3br4FNy5SKjoIIxUSoo2VM9UhDWEVDcP7CG8700.Os5Zsk+BkedsnwGZ382MEEsSataIiVJcgbGlcyvl+IG8UYKmyMGC28xL98.g9zsa9Ie5l+pylrhllJ.0pIJg8EIb0mZhEU1oA+5mlbA0RcSLk5.bIbiU3n.9B9af8UEyO0IWvSu0pSxwV1PivOzla8QqmtnJtDIfYHBA5AQucy9re4zUUEtSDZgsWD7uiQnXtXQrcszbsIjalIdmKsOX8tyBs2PCEYoU0i93YcXKiNLSRsau5wsftz.bkr07talVkJrqpt.++s8Q+Wo3iIABKKd2br1N3Hbw84fikaweD4xnHXVaCAOjL9m+7rxFUrkZArGyHftFx0YKmAK.XbH6JnoxMRfq4ZdKja4jcUfYvHdtveBOkFa6jwkFau1HZIkYzulULH59NwCy0.bRk+M05joNYu1n7gyp04kvmsdMiscn9HG6ruNdx95X280wd6qi82WGGruNN7e2Q2+p3rLqdYwXCBMM3x7MaX7kJJzAl2sh9Kvnkeao

[David Healey]

@ustk I also noticed adding a mask nerfs the quality of my image :(

[ustk]

@d-healey Strange... I just need masks and proper blur too at the moment. And those layer limitations are bad

Graphics in general is a point that people are still asking for improvement and I understand Hise is not meant to be a photoshop clone. But when you hit limitations... I'd like to re-use OpenGL as well but not confident enough to deal with plateform specific issues... Well, it's one or the other I guess