@Christoph-Hart wel as I say I can send you my project to use for testing - and if not then I can surely test using it...

@David-Healey said in Latest version of HISE breaks existing presets....:

@Lindon Yeah I'm not using macro modulators in mine. I'm just using the macro knob's as a way to make one knob on the ui control multiple modulator parameters without me having to script it.

so pretty much the exact opposite of what I'm doing then....that should be enough of a set of test cases to test if any fix was completed.

@Oli-Ullmann Sadly - see below I don't think this is flexible enough or fits with my current approach to using macros...

@David-Healey
I might be OK with this solution as I don't actual use or include Macro controls in my interface, so as usual (when will I ever learn?) I'm doing it a bit different to most people....here's an explanation:

First there's a set of Macro Modulation Sources: every one of them is an LFO:

I "just" define these as macros like this in the code:

	const NUM_MACROS = 6;
	reg mpos;
	
	Engine.setFrontendMacros(["LFO1", "LFO2", "LFO3", "LFO4", "LFO5", "LFO6"]);

Each LFO gets a UI to manage the LFO itself..only:

..and the user can thus freely assign/unassign them to any UI widget they like, by right clicking on a widget, here the Voice 1 Pan control:

When they are assigned the UI control looks like this (using LAF):

Its pretty simple but it seems to be upsetting HISE post April 6th....meanwhile when I get some space I will build a recent version of HISE and try your fix....

@David-Healey so yes I'm using Macros in the offending project, and like you I DONT want them a plugin params...

@David-Healey yep - I think so....

@Lindon

OK found then commit that is breaking my projects.....

its 7th April 2025... which includes the commit

"- rewrote plugin parameter system to use unified base class for all automation types"

So I suspect this is the culprit.

@Christoph-Hart ??? any chance of looking at this? If you cant get it to fail I can send you my project.....

@Lindon this is what the about HISe box shows me:

so pre having a hash available...

so the date on the HISE binary is 19th feb 2025... so very old...

hacking back thru HISE versions now...

starting July 28th....builds...but has the bug!! - so this is quite old....
May 2025....builds..but still has the bug. -- getting a bad feeling about this...
April 1st -... builds and does not have the bug.... OK so somewhere between 1.April and 14 May 2025....a total of 14 commits.....
12th April......builds but has the bug.....
7th April....builds..but has the bug...
3rd April....builds and works fine....so theres only 4 commits between here and the next not working one....and theres a fairly obvious candidate...

@Lindon close and re-open HISE and its broken again...

@dannytaurus said in Latest version of HISE breaks existing presets....:

@Lindon So we're getting multiple callbacks in the newer version of HISE. If you know the commit of the older version, it will make tracking down the bug a lot easier.

yes it would....

but meanwhile - I made an entirely new preset and saved it......to check if it was affected by this problem...

Not only was it not affected - but all other presets now start to work properly....

Interface: we are setting the Master volume to:-7.799999237060547
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-11.79999923706055
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-8.59999942779541
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-5.59999942779541
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:3.700001001358032
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0

Worrying

@dannytaurus this is a console.print of the preset evaluation fo r 2.5 version management - it is basically saying "Im doing nothing.."

I completely remooved the preset post load function just to make sure it wasnt this that was playing silly, it wasnt...

@Lindon I reloaded the Old HISE version and tried with that this is what we see in the console:

Interface: we are setting the Master volume to:5.100000858306885
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-3.799999237060547
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-8.799999237060547
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-3.499999046325684
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback

So working fine there....

@David-Healey said in Latest version of HISE breaks existing presets....:

With your master volume, are you doing the save in DAW trick so that you can change presets without the volume level changing?

nope...

@dannytaurus 3+ months old - cant remember...

@Lindon

so I took this example:

Interface: we are setting the Master volume to:26.90000152587891
Interface: we are setting the Master volume to:9.500000953674316
Interface: we are setting the Master volume to:26.90000152587891

where (As in all other cases) the middle value is correct... and looked thru the preset for the middle value:

correctly found here:

    <Control type="ScriptSlider" id="MasterVolume" value="9.500000953674316"/>

and the outer value: 26.90000152587891

..and I cant find anything set to this in the preset.....so its not I think copying some other widgets value..

@dannytaurus said in Latest version of HISE breaks existing presets....:

@Lindon Is it just the Master Volume parameter?

nope its a few others too - MasterPan and VolumeVoice1 etc.

Well this one has me stumped. I update to the latest version of HISE today, I've been on an older version whilst a couple of products were released and supported thru the early adopted process...

For at least one of my projects the preset load seems to be broken, in that it's setting a number of widgets to their max value, e.g MasterVolume is being set to 30 (its dB max) for about 60-70% of the presets...and a bunch of other widgets are similarly affected.

Its a very big project (when are they not these days) so I cant post a snippet...

I did this to try and see where it was happening:

inline function onMasterVolumeControl(component, value)
{
	//
	MasterSimpleGain.setAttribute(MasterSimpleGain.Gain, value);
	Console.print("we are setting the Master volume to:" + value);
};

and got this back from the console:

Interface: we are setting the Master volume to:30.0
Interface: we are setting the Master volume to:-3.499999046325684
Interface: we are setting the Master volume to:30.0
Interface: *******START the post load callback
Interface: we are loading a preset for version:30100.0
Interface: *********END the post load callback

Here's the relevant line in the preset:

    <Control type="ScriptSlider" id="MasterVolume" value="-3.499999046325684"/>

I've triple checked and nowhere else is going anywhere near the MasterVolume widget....

So...something is setting the widget value to 30 for some reason, then the value is being set by the preset load correctly, then this thing is re-applying this 30 dB value....

Theres no timers running or broadcasters...

clueless

EDIT: oh and I've tried resetting the widget to its correct value and resaving the preset, then reloading - no change this "30 maniac" is still doing its thing...

EDIT: OK it turns out its WAAAY worse than this - every preset is doing "this" as well, so no MasterVolumes are being set to their correct values:

here's the console for a bunch of preset loads:

Interface: we are setting the Master volume to:-4.700000762939453
Interface: we are setting the Master volume to:20.0
Interface: we are setting the Master volume to:-4.700000762939453
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:30.0
Interface: we are setting the Master volume to:17.0
Interface: we are setting the Master volume to:30.0
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-4.700000762939453
Interface: we are setting the Master volume to:-5.999999046325684
Interface: we are setting the Master volume to:-4.700000762939453
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback
Interface: we are setting the Master volume to:-4.700000762939453
Interface: we are setting the Master volume to:9.200000762939453
Interface: we are setting the Master volume to:-4.700000762939453
Interface: *******START the post load callback
Interface: we are loading a preset for version:30000.0
Interface: *********END the post load callback

It sort of looks like the preset load code is looking at some other widget.....

@DanSound best practice is to use separate filters in each sampler's FX chain - and have one set of controls that manage all the filters....

Happy new year everyone..

@WepaAudio you need to use the full file path in the load command

@JamesC yeah thats one way - but for us this algo approach wasnt quite good enough so we added a simple array of gain(dB) values that the xy pad reads to get the correct gain for its current position - and thus allowed us to have a little "bump" in the middle