@Christoph-Hart Would it be possible to have a value parameter inside the extra_mod nodes -this way we could change the values whilst editing the network. Currently we have to break all the connections and then reconnect them when we need to compile. Obviously the value param would be ignored in the compiled network.

@DanH said in Matrix Modulation System - Last Call for bugs fixes & changes!!:

@Christoph-Hart So I'm not convinced that the accumulated range is helpful / necessary.

So I need to row back on this a little bit

Displaying the Accumulated Range and a range isn't important to me, but I definitely do need the accumulated range values in order to have my little white dot display how the modulation is behaving, accumulated or not.

So is it possible to get something like obj.accumulatedModMin / obj.accumulatedModMax as obj items in the drawRotarySlider function? Might also need a currently selected range too (although this is basically "modMinValue": 1.0,
"modMaxValue": 1.0, I think?).

@David-Healey said in LFO Phase Control - Now shifts phase in realtime:

@DanH said in LFO Phase Control - Now shifts phase in realtime:

while (uptime < 0.0)

Will this ever be true?

Yes apparently.

@Christoph-Hart said in LFO Phase Control - Now shifts phase in realtime:

But if you don‘t smooth the phase you‘ll get really nasty zipper noises, no?

Smoothing tricky apparently But doesn't sound bad without.... so far

@griffinboy Yeah I've been waiting on yours basically and getting impatient

@Christoph-Hart said in LFO Phase Control - Now shifts phase in realtime:

But if you don‘t smooth the phase you‘ll get really nasty zipper noises, no?

It's not terrible. But I'll ask about smoothing

I've successfully used Claude to change the behaviour of the stock HISE LFO's phase control, which would shift the phase only when the LFO was next triggered. Now it changes it in realtime. @Christoph-Hart if this is of interest I'll submit a pull request, if I can figure out how to

Here are the lines - probably better to check first

Line 356 in LFOModulator.cpp, change:

case Parameters::PhaseOffset:
    phaseOffset = (double)newValue;
    triggerWaveformUpdate();
    break;

to

case Parameters::PhaseOffset:
{
    // Calculate the change in phase offset
    double phaseChange = (double)newValue - phaseOffset;
    
    // Update the stored phase offset
    phaseOffset = (double)newValue;
    
    // Apply the phase change to the current position
    uptime += phaseChange * (double)SAMPLE_LOOKUP_TABLE_SIZE;
    
    // Wrap uptime to stay within bounds
    while (uptime >= (double)SAMPLE_LOOKUP_TABLE_SIZE)
        uptime -= (double)SAMPLE_LOOKUP_TABLE_SIZE;
    while (uptime < 0.0)
        uptime += (double)SAMPLE_LOOKUP_TABLE_SIZE;
    
    lastCycleIndex = (int)floor(uptime * (1.0 / (double)SAMPLE_LOOKUP_TABLE_SIZE));
    
    triggerWaveformUpdate();
    break;
}

@David-Healey Oh well. Success here anyways, thanks for the help

@David-Healey trying now. But surely everyone else will run into this issue?

@David-Healey nope! There seemed to be a newer commit so just downloaded that to do without git and am met with this screen when saving the Projucer file:

All modules look like this - no path

@David-Healey No, I've cloned a fresh copy. Can't get it over the line....

@ustk lols

@dannytaurus Yep same spec. What do I need to do re the Juce submodule?

@ustk I managed a it a bit but haven't gone back to sort it out. This uses the general button css before it in the script

/** ============================================================ DELETE ============================================================ */

.delete-button
{
  width: 20px;
  padding: 0;
}

.delete-button::before
{
  left: 0;
  top: 0;
  width: 100%;
  height: 100%;
}

.delete-button::after
{
  content: 'X';
  position: relative;
  color: #C4C3C3;
  font-size: 12px;
  pointer-events: none;
}

Ok I'm clearly not understanding something here - for a control with values that aren't 0-1 how are you meant to set the values in the Matrix Module? I keep ending up with nan as a value or something completely unusable....

Anyone succeeded? Getting No member named 'NodeBase' in namespace 'scriptnode' error which I recognise but can't remember if there was a fix....

@Christoph-Hart any idea what's going on here? I've selected the top params to have external modulation enabled but it's suggesting something also happening with the nested params in the child container.... ui glitch or bug?

@clevername27 ah cool, I'll give it another go

@clevername27 is that a new addition? I bought it when it was first released but found I couldn't do some of the things I was doing in Whitebox and haven't tried it again since

@ustk what if you just open the project in Hise but don't load any xml? Can you compile that way?

@ustk for the dll try removing the networks from compilation so you're only compiling the nodes. Once that is done restart hise and add the networks back into the compile process and compile again