OpenGL ComboBox, And "NO" By Default

[Natan]

@d-healey said in OpenGL ComboBox, And "NO" By Default:

@ustk He want's the option there but he wants it set to false. I think your suggestion will set it to true

Yeah, Sir David, You're Right.

And Added "GraphicRendering": true, into the CustomSettings Floating Tile.
And The Option Is There Also On Hise, Not Just Compiled Plugin, And It's Set To NO,
Just Tested, And Works Like A Charm

[ustk]

The combobox goes away as soon as you set DebugMode to false

Also, I don't see where adding GraphicRendering changes anything...

[Dan Korneff]

@ustk said in OpenGL ComboBox, And "NO" By Default:

The combobox goes away as soon as you set DebugMode to false

Was just doing some testing. At least one other item needs to be set to "true" for the OpenGL combo to appear.
After poking around a little, adding this to StandalongPopupComponents.cpp and trashing HISE preferences makes it work properly on my rig:

openGLSelector->setLookAndFeel(&blaf);

[Fortune]

OpenGL Combobox is not apprearing in the FloatingTile. I just can't use it because it is empty in the compiled plugin.

Does anyone have this issue with the latest develop branch?

[d.healey]

@Fortune Try using HISE_USE_OPENGL_FOR_PLUGIN=1 in your project preferences.

[Fortune]

@d-healey I will try, thank you man!

[Fortune]

@d-healey Yes it works now with that flag, thank you again man!

As I see, the default OpenGL "NO" option is not available. The plugin is loading with YES on the first init.

[Dan Korneff]

@Fortune said in OpenGL ComboBox, And "NO" By Default:

The plugin is loading with YES on the first init.

Was there a solution to this? It seems like any time I enable the opengl combo box, it always defaults to YES no matter what the plugin is set to for export.

[Fortune]

@dustbro said in OpenGL ComboBox, And "NO" By Default:

Was there a solution to this? It seems like any time I enable the opengl combo box, it always defaults to YES no matter what the plugin is set to for export.

Unfortunately there is no easy solution for this.

Also since we can't edit the GeneralSettings.xml file with scripting, in the end, I made a custom settings file (with dumpAsJSON) that stores the NO value by default and call that value on init. So only first initialization will be YES. Then other instances will be NO (unless the user makes it YES manually of course).

[Dan Korneff]

@Christoph-Hart where can we find this setting in the source? Would like to have the OpenGL combo box visible, and default to OFF on plugin init (or at least set to the project setting when you export).

[Dan Korneff]

EDIT: this isn't working :(

nevermind... changing StandalonePopupComponents.cpp 128
from

#if !HISE_USE_OPENGL_FOR_PLUGIN

to

#if HISE_USE_OPENGL_FOR_PLUGIN

is working here.

[Christoph Hart]

@dustbro Yeah, I need to add another preprocessor (something like HISE_ENABLE_OPENGL_BY_DEFAULT). This macro will deactivate the entire OpenGL thing.

[Dan Korneff]

@Christoph-Hart

[DanH]

@dustbro could you not include the general settings xml in your installer and set the opengl to 0?

[Dan Korneff]

@DanH That's a short term solution that would work... but then I have to update a bunch of installers, write post-install scripts for the new files, answer endless tech support emails about why their default GUI zoom setting reset to 100% because the script accidentally overwrote an existing xml with their most favorite zoom setting in the world, then defend my product on SlutSpace cause if I can't keep track of a single xml file how can the customer trust the DSP under the hood. This, of course, would coincide with an unplanned ilOk Cloud outage that prompts 35.7% of my customer base to set their studios on fire.
Not good for business

[DanH]

@dustbro lol! It shouldn't overwrite the existing settings file though, should it? Anway, let's hope this can be added :)

[Christoph Hart]

@DanH Crisis averted:

https://github.com/christophhart/HISE/commit/424b619b955a0a72d9d869f0168fddec3a208018

[Dan Korneff]

@Christoph-Hart yay!!

[Dan Korneff]

@Christoph-Hart Do we have to make any additional changes to get this to work? I have HISE_USE_OPENGL_FOR_PLUGIN=1 set in Extra Definitions cause the combo box doesn't show up inthe export without it.
The GeneralSettings.xml is still being created with OPEN_GL=1 even if the plug-in is set to "no" when exporting.

[Christoph Hart]

@dustbro You have to add HISE_DEFAULT_OPENGL_VALUE=1