Sampler issues latest build

[Dan Korneff]

I'm having some issues with samples and the sampler in the latest version compiled 12/30.
#1 - HISE will crash if you remove a sampler that has samples or a Samplemap loaded.
#2 - Samples do not playback at proper pitch when converted to Monolth (no compression). I'm loading multi-mic samples recorded at 96K which sound fine until converted to monolith. After, it plays back at lower pitch.
#3 - HISE will crash when I try to load HLAC monolith files that were created with 96K samples.

[d.healey]

@dustbro I bet all of these issues are related to the 96K rate.

[Christoph Hart]

Yeah I never ever used 96kHz, theoretically it should be fine, but I am sure there is something fishy.

Does the sampler crash go away with 48kHz samples?

[Christoph Hart]

1. The crash when removing samplers is fixed - was something silly that slipped in.
2. Forget about Monolith without compression, it's just a deprecated thing, there's no reason to not use the compression (the performance overhead is neglible). I'll remove the option soon and the option with compression works with 96kHz.
3. Might be the same reason as 1. so please check if it remains.

[Dan Korneff]

@Christoph-Hart Awesome! Gonna check now. I just tested my current version with 48K and it still exists.

[Christoph Hart]

FYI, that's the code that handles samplerates:

if (isOldMonolith)
{
    return 44100.0; // doesn't matter anyway (the sample rate is stored externally)
}
else
{
    const static double sampleRates[4] = { 44100.0, 48000.0, 88200.0, 96000.0 };
    const uint8 srIndex = (sampleDataByte & 0xC0) >> 6;
    return sampleRates[srIndex];
}

Now it also makes sense why @staiff is struggling with his 27,4kHz sounds :)

[Dan Korneff]

@Christoph-Hart On this end:
Monolith (fast Decompression) works!
Monolith (low file size) crashes sampler when it preloads the samplemap
Monolith (no compression) plays wrong pitch.
I guess I'll stick with the first option ;)

[Christoph Hart]

What first option? I don't know what you talking about. Move along, nothing to see here :)

https://github.com/christophhart/HISE/commit/32e778a69717358b56e8167e91af0f878f6ed1ed

[Dan Korneff]

@Christoph-Hart

[staiff]

@Christoph-Hart said in Sampler issues latest build:

Now it also makes sense why @staiff is struggling with his 27,4kHz sounds :)

Yes. but also 27.4 Khz samples is not common in 2018/19 (and even since the 90s)
just the frequency used by Linndrum, Emulator II, Sx samplers, etc. ... from the 80's.

Today it's not useful to go less than 44100. Better using 44/48/96 Khz and a bitcrusher Fx (and other scripts). if you script well the behaviour of 80's sampler you can obtain the same result (or pretty close).

but the part of code that handles samplerates makes sence now about my problem. ;)

for my part i don't go up to 48 Khz, but in 24 bits. i feel it better and more digestible than 96 khz (16 or 24 bit).
96Khz (24 bit) is only used by me for music creation mastering.

[Dan Korneff]

@Christoph-Hart Just compiled the latest version. HISE is crashing directly after you create a monolith. Tried using HLAC - No Normalization and Full Dynamics. On restart, Project will refuse to load unless you change the Samplemap XML savemode back to 1.

[Dan Korneff]

I just noticed in the console, I'm getting this error during export of Monolith:

Master Chain:! The sample Snare multi mic.ch2 wasn't found

and

Master Chain:! Error at loading sample Snare multi mic.ch2: File is corrupt

And debugging via Visual studio:

Unhandled exception at 0x00007FF9CE321B28 (HISE x64 16 Out.dll) in AudioPluginHost.exe: 0xC000001D: Illegal Instruction.

[Dan Korneff]

[Christoph Hart]

What CPU are you using?

[Dan Korneff]

@Christoph-Hart

[Dan Korneff]

@Christoph-Hart
I just realized that I wasn't using the debugging version of HISE.
Here's some info that might be more relevant:

[Dan Korneff]

[Dan Korneff]

[Dan Korneff]

and here's the final error that causes crash when preloading monolith

[Dan Korneff]

@Christoph-Hart Is there anything else I can do to troubleshoot this issue?