Module tree container UI/UX

[dannytaurus]

@WannaBeGUD I agree with that in principle, but I'm not sure which is more confusing for the user:

In non-edit mode:

1. Hide the arrow if module has no children, or
2. Keep the arrow but it does nothing

Hiding the arrow will make the UI look inconsistent and might cause "why doesn't Container have an arrow?! Bug report!!!".

[HISEnberg]

@David-Healey I personally feel the module tree could use a bit of a UI/UX makeover…

[ulrik]

@David-Healey Oh yes!

[WannaBeGUD]

@dannytaurus Yes the ongoing issue with things appearing and disappearing. I believe removing it with no children is a more accurate quick fix, as having a button that does nothing and looks like something else is much worse.

Realistically there is probably a even better solution but that will need more time and deep diving.

[dannytaurus]

@David-Healey

[WannaBeGUD]

@dannytaurus What if that container has many items just for it, this would mean if I wanted to see the "Audio Loop Player" in this case, I have no way to minimise just container 1, and keep that one open. Or we could just make the "Container" just that and do exactly what you have in the loop you made. Just containers do that function, others still work the other way around. - Seems odd to have a processor called 'Container' but it's more than that.

I agree with the 'disappearing' arrow, so you could add a 'placeholder' such as (No processors) or even a cta for "+ Add processor", sorry if I'm getting processors and modules the whole way round.

[dannytaurus]

@WannaBeGUD I'd say that's all stuff for a good overhaul of the overall Module Tree UI/UX, as @HISEnberg says.

For now, folding child modules is a fairly easy win for UX.

[dannytaurus]

@David-Healey I'll post a PR for your perusal. This one's a bit out of my comfort zone.

[dannytaurus]

@David-Healey See what you think of this PR: https://github.com/christophhart/HISE/pull/839

[DanH]

@dannytaurus One thing that always bugs me is that the global cables list, which sits at the top, will always reopen after compile. Don't suppose you could fix that too ?!

Will feedback on this pull when I can

[dannytaurus]

@DanH This section at the top?

Weird, it stays closed for me when I recompile. Whether I recompile from the script editor, the Interface Designer, or from Tools > Recompile all scripts.

[DanH]

@dannytaurus yeah that's odd! I'm on OSX, you?

[dannytaurus]

@DanH Yep, Sequoia 15.6 with the latest develop build.

[David Healey]

@dannytaurus That was quick. Looks like a clean implementation to me. Thanks!

[DanH]

@David-Healey @dannytaurus works well, thanks! (still have Global Cable issue but def an improvement!)

[dannytaurus]

@DanH Which commit are you on?

[DanH]

@dannytaurus most recent

[dannytaurus]

@DanH If you can make a minimal snippet that shows the issue on your machine, I'll try it on mine to see if it's the same.