@David-Healey said in Code feedback on this custom envelope panel:

For paint routines and mouse callbacks I'm not sure it makes a difference since the paint routine or mouse callback is still a regular function.

Yes but the way I understand it (might be wrong though) is that it's faster to execute even if the outside part isn't inlined. The inline part containing locals, the code execution inside it seems faster especially for long paint routines or mouseCB. Then what happens after this isn't affected but at least the script part might be improved.

@dannytaurus inline functions tend to perform better

@dannytaurus Just my experience, in my case if the device is still on then closing and reopening Hise keeps the connection working. But it's lost when I switching the device off and starting hise again. (haven't tested the PR yet)

@David-Healey all the same except for type-safety which I didn't really see the gain for me now as I am very careful on the caller side... But I understand where it can help

@dannytaurus Only a pretty basic and very dull one for now without audio-driven effect, but I've just tested for the next one and it seems very promising! It has audio-driven filters and a lot of audio visualisers too

https://youtu.be/vGjSlHKLIFY
https://youtube.com/shorts/7YJ67qTD2D4

@David-Healey said in Code feedback on this custom envelope panel:

I didn't know you could declare a function within a paint routine. Somehow that feels wrong to me :) I'd declare it outside, but if it works it works.

I tend to do it this way nowadays, inlining as many functions as I can for paintRoutines, mouseCB... And sub functions can be used elsewhere when necessary

MainPanel.setPaintRoutine(drawMainPanel);

inline function drawMainPanel(g)
{
	subFunction1();
	subFunction2();
}


inline function subFunction1()
{
	
}

inline function subFunction2()
{
	
}

@dannytaurus I'm using Filmora, it's light yet powerful, not expensive, has audio driven effects and much more...

@dannytaurus Nice!
On my side I have several products to release this year. But my marketing is very poor so for now I am barely selling anything... So after the first release (very soon) my goal is to improve my understanding of the market and find ways to sell effectively so I can quit that feeling I am doing this for nothing...
Ideally, working with someone on this part would help a lot.

Wishing the best to you all!

@dannytaurus Sorry I don't... but you definitely gave me the idea of buying 2nd hand hardware that have LE license for many DAWs instead of buying new licenses and I thank you for this!

@Christoph-Hart as you can see, when enabling INV the intensity as no effect anymore until (not always) selecting another mode, or disabling INV (or even when setting intensity to 0 in Scale mode)

@iamlamprey same as the other fellows, I just do this in a browser from my dev account...

@Oli-Ullmann said in Issue macro taking the priority:

@ustk
The advantage of my snippet is that you can assign the Macro Controller like any other modulator. So via drag and drop, right-click, or via the Modulation Matrix UI elements. It all feels like a closed system.
But maybe I'm misunderstanding something and your method works like that, too.

Yes it's working all the same since they are modulators in the global container

@Oli-Ullmann Nice, I didn't see we could connect the macro knob to the MacroValue parameterId...

However when moving the real macro knob (from the Macro Control panel) and if the CUTOFF slider is a pluginParameter then it move accordingly so something still feels wrong here...

I feel more comfortable with my solution of making a modulator that mimics the macro behaviour. Perhaps in some cases it might be limited but for now it seems to fit my project just fine, so I don't have any reason to use the stock macro system anymore unless somebody shows me if I am missing the obvious

@DanH

@DanH Then on the interface side, the slider shouldn't be connected to the scriptFX parameter anymore but directly to the Matrix Modulator Value parameter:

From there, everything is linked internally
UI slider -> MM Value -> Network Param -> extra_mod

@DanH Exact

@DanH Once you have set a parameter as External Modulation you just have to set the corresponding index to the extra_mod.

You don't need to wire the parameter anymore since it is connected internally with the extra_mod. Then wire the extra_mod like any other modulator node

The indexes are in the same order as the parameters are set
Here the fourth param is idx 3:

@DanH I do not really understand that selector in scriptnode, I set everything to Combined and it seems to work fine for me

https://docs.hise.dev/scriptnode/list/core/extra_mod.html

@DanH If you trace ModMatrix.getMatrixModulationProperties(); you'll see how the object is built

@dannytaurus supreme sorcerer grade