@rglides I looked at the code just now and you are right. The keyPressCallback is only called after a key is pressed down and NEVER when the key is released and goes back up.

As a workaround, I suggest creating a timer to turn the button back off after each keypress a fraction of a second later.

However this problem gets much worse if you consider that most users have "key repeat" enabled, and holding down a key for more than a second will send a barrage of keypresses to the key listener.

@Christoph-Hart Is there a way to handle keyRelease events similar to keyPresse events?

@johnmike I looked at your code and fixed a few bugs, changed the way the buttons and states are initiated, and used const where appropriate.

HiseSnippet 1908.3ocsZt0biSrDGeT1nCaLWJnJdg2F7CTNjKXo3a4D1EiiSBt33cMqSVfZqsXUjFYOmHqwkz3ciOGRU7QiOR7M.5VWrk2XAqhT7CSxb4+z+TO8zZjsF3ILY99BOhRoymOkQT9.0gyckiOdrA2kzqKQ4iT6a3KYdzvl5LepguOyhnn7fyvFT1ZSRvm+3a5X3X3ZxV1Dg7bA2j8e3S3xksNn82ycbN0vhcNeRhQWqcOSg6wBGwLfmGnVkL0v7JiQrmXfCaCUx2Y3Oln7kpVZ0zraYZznkVMcSS8VM0OroIyv1l0PqdyZsrqYaXVUmn7uNwhKEdCkFRlOQYyNBq4CGKdianAdN2meoCCqnQFBVNr4SENV3kH1J43wbGqAwNJeBLKCV51dPna6SU6ys3KZeo66iC5ftTQRGnxFqh2CVAOsj3UMAdqAIkDHsYHReh5PSO9T4xdPdde0dtvpI3dXqfR3XIaz+gpGKfQ3J2ehwUrS8fJKTToQ0p6ROnZ0sOpTou5qnG6w.voFzKgEpQdhYtVzoFtLGpTPMMlJm4wnWwlO0C.f4WBVd8kzNmQeDM1HiXxiESlJbgJUJ24rxQScWlM2kQkiCl.JvIej6DXP9TagGUuN8xYRILeQSJLnuMwXdD8EknvmxZk2kVVGKN.KpgE0whFXQSrnET.e.i1IbJoZ60JT8gX+UC6+u+SB0GtmV0P4mhx6mQ4ZZ6ooGp+GP8+HVbBV7Lr3br3mwhKvhd2F9C1SOx9CvQbFVLDK5lNIIzqqsmdsP8cJSeG+rPOrxT5kgKgWL0BiNdkOtD65OaBy56YyGDFK7JLDg6Z5LyBBfbbvEP+RcNa+0N5Jqt7FEi7LlMyiAYbnrq49Rt6n3fBpADI5C6rBhfl.FBZgZ34YLOJdIdfPfBfaTs8Aqw7dMqhd8HSzykK4FN7+GKRALq3d0Ulkvsu+CSkIbQhaSBBeubQfF3t3tNXnt8LWSIGrfvMzUhaQ7DNULi2erK80FNyXaW5+WZKGALgTt00fYiMI20hc8SsWJ.r7Vb6Jvnd7ipR+hu.G+WG.zVakD8W.s+RXhBl9iJcC.bIDyJbnwpGQ4zuFVWg+tyNaSAiCNlSYRyw21ue4bZutAAOQs7B9KSe2dvPJS2ALzNZaCXspvnXAzIbbj2qxa4bVqlJkkrqkk2Mx.zx6rZ3CLrUzE6D.RSLQ.qOG8GU19HJszMAgCCYxE4ynKVQASf4od6jfQQywQwKtDhWnqHt7+htyn8OGOlAy0hDdif6f.QXQ0SlaKLLFU4wFgc1CW2Au7piaQ3.Xl8sX9AI3AyhginXtMsRr3GumVLIQzbtXzHmv7uAQ7TgcPESgGbw.qfVKW1WnaE2Y7biq+e9564nEJwqjnMXKhmSNtECDoNre.XDzSfbEgayimfffR+RISOE1CtZDtjtdb19n0Ixbrg6HlEFFf9EO9nQvogB7EQqnKTcSv+cCk43yR3Nw7YBG19S83XXODPPcER3Z1TLxERsX8uo3lfasNQCtO3kyFMB80tB28div6J7+CRVFZwa.pSj53IBI6otUBxQ.Asz2tKa601Wz1IGl2Z6FOnl2emvJtylbIyKYFJbfvgQV8DNpoeBmjG.yLLeQhAJbwTwOcJyMsikQhRx.mF5yhnBFpL3rPeTzYgBSHP3vQd1RMrhFI.4jmikjA454S9A4Sds7Iud9j2HexalO4sxm7CuaxKEG1TMm50xod8bp+fbpuVN0WOm5ajS8Myo9V4TeNi+zyY7mdNi+zyY7mdNi+zyY7m95h+tnWWCoA93zQ2KAt+xTlmji25RoK60bSV3CWukZWl+URwzfwFchVhx6EZ2OL9QuwiAFX1MU6bF45jeyHySV4MbK4X3tiJ+zFDxXFezXIVaWEBANig3MwmczGe.d77CAmnL3FcKr8CeGtUWBBdR6DD731QDD0P6KZGSQ7P51dpA7vVxDVL3hBOp8R2JEuybVXROISV2OLomQlNHASsmd+vzAYjoZIX52d88CS0xHS0Svzu+q2OLUOiL0H0X7yKLlZjQlZlZLdwwTyLxTqTiwKNlZkQlNL0X7hioCeGYJw47RKHu3fpZVgJ0L4seUgA0oYEpTSkWfP0OqPkZt7BDpeHqPkZx7BDpeLqPkZ17BDpSxJTolN+2rKLndVVgJ074EHTmmUnRMgdAB0OmUnRMidAB0EYDJ8TynWfP0KqPkZF8e2ovfZPVgJ0L5EHTmkUnRMidAB0vrBUpYzKPn5lUnRMidABUGB41+zyerZeg0LGC4p+R336KPTGbwpuJA3OwrqOWNO4yiWX+73uqH9IpC3RywqmwMVCiDx8BiQuTAen5I11LS4R.2T8ze594MHf7LwL7WxqugziCgMpOY1jghYdlLv5ttLG7KuWYC7qYOrdUrN5AFxbsBp7mvmnN0v5JQcpE2IYhgom3WLC+VZvWagGFzBvjavq3wVp8w5za8cSQHS3V7ewzb0o5VB0uqBO3tJr1cUX86pvF2UgMuqBa8OKDeIW91YRwjvsMDR+AmD7coonbhqADAFDsR9KPqzCnZ

@clevername27 said in How can you tell if you have a VST2 or VST3 license?:

@hujackus I wouldn't worry about it. Just do your thing. I don't think Steinberg will mind.

I'm just trying to comply with the open source terms set by HISE. It is impossible for me to release my VST2 version because of not having a VST2 license from Steinberg, and even if I did have a license I would not be able to release it because HISE requires the project to be fully open source under GPLv3 (unless I purchase the Indie commercial license).

In fact, nobody can release a VST2 under the HISE Open Source License. It was never possible. Therefore, I must consider VST3 only if I am to use HISE. It has taken a lot of review to come to this conclusion. Right now I'm just trying to find out if it is true that I don't need a VST3 license from Steinberg if I only release using GPLv3.

@d-healey said in How can you tell if you have a VST2 or VST3 license?:

@hujackus said in How can you tell if you have a VST2 or VST3 license?:

Would it be easier to search the HISE-develop\tools\SDK\VST3 SDK directory and delete all the files that don't have the dual license and see what compiles?

You could try it.

So I tried it. I deleted the HISE-develop\tools\SDK\VST3 SDK directory and I recompiled HISE Standalone without any problems. I opened up my project in HISE and exported it to VST3 and immediately got an error "VST SDK is missing".

I put back the VST3 SDK directory, but removed the vst2.x subdirectory and I was able to successfully export it as a VST3. I disabled VST3 support and it exported as a VST2 successfully.

It seems HISE does require some of the files in HISE-develop\tools\SDK\VST3 SDK, but does not use all of them (all the vst2.x files for example).

@d-healey I did some more digging. There is some VST3 source code under GPLv3 that is included in the JUCE portion of the HISE source code. Here is a link to that code.

https://github.com/christophhart/HISE/tree/develop/JUCE/modules/juce_audio_processors/format_types/VST3_SDK

The main LICENSE.txt file has a dual license with two parts.

//-----------------------------------------------------------------------------
// LICENSE
// (c) 2021, Steinberg Media Technologies GmbH, All Rights Reserved
//-----------------------------------------------------------------------------
This license applies only to files referencing this license,
for other files of the Software Development Kit the respective embedded license text
is applicable. The license can be found at: www.steinberg.net/sdklicenses_vst3

This Software Development Kit is licensed under the terms of the Steinberg VST3 License,
or alternatively under the terms of the General Public License (GPL) Version 3.
You may use the Software Development Kit according to either of these licenses as it is
most appropriate for your project on a case-by-case basis (commercial or not).

a) Proprietary Steinberg VST3 License
The Software Development Kit may not be distributed in parts or its entirety
without prior written agreement by Steinberg Media Technologies GmbH.
The SDK must not be used to re-engineer or manipulate any technology used
in any Steinberg or Third-party application or software module,
unless permitted by law.
Neither the name of the Steinberg Media Technologies GmbH nor the names of its
contributors may be used to endorse or promote products derived from this
software without specific prior written permission.
Before publishing a software under the proprietary license, you need to obtain a copy
of the License Agreement signed by Steinberg Media Technologies GmbH.
The Steinberg VST SDK License Agreement can be found at:
www.steinberg.net/en/company/developers.html

THE SDK IS PROVIDED BY STEINBERG MEDIA TECHNOLOGIES GMBH "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
IN NO EVENT SHALL STEINBERG MEDIA TECHNOLOGIES GMBH BE LIABLE FOR ANY DIRECT,
INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
OF THE POSSIBILITY OF SUCH DAMAGE.

b) General Public License (GPL) Version 3
Details of these licenses can be found at: www.gnu.org/licenses/gpl-3.0.html
//----------------------------------------------------------------------------------

But if you look at the LICENSE.txt in ../VST3_SDK/public.sdk, there is a different boiler plate

//-----------------------------------------------------------------------------
// LICENSE
// (c) 2021, Steinberg Media Technologies GmbH, All Rights Reserved
//-----------------------------------------------------------------------------
// Redistribution and use in source and binary forms, with or without modification,
// are permitted provided that the following conditions are met:
// 
//   * Redistributions of source code must retain the above copyright notice, 
//     this list of conditions and the following disclaimer.
//   * Redistributions in binary form must reproduce the above copyright notice,
//     this list of conditions and the following disclaimer in the documentation 
//     and/or other materials provided with the distribution.
//   * Neither the name of the Steinberg Media Technologies nor the names of its
//     contributors may be used to endorse or promote products derived from this 
//     software without specific prior written permission.
// 
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
// ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 
// WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. 
// IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, 
// INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, 
// BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF 
// LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE 
// OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE  OF THIS SOFTWARE, EVEN IF ADVISED
// OF THE POSSIBILITY OF SUCH DAMAGE.
//-----------------------------------------------------------------------------

I'm still looking through the code to find other places where HISE uses non GPLv3 source code. Would it be easier to search the HISE-develop\tools\SDK\VST3 SDK directory and delete all the files that don't have the dual license and see what compiles?

@d-healey said in How can you tell if you have a VST2 or VST3 license?:

@hujackus ah that needs updating, the vst3 SDK is included with the source code

So as it stands, I can't compile HISE without a VST3 license because the VST SDK it uses hasn't been updated to the version with the duel license(which includes GPLv3).

@d-healey said in How can you tell if you have a VST2 or VST3 license?:

@hujackus said in How can you tell if you have a VST2 or VST3 license?:

So I looked into it and HISE is not built with source code that falls under GPLv3

What do you mean?

The boilerplate at the top of all the VST SDK code is from 2016 and has no mention of GPLv3.

You can see this here: https://github.com/christophhart/HISE/tree/develop/tools/SDK
[3rd party SDKs
In order to build certain configurations, you'll need some 3rd party SDKs that can't be distributed along with the rest of the source code for licencing reasons. Instead you'll need to register at each company and do everything they tell you to do in order to get their SDKs.]

So I looked into it and HISE is not built with source code that falls under GPLv3 and therefore a VST3 license is needed from Steinberg. I was reading into which versions of VST3 have the GPLv3 license and I found that not everything HISE needs to compile falls under GPLv3.

Reference this: https://forums.steinberg.net/t/vst-3-sdk-license/201637

@d-healey said in How can you tell if you have a VST2 or VST3 license?:

I have no idea, you don't need a license if you're releasing under the GPL though.

I'm going to have to check again, for some reason I thought the VST SDK I built HISE with was a binary, and not source code. I remember reading that VST3 does have a GPLv3 license, but I didn't realize that was what I was using to export my VST2 and VST3 plugins.

Moving on to the other part of my initial question. How do I show proof of having a VST license? If I fill out the VST3 license with Steinberg, what should I expect to get back from them: An email? Something buried on their website? Nothing?

@d-healey said in How can you tell if you have a VST2 or VST3 license?:

@hujackus Correct, but I'm not sure you can distribute a VST2 under the GPL because it would require a proprietary SDK.

So nobody can meet the requirements of the open-source license (for HISE) if they want to export to VST2? Not even if you hold a proprietary VST2 license from Steinberg?

@d-healey said in How can you tell if you have a VST2 or VST3 license?:

@hujackus Vst2 is proprietary so not suitable for open source.

Interesting, but if I don't have the license I can't distribute, right? I still need to be open source since I don't have a commercial license from HISE.

I attempted to use JUCE several years ago to make a VST (before they dropped support for VST2). I can't remember if I got a license from Steinberg by email or filling out an online form, but it would be convenient to find out.

For those of you that have VST2 and VST3 licenses, what do you have as proof that you in fact have the licenses? Did anyone fill out a paper form and send it in the mail?

Also, I am going to set up a website to showcase the VSTs I made. Does anyone have an example of an open source VST they distribute online? Not sure which source files are required to meet the GPLv3 requirements.