Major Issue with Split Node in Scriptnode

Casey Kolb

@Christoph-Hart I haven't tried without compiled networks yet. I can test that and the split node in another container today. I'll keep you posted!

Christoph Hart

@Casey-Kolb And can you pinpoint it to a certain host / OS combination apart from Bitwig and Cubase (I don't have those to test).

Dan Korneff

@Christoph-Hart I can set you up with a Virtual Machine that has cubase/bitwig for you to test with.

Casey Kolb

@Christoph-Hart Bitwig has a free trial you can use, same with Cubase I think. We also had reports that it happens in Logic and Ableton Live on certain machines, but Bitwig and Cubase were more consistently reproducible. I'll let you know if there are more – I'm assuming it's broken in FL Studio too because...well...everything is always broken in FL Studio

Christoph Hart

same with Cubase I think.

Yeah, no.

I can set you up with a Virtual Machine that has cubase/bitwig for you to test with.

Thanks, but I think setting up the remote debugger is more pain than installing the bitwig demo :)

Casey Kolb

@Christoph-Hart I have good news: Wrapping the split in a frame container seems to have fixed the issue. What does the frame container do?

Christoph Hart

@Casey-Kolb It processes the child nodes one sample at a time. This is not a "fix" as it will vastly increase the CPU usage, but it shows me that there is something wrong with the block processing code in the split container.

I'm compiling the example as FX plugin to load into Bitwig, so let's see if I can find anything.

Casey Kolb

@Christoph-Hart Noted. For a basic bitcrusher effect I'm assuming this won't be an issue temporarily?

Casey Kolb

@Christoph-Hart said in Major Issue with Split Node in Scriptnode:

same with Cubase I think.

Yeah, no.

https://www.steinberg.net/cubase/trial/

Christoph Hart

@Casey-Kolb

Start your free 30-day trial version

We're way past that :)

Anyways, I've fired up bitwig and it seems to play back fine, the only thing I'm noticing is that if I switch the audio driver to generic, it will use 441 samples as buffer size (here we go again), and this leads to some crackle noises on the right channel. I'll investigate more, but which buffer size are you using on Bitwig?

Christoph Hart

Alright, forget all DAWs:

HISE -> Tools -> Simulate varying buffer size

Add the compiled bitcrusher code => complete mayhem.

Nice job HISE, you magnificient debugging beast!

Christoph Hart

Alright, it's fixed. It was indeed an issue where the split container expected a full buffer length so when a buffer with something less than this is processed, it started pointing to uninitialised memory which resulted either in silence or (worse) junk signal.