HISE Logo Forum
    • Categories
    • Register
    • Login

    Major Issue with Split Node in Scriptnode

    Scheduled Pinned Locked Moved Bug Reports
    25 Posts 6 Posters 1.3k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Christoph HartC
      Christoph Hart @Casey Kolb
      last edited by

      same with Cubase I think.

      Yeah, no.

      I can set you up with a Virtual Machine that has cubase/bitwig for you to test with.

      Thanks, but I think setting up the remote debugger is more pain than installing the bitwig demo :)

      Casey KolbC 2 Replies Last reply Reply Quote 0
      • Casey KolbC
        Casey Kolb @Christoph Hart
        last edited by

        @Christoph-Hart I have good news: Wrapping the split in a frame container seems to have fixed the issue. What does the frame container do?

        Casey Kolb
        Founder & CEO of Lunacy Audio
        Composer | Producer | Software Developer

        Christoph HartC 1 Reply Last reply Reply Quote 0
        • Christoph HartC
          Christoph Hart @Casey Kolb
          last edited by

          @Casey-Kolb It processes the child nodes one sample at a time. This is not a "fix" as it will vastly increase the CPU usage, but it shows me that there is something wrong with the block processing code in the split container.

          I'm compiling the example as FX plugin to load into Bitwig, so let's see if I can find anything.

          Casey KolbC 1 Reply Last reply Reply Quote 1
          • Casey KolbC
            Casey Kolb @Christoph Hart
            last edited by

            @Christoph-Hart Noted. For a basic bitcrusher effect I'm assuming this won't be an issue temporarily?

            Casey Kolb
            Founder & CEO of Lunacy Audio
            Composer | Producer | Software Developer

            1 Reply Last reply Reply Quote 0
            • Casey KolbC
              Casey Kolb @Christoph Hart
              last edited by

              @Christoph-Hart said in Major Issue with Split Node in Scriptnode:

              same with Cubase I think.

              Yeah, no.

              Link Preview Image
              Try Cubase 14 free for 60 days

              Sign up for free to try all music production features of Cubase.

              favicon

              (www.steinberg.net)

              Casey Kolb
              Founder & CEO of Lunacy Audio
              Composer | Producer | Software Developer

              Christoph HartC 1 Reply Last reply Reply Quote 0
              • Christoph HartC
                Christoph Hart @Casey Kolb
                last edited by

                @Casey-Kolb

                Start your free 30-day trial version

                We're way past that :)

                Anyways, I've fired up bitwig and it seems to play back fine, the only thing I'm noticing is that if I switch the audio driver to generic, it will use 441 samples as buffer size (here we go again), and this leads to some crackle noises on the right channel. I'll investigate more, but which buffer size are you using on Bitwig?

                Christoph HartC 1 Reply Last reply Reply Quote 0
                • Christoph HartC
                  Christoph Hart @Christoph Hart
                  last edited by

                  Alright, forget all DAWs:

                  HISE -> Tools -> Simulate varying buffer size

                  Add the compiled bitcrusher code => complete mayhem.

                  Nice job HISE, you magnificient debugging beast!

                  Christoph HartC 1 Reply Last reply Reply Quote 3
                  • Christoph HartC
                    Christoph Hart @Christoph Hart
                    last edited by

                    Alright, it's fixed. It was indeed an issue where the split container expected a full buffer length so when a buffer with something less than this is processed, it started pointing to uninitialised memory which resulted either in silence or (worse) junk signal.

                    Dan KorneffD Casey KolbC Matt_SFM 4 Replies Last reply Reply Quote 7
                    • Dan KorneffD
                      Dan Korneff @Christoph Hart
                      last edited by

                      @Christoph-Hart E5qR.gif

                      Dan Korneff - Producer / Mixer / Audio Nerd

                      1 Reply Last reply Reply Quote 2
                      • Casey KolbC
                        Casey Kolb @Christoph Hart
                        last edited by Casey Kolb

                        @Christoph-Hart Woohoo! Thank you 🙏

                        Casey Kolb
                        Founder & CEO of Lunacy Audio
                        Composer | Producer | Software Developer

                        1 Reply Last reply Reply Quote 0
                        • Casey KolbC
                          Casey Kolb @Christoph Hart
                          last edited by

                          @Christoph-Hart Will confirm on our end after merging.

                          Casey Kolb
                          Founder & CEO of Lunacy Audio
                          Composer | Producer | Software Developer

                          Christoph HartC 1 Reply Last reply Reply Quote 0
                          • Christoph HartC
                            Christoph Hart @Casey Kolb
                            last edited by

                            @Casey-Kolb The fix with the commit was incomplete (forgot to check HISE compilation), so make sure you pull the latest state.

                            Casey KolbC 1 Reply Last reply Reply Quote 3
                            • Casey KolbC
                              Casey Kolb @Christoph Hart
                              last edited by

                              @Christoph-Hart Back in business 😉 Works without frame container now.

                              Casey Kolb
                              Founder & CEO of Lunacy Audio
                              Composer | Producer | Software Developer

                              1 Reply Last reply Reply Quote 2
                              • Matt_SFM
                                Matt_SF @Christoph Hart
                                last edited by Matt_SF

                                @Christoph-Hart said in Major Issue with Split Node in Scriptnode:

                                Alright, it's fixed.

                                You're awesome! 👏

                                @Casey-Kolb Nice catch 👍

                                Develop branch
                                Win10 & VS17 / Ventura & Xcode 14. 3

                                LindonL 1 Reply Last reply Reply Quote 0
                                • LindonL
                                  Lindon @Matt_SF
                                  last edited by

                                  @Matt_SF said in Major Issue with Split Node in Scriptnode:

                                  @Christoph-Hart said in Major Issue with Split Node in Scriptnode:

                                  Alright, it's fixed.

                                  You're awesome! 👏

                                  @Casey-Kolb Nice catch 👍

                                  +1

                                  HISE Development for hire.
                                  www.channelrobot.com

                                  1 Reply Last reply Reply Quote 0
                                  • J
                                    Jlev777
                                    last edited by

                                    Since pulling in these changes, when I try to compile the effects as DLL I get the following error:

                                    could this be related to the latest commits?Screen Shot 2022-09-12 at 10.26.28 AM.png

                                    Christoph HartC 1 Reply Last reply Reply Quote 0
                                    • Christoph HartC
                                      Christoph Hart @Jlev777
                                      last edited by

                                      @Jlev777 Oops, I forgot to fix this line. Please try again, should work now.

                                      J 1 Reply Last reply Reply Quote 1
                                      • J
                                        Jlev777 @Christoph Hart
                                        last edited by

                                        @Christoph-Hart It works, thanks! :)

                                        1 Reply Last reply Reply Quote 1
                                        • First post
                                          Last post

                                        16

                                        Online

                                        1.7k

                                        Users

                                        11.8k

                                        Topics

                                        102.8k

                                        Posts