Parametric EQ - Limit the amount of nodes?

[Oli Ullmann]

@HISEnberg
I just checked it and I have the same problem. For some reason, the broadcaster stops responding after the first reset. I have a workaround in mind, but I can't check it right now because I have to finish something else first.

When do you need a solution? Is next week okay? Then I would try to implement it by then.

[David Healey]

@Oli-Ullmann said in Parametric EQ - Limit the amount of nodes?:

For some reason, the broadcaster stops responding after the first reset.

I suspect you need to enable the queue

https://docs.hise.audio/scripting/scripting-api/broadcaster/index.html

[Oli Ullmann]

@David-Healey
@HISEnberg
Yes, .setEnableQueue(true); fixed the bug. Thanks, Dave! :-)

[dannytaurus]

@ustk I made a simple source code change to add a MaxBands parameter.

Is this what you mean? If so, I'll submit a PR.

[David Healey]

@dannytaurus Much cleaner solution

[Oli Ullmann]

@dannytaurus
Looks great! :-)

[HISEnberg]

@dannytaurus nice I was thinking of doing this myself, this is a really clean and ideal solution. The UX is precisely what I was after.

Thanks to all of you guys for your responses as well!

[ustk]

@dannytaurus Yeah exactly
I was working on it but you got there first! Thanks!

[dannytaurus]

@David-Healey @Oli-Ullmann @HISEnberg @ustk Hmmm... maybe not as clean as I thought.

I think this would introduce a breaking change to any existing projects using the per-band indices to access and/or change values.

The docs page shows 6 attributes for the Parametric EQ, and I believe they are per-band, so band 1 Gain is index 0, band 2 Gain is index 6, and so on.

The MaxBands attribute I introduced here would be a new (and only) global attribute for the module, at index 0, which would shift all the per-band indices by 1.

Thoughts?

[David Healey]

@dannytaurus what about making it a floating tile property instead of a module attribute?

[dannytaurus]

@David-Healey Here's the initial PR for reference: https://github.com/christophhart/HISE/pull/860

[dannytaurus]

@David-Healey That'll work for the end-user UI but it won't stop the develop adding more bands in the module though, will it?

Although, that could actually be the desired behaviour?

Lemme see...

[Oli Ullmann]

@dannytaurus
The idea with the floating tile sounds good.
We probably won't be able to implement the module variant, as this would certainly have a negative impact on many older projects.

[dannytaurus]

@David-Healey Yeah, works great I'l submit a new PR and close the breaking one.

[dannytaurus]

@David-Healey PR: https://github.com/christophhart/HISE/pull/861