Filter gain modulation not working correctly

[David Healey]

In this example I have a waveform gen with a peak filter applied. I've set the filter's gain to +6dB and added a velocity modulator. The modulator's curve is set so that the range of the gain is -6dB to 0dB.

However it doesn't produce the correct values, it seems to be just going between 0dB and +6dB even though the modulator is showing the correct numbers.

HiseSnippet 1167.3oc0X0saaaCEVJwLH1cqnsnas6NcwFP5VPgksm6B1Ew4O2Fr5Dm3zzcWAC0QwDghTShxqFC6kZ2ra2iPA1KvdD1avFoncjTigiiaR2htPPmCOGxOd9iGptQBBDGKhrrqbzvPvx9SP8Fxk82pOlxs1caK66h5fikPjig0lCCwwwfmks8hOWyvtbIqzm+d8MwLLm.YrrrNVPIvKoATYF2ts9AJi0F6AGQCxIciV6RD7sDLQhBOKhpZEhImgOE1CqEaAj0Kvw8sr+ZDlT2sZ0FM8peBFehWs0Z3C0a1rgac+0p1.uFtY00ZVsgqk8R63QkhndRrDhUS5lBug85K9YtYANlFSOgAZBWqdpU1v1Zq9TlW2wFmXKKaT2LS0hFS0CQcndzy4mYxtW5.NYZj2nYuvzfj6U.R14fTICjtOpGIhFJyFQim6f1kq7f9XkuIOTLxZY+GnsDJA3xmFfOCZGoHNWgUZVs5pNpWO468S3DIUvcD78DRXe9JOoxuTobkeshy6Oju+DGSuLQBFChl3v5vgnoo3J7jfSfnUcFfYIv4Bp19EsoKMa1ThYWmSPAeWNUteHLhtsf4osU5uunGvZjYS80q1carDqcJi3ojKDhjTMbr2FFnRCLtnxnsg3yjhPUhvE7epHGgWBCKKFNoSzFMfxdTvGpcT7XpbX9DwqPLV0oFiMqP79ntTIo+jw3BS.iJK0MAFGkY9onc78AhLCfkPs+w4MMb1W9GYV96fdMd.jVGMcw+rTZeQTfyyANDosctSoR56l0Jogybkz8IREDNJByiCEwfa9YtGDPORvg3BbeOMpMQMJvcaPlvKN0FVEjRaJZqLE4ja4ViYlSxG1pKlWXxTzEloNz2lQ9WquCGqbX8.0N2a+Xhxvnsy4SK5lvhgWS8j8cyqXF6Z4Y+BbjmxGRJDztXwnlRyVglh4u4jeBU0W5l5flRyVD9kTx6++0rJbtX4wXrGMHjA6vG.LUg4TL9.UkXebBSNlawbxNBtHrufSKDAbHHinmdJTHvZhanMjRU6K4CnODX.NNWd5W15kTNfiT1IXNsEW8dDln+5wHCbczERb9P7aeTCyl54NKNSm6bsi24+LnqEnLov+Gf5JXCMAysoLUqco.pLxPLsyhdbq1QvOk.bRlUL72acvHhV0q+mqWL78dsNHAyxr5N+1puaiMogBFN5CsSfKIZuzLF174ny2T2lh00dlaJ75NQ7do0TV1.3JniUUPI5k2zvyXRmy2HtWNbeULbDNEO4KsNP0FsVo7cUPnm.rhgcpNjFsloyQZ631eEpVimV7Yv9pW9ei9ymsUJ80W.3r5J+Bzn7AGcb3smPv6hN31CX0MG81aOv8QHUSq0bROOy4+9CzNTjHo7S6fUs6nZyFsWRPO0sIHfBwbNvTKDxdA8cfMzU0zl6Fv8RI9G0ynAc0z1iFzc7feTVi.LIR7Fh4+GnqdsbJG09lm9WkJi5nocbsR+mB4MrApdqeCgTbptfh0lWEqOuJ1XdU7amWEaNuJ9r4Uwu6xUTe0mMRjh.Sdh59fc2wT021bUvzTFq+EQmMHk

[dannytaurus]

@David-Healey Have you fixed it yet?

[David Healey]

@dannytaurus going back through the commits now to see where it appeared

[Lindon]

@David-Healey try April last year.....

[David Healey]

@Lindon My thought too. I've tried builds all the way back to 2023 and the issue is still there, so maybe this is a bug that has always been and I just never noticed - although I thought I'd used filters like this in the past without issue...

I'll see about implementing a fix.

[Christoph Hart]

@David-Healey afaik it was always like this it used the gain mode to modulate between zero position and the target value

[David Healey]

@Christoph-Hart

The dB readout for the modulator shows the correct value (I've increased it to 18dB here to make it clear) but that value doesn't make it to the filter. Maybe that's why I thought it used to work because I was seeing the correct number.

[David Healey]

Turned out to be a nice simple one, Claude fixed it.

[Christoph Hart]

@David-Healey yeah but doesn‘t that just break existing projects?

[David Healey]

@Christoph-Hart Might do... or fixes them :D

Preprocessor definition?