HISE Sampler VSTs Crash? Across multiple brands (FL Win)

[David Healey]

@Straticah I'll let them know

[Straticah]

@David-Healey thank you :)

If anybody gets some insight on this - it will probably help a dozen HISE + WV plugins.

[HISEnberg]

@Christoph-Hart a good candidate for the your new Claude/Ralph system? This one is a bit over my head unfortunatley... Maybe just confirming the Webview is always running on the right thread and it is properly addressing race conditions in FL? Just a reminder the issue sounds very similar to this one: https://forum.juce.com/t/br-webview-freezes-daw/64917

[Straticah]

@HISEnberg @Christoph-Hart So the only solution right now is to remove webview from my VST?

I mean its possible to rebuild the browser in HISE, but want to check before i do.

There is more than 1000 people using the VST right now - getting a fix/workaround from my side is kind of expected from me.

[HISEnberg]

@Straticah It will require some careful edits to the HISE source code to properly fix. I haven't had time to investigate it personally. You could try deferring any callbacks to your Webview before it is launched. If you use Content.callAfterDelay(int milliSeconds, var function, var thisObject), it may give the host time to respond to multiple instances of the webview loading simultaneously. If this does work it will only act as a sort of bandaid to the root issue.

[Christoph Hart]

@Straticah Can you try to make a minimal example that crashes FL Studio? You can start with the webview examples in the hise_tutorial.

Ripping out the webview for your preset browser would be the wrong move, let's see if we can fix that.

[HISEnberg]

@Christoph-Hart This already happens with any of the examples from the hise_tutorial actually. Just export one of them on a Windows machine, load it in FL Studio, and click on it a bunch of times. You'll receive the same crash report (why users click on it a bunch of times is beyond me, but this is FL Studio we are talking about).

[Christoph Hart]

@HISEnberg ah ok and it‘s still happening on the current dev branch? The cube plugin is quite old so it might be fixed in the meantime.

[HISEnberg]

@Christoph-Hart Yes, as of a week ago it is still happening.

[David Healey]

@Christoph-Hart It's happening in recent versions of Mndala too, so I suspect there was a regression at some point. Maybe someone can try finding an older commit where it doesn't happen.

[Christoph Hart]

@David-Healey I don't think it's a regression, if it happens to CUBE then it has always happened - I'm fairly confident they are not using the latest HISE version for their current version.

[Straticah]

@Christoph-Hart Thanks for taking a look!

Any news on this? I plan to push some other webview feature updates end of March.

[Straticah]

@Christoph-Hart double clicking VST in FL = crash

still an issue unfortunetely: https://youtu.be/NwCzPhjLQek?t=399

[Oli Ullmann]

@Straticah
Do you know if the problem has been resolved yet?

[Straticah]

@Oli-Ullmann it has not been resolved unfortunately afaik

[Oli Ullmann]

@Straticah
All right, thanks to you. :-)

[Christoph Hart]

I could reproduce the crash - unfortunately I couldn't solve it properly, so the only fix is to delay the initialization for Webviews on FL Studio if the plugin is opened. If I "double click" on the instrument track, it crashes in the FL code, not the destructor of the webview (which I hoped it would).

I'll push the fix tomorrow.

[HISEnberg]

@Straticah I was poking around the HISE source code and saw this was added recently:
https://github.com/christophhart/HISE/commit/488ad099eeb20a0f14073fefb1971689ae8578d4

Possibly the fix you were looking for but I haven't tested myself yet!

[Christoph Hart]

@HISEnberg yup that should fix it - it fixes the webview tutorial on my system, but it's just a hack - I had to delay the webview initialisation in FL. Let me know if it persists in your project.

[oskarsh]

@Christoph-Hart do you have more info about that crash in FL Studio? If you could write me a up a bug report or your findings I could pull some internal strings at image-line to see if we can get that fixed properly! :)