HISE Sampler VSTs Crash? Across multiple brands (FL Win)

[Straticah]

@HISEnberg

We are using a Webview same goes for Cube - correct. I was assuming the data refers to expansions because FX never produce this issue.

A build without bebview will be worth a test!

[bendurso]

@Straticah Oh webview on Windows could be a trigger. I had to remove the webview on windows because the plugin was loading so slowly.

I made a post a time ago about it: https://forum.hise.audio/topic/13464/webview-doesn-t-work-on-compiled-plugin-in-windows/18

[Straticah]

@bendurso It is loading slow indeed but not much slower than other VSTs.

The webview works like a charm so far (which is surprising) but it could be the issue.

Might have been coincidence theat the only HISE "other brand" vst i had installed was with a webview aswell? :D

Will know more once i bypass webview from my build...

[dannytaurus]

@Straticah said in HISE Sampler VSTs Crash? Across multiple brands.:

A build without bebview will be worth a test!

100%

[HISEnberg]

@Straticah Yea I suspect this is your culprit:

https://forum.juce.com/t/br-webview-freezes-daw/64917

Do you have enablePersistence set to true?

Do you get any useful information when running your plugin through pluginval?

[Straticah]

@HISEnberg Guys you were right the webview is the thing that crashes Lunacy audio Cube and also my plugin...

Pluginval shows no error all working fine there.

In order to NOT crash i had to remove (not only hide+deactivate) the webview panel + its code.

Seems like something thats not fixible from my side - and that a more "famous" vst has this issue gives me less hope that i will be able to solve this 🫠

[David Healey]

@Straticah I think Mndala is also using webview, does that crash for you?

[Straticah]

@David-Healey it does yes:

[David Healey]

@Straticah I'll let them know

[Straticah]

@David-Healey thank you :)

If anybody gets some insight on this - it will probably help a dozen HISE + WV plugins.

[HISEnberg]

@Christoph-Hart a good candidate for the your new Claude/Ralph system? This one is a bit over my head unfortunatley... Maybe just confirming the Webview is always running on the right thread and it is properly addressing race conditions in FL? Just a reminder the issue sounds very similar to this one: https://forum.juce.com/t/br-webview-freezes-daw/64917

[Straticah]

@HISEnberg @Christoph-Hart So the only solution right now is to remove webview from my VST?

I mean its possible to rebuild the browser in HISE, but want to check before i do.

There is more than 1000 people using the VST right now - getting a fix/workaround from my side is kind of expected from me.

[HISEnberg]

@Straticah It will require some careful edits to the HISE source code to properly fix. I haven't had time to investigate it personally. You could try deferring any callbacks to your Webview before it is launched. If you use Content.callAfterDelay(int milliSeconds, var function, var thisObject), it may give the host time to respond to multiple instances of the webview loading simultaneously. If this does work it will only act as a sort of bandaid to the root issue.

[Christoph Hart]

@Straticah Can you try to make a minimal example that crashes FL Studio? You can start with the webview examples in the hise_tutorial.

Ripping out the webview for your preset browser would be the wrong move, let's see if we can fix that.

[HISEnberg]

@Christoph-Hart This already happens with any of the examples from the hise_tutorial actually. Just export one of them on a Windows machine, load it in FL Studio, and click on it a bunch of times. You'll receive the same crash report (why users click on it a bunch of times is beyond me, but this is FL Studio we are talking about).

[Christoph Hart]

@HISEnberg ah ok and it‘s still happening on the current dev branch? The cube plugin is quite old so it might be fixed in the meantime.

[HISEnberg]

@Christoph-Hart Yes, as of a week ago it is still happening.

[David Healey]

@Christoph-Hart It's happening in recent versions of Mndala too, so I suspect there was a regression at some point. Maybe someone can try finding an older commit where it doesn't happen.

[Christoph Hart]

@David-Healey I don't think it's a regression, if it happens to CUBE then it has always happened - I'm fairly confident they are not using the latest HISE version for their current version.

[Straticah]

@Christoph-Hart Thanks for taking a look!

Any news on this? I plan to push some other webview feature updates end of March.