Matrix Modulation System - Last Call for bugs fixes & changes!!

[DanH]

@Christoph-Hart any idea what's going on here? I've selected the top params to have external modulation enabled but it's suggesting something also happening with the nested params in the child container.... ui glitch or bug?

[ustk]

@Christoph-Hart said in Matrix Modulation System - Last Call for bugs fixes & changes!!:

@DanH just use the css inspector to get the CSS selectors (#delete for the column and .delete-button for the button itself.

Can't seem to style the new delete button nor the column... EDIT: just me being dumb...

[DanH]

@ustk I managed a it a bit but haven't gone back to sort it out. This uses the general button css before it in the script

/** ============================================================ DELETE ============================================================ */

.delete-button
{
  width: 20px;
  padding: 0;
}

.delete-button::before
{
  left: 0;
  top: 0;
  width: 100%;
  height: 100%;
}

.delete-button::after
{
  content: 'X';
  position: relative;
  color: #C4C3C3;
  font-size: 12px;
  pointer-events: none;
}

[ustk]

@DanH How sh...! I wasn't editing the right css file !

Thanks!

[DanH]

@ustk lols

[DanH]

@DanH said in Matrix Modulation System - Last Call for bugs fixes & changes!!:

@Christoph-Hart So I'm not convinced that the accumulated range is helpful / necessary.

So I need to row back on this a little bit

Displaying the Accumulated Range and a range isn't important to me, but I definitely do need the accumulated range values in order to have my little white dot display how the modulation is behaving, accumulated or not.

So is it possible to get something like obj.accumulatedModMin / obj.accumulatedModMax as obj items in the drawRotarySlider function? Might also need a currently selected range too (although this is basically "modMinValue": 1.0,
"modMaxValue": 1.0, I think?).

[DanH]

@Christoph-Hart Would it be possible to have a value parameter inside the extra_mod nodes -this way we could change the values whilst editing the network. Currently we have to break all the connections and then reconnect them when we need to compile. Obviously the value param would be ignored in the compiled network.

[Christoph Hart]

@DanH if you assign a modulation slot to a network parameter and then use the extra mod for this, then you can use the network parameter as value parameter? This is how it's supposed to be used and compiled anyway.

[DanH]

@Christoph-Hart Ah ok, this does actually work in this latest commit Didn't before, all good, bravo

[DanH]

@Christoph-Hart However it doesn't look like LFOs assigned to a parameter are having an effect yet....

[ustk]

@DanH In this case I think the parameter should just be a normal parameter without ExternalModulation
The way I understand it, a scriptnode parameter that has ExternalModulation set shouldn't be connected with a cable.
Just set the target for the corresponding UI knob

@Christoph-Hart if I'm right then the connector (and any previous cable) should be removed or disabled and greyed out.

[ustk]

@Christoph-Hart For the delete button, I can't seem to actually set a background color like I do with other elements.
background and background-color are both setting the icon color (be it the original one or a custom icon in .delete-button::before)

[ustk]

Why do I see both the controls that have amatrixTargetId and the actual Matrix Modulators (with the _MM suffix) in the drop down?

Should they be named the same not to appears as duplicates?

[ustk]

@Christoph-Hart Bump bump

What should we do with this?
Is it on your side or is there a specific procedure not to show the Matrix Modulators in the list?

[Christoph Hart]

The matrixTargetId is the ID of the modulator unless you explicitly change it

[ustk]

@Christoph-Hart oh ok so if I use the same id it will appear only once?

[Christoph Hart]

yes, that's the idea.

[ustk]

@Christoph-Hart Got a weird one...
Changing the target from the dropdown, the modulation stays on the previous target.
The dragger appears on the new one but the modulation is still heard on the first target...

[ustk]

@Christoph-Hart So in the end, removing a connection from:

• Double click on the dragger -> works
• Click the delete button in the matrix -> works
• Select "No Connection" or another target from the dropdown -> doesn't work

[Oli Ullmann]

@ustk
@Christoph-Hart
An addition to this:
This only happens if a MatrixModulator is used for the parameter. If only the matrixTargetId is used for modulation for the parameter, the problem does not occur.