Matrix Modulation System - Last Call for bugs fixes & changes!!

[DanH]

@Christoph-Hart Would it be possible to have a value parameter inside the extra_mod nodes -this way we could change the values whilst editing the network. Currently we have to break all the connections and then reconnect them when we need to compile. Obviously the value param would be ignored in the compiled network.

[Christoph Hart]

@DanH if you assign a modulation slot to a network parameter and then use the extra mod for this, then you can use the network parameter as value parameter? This is how it's supposed to be used and compiled anyway.

[DanH]

@Christoph-Hart Ah ok, this does actually work in this latest commit Didn't before, all good, bravo

[DanH]

@Christoph-Hart However it doesn't look like LFOs assigned to a parameter are having an effect yet....

[ustk]

@DanH In this case I think the parameter should just be a normal parameter without ExternalModulation
The way I understand it, a scriptnode parameter that has ExternalModulation set shouldn't be connected with a cable.
Just set the target for the corresponding UI knob

@Christoph-Hart if I'm right then the connector (and any previous cable) should be removed or disabled and greyed out.

[ustk]

@Christoph-Hart For the delete button, I can't seem to actually set a background color like I do with other elements.
background and background-color are both setting the icon color (be it the original one or a custom icon in .delete-button::before)

[ustk]

Why do I see both the controls that have amatrixTargetId and the actual Matrix Modulators (with the _MM suffix) in the drop down?

Should they be named the same not to appears as duplicates?

[ustk]

@Christoph-Hart Bump bump

What should we do with this?
Is it on your side or is there a specific procedure not to show the Matrix Modulators in the list?

[Christoph Hart]

The matrixTargetId is the ID of the modulator unless you explicitly change it

[ustk]

@Christoph-Hart oh ok so if I use the same id it will appear only once?

[Christoph Hart]

yes, that's the idea.