Matrix Modulation System - Last Call for bugs fixes & changes!!

[DanH]

@Christoph-Hart actually it could because the offending ui controls aren't in a panel at all. Trying to test my theory but moving a panel up the component tree is causing instant crash in this project : /

[DanH]

@Christoph-Hart ah yes ok - so if your component isn't in a panel at all the the dragger remains on top of any other ui component i.e visible at all times (when that source is selected). Will DM you a video

[DanH]

@Christoph-Hart Is there a way to make the source select buttons behave more like a radio group? At the moment if you click an already selected button it deselects it and hides the draggers.

[Christoph Hart]

@DanH yes that's intended, otherwise you will never get back the behaviour of showing the accumulated mod value. How would you do this instead?

[DanH]

@Christoph-Hart ah yeah I see. This might be a me problem / ui design problem (for me).

My source select buttons show the selected modulator's controls and a little border around the selected button to show which one is selected. That doesn't change when clicking the source select button again (good) but I guess I need a way of communicating what the mod system is showing in terms of why the mod ranges change, and probably another button element to display it's state.

I'm not 100% sure that other devs show the accumulated mod range.... actually some do, some don't, but not either / or, they display it on top of the current mod range.

[DanH]

If we could get a delete button in the Mod Matrix itself for each row that would be super useful!

[Christoph Hart]

@DanH said in Matrix Modulation System - Last Call for bugs fixes & changes!!:

I'm not 100% sure that other devs show the accumulated mod range.... actually some do, some don't, but not either / or, they display it on top of the current mod range.

I'm pretty sure that's the case, otherwise you end up with invisible modulation that is super annoying.

[Christoph Hart]

Alright, the z-order should be fixed now, it also monitors the slider's visibility and hides itself when the parent slider is hidden.

If we could get a delete button in the Mod Matrix itself for each row that would be super useful!

Yes good point, noted.

[DanH]

@Christoph-Hart Nice, thank you! So I need to test more but I'm having to click a source button twice or more to get the draggers to stick after a compile. I'll test some more tomorrow.

[DanH]

@Christoph-Hart So I'm not convinced that the accumulated range is helpful / necessary. 11 years of using Serum almost every day and I never sought to know what accumulated range would look like. You often only modulate a parameter with one source, and if you add more sources then I think you accept that there are limitations to what can be displayed.

Having said that if people find the accumulated range useful then crack on, but would it be possible to remove the 'off' state of the source select buttons if desired? i.e a source button has to be 'active' at all times

[Christoph Hart]

@DanH sure, this could be simply a property of the floating tile then, no?

[DanH]

@Christoph-Hart perfect!

[DanH]

@Christoph-Hart so with the singleDragger method the dragger knob's label will appear on hover when hovering in it's location, rather than the label only appearing when hovering over the dragger itself. I've drawn the label well away from the dragger in the example below but you can see the label appear on mouse hover:

HiseSnippet 3645.3oc6a0saabbEdok1jPlDm31fh1hVfAxn0TNRLjxRJRzvvTlRJgHRVphzN00H0X3tCImnc2Y6typepgAxaPupWj6xSQA5Ms9QnOB8QH22KbOmY1c4tjTzJB1tBs0PlV6724uuyOyYo2OPXwBCEAFEJ04TelQg2yr8odxAMGP4dFs1znv6atqvdy.Z+NrPow8N0mFFxrMJTXlOCWRghyZn9y2e26QcndVrgCYX7PA2hsC2kKGN59M9Btiy1TaVGtalUubiVVBulBGQDvNyXV0vmZcHsO69TbYWwz3yogCLJbSy0Vt5sVcE5ZqSspsrEa0tqrt85Uq8o8pt5pKuxsXrpVqtzJUsLJ7VaYykhf1RpjEZTX16IrOs8.wwdZB7PdHuqCCenlQafx5g2V3XihHNpQyAbG68SzSgFvgt+Ps1LZs1GYtK2lmN9Ps2GplfLbGYUfEtRd1albrWsrrW0Lr2DXoBYXoY0rz0LaaEv8kCmA4m20rkmjEziB1orrhdsFW4u7glexMuIYWpLfeBAr7QNTfCIchfO4TGx9xJjVsJUZqSrbhB4GwHsA6kE7OLGlkjK7HOnEYGQetUo67x+SoRcFvCIgdbeeljXybEdgx.TeP.EAQJHQgLhb.iDxjZRkRolTGmt.Fo7735bPXlZktBahMfX6yBBKIGPkDZ.iXyC8cnmxrIGOf4QNUDAT3HV.Q8AkbnmnaERoR0pPP3NLRO1wD.R5ooVHAjM73kGKTKNjTFNja33.rFCNTt0fbKGIJ3yP65vCG.jMd6A79CjjPtMa9Jj87fs35yAsLp5.A3Xv4fDv.ok.hWtCrGXHFpgv06GE3KBYgUJsTExiFxLJg9X3CFJaw5BkHa4vsNDXkERoUWFY.vRNHaAbYYG9gLP36FIk.ENlKG.OEPs4BR+.QjOv0JaF2ylaoLTnTMmUTP.ySNGITiGBSrRUJcK.xzSQcOvjlQoiaDPKJk4PFR34bJIDs9TPM402QaQwUQJy6o1UL0RHFvNwJJPB.r.tDb8HuRUhiiPbHgpwGgJvNH3NJ1APYJ4A9w02g4BmKytRoR27SJ0T.+tmrhKbHaG.Oj58Td0pUWfrb0pye6RkPWllALPY.TxU6zflGWkaTEBbRVnUibDMf35RtCYKu9bOVEK0l1McGZ+txy8YNhtfy1P+OjQfXJrfZykPvClHFQjCPoHsqaEKGFMXCGmlCWY44TmDxQMevAGr086ryidR6s1Yqlc1ZymzduGbPys.Fct4hI2FRI0BgBVwdcI54Qs2D.yAVFpmM4qi.YND3e1DLZI71T7q6E4oFnrdGyW5okJNMlUuraW5YnjMTi6P6ASlXK057cDfbrC.J1vydaFyobhZ89.d3XlBeF.9n5.JL4..Ap8pPHp9LTyA9ebkXaSkTL9wWxPuPPgejdA1rdzHGI3S6YyB.7LIQr.WHbEAnNLE8qApgf+.3ApQlIQGUpyiodRvkSTJSrx7gJAlLlgw.FVvlDtwdcneDDCTDICAVEz+orh1QaScjhxhtesRYmAXqh7QC5yTQSopyNMBi9zShy.pOjKQNBciUF5hngPsw6.HWKIEIGRmJgNfZN3dhHO6vGW8qVfL1f09JxGO9n2BVZMzIr1RnSXQM2hlOqAL.dNpmABHUgVhSDnjHJLIXmDdZ3XQPpJag1EjbY187kJBpih7dvr24NmsGCrN0BU7xNJL.D6gKkPPr3nOcERzff5O7winNQLvn.QipTQyDEKhTG0la.JrvJ9QgCJi5tJAfM+HLRjaGgeYP5mGk7hOC9KyIjkk32OSbMHZN.uF.tTmpgUpLATOOgjf0.fBLEbbc8kmB3zXqSE7nJ1VnLy2HLNILnTrgPm.RT3ipl6RdDC.qzg6Smynl+IjSTeFx+iwmk5i6KjwnTNF9Bf9ZuIjMkBI0IyI0CjTkgLwKKTuSj+SXbzARcvnUKvFSqHH838i.+J.nqy1CCAlcWdnVLz3Uegej+BJmud4NRbIpibDYBGGJCBBcuPlioKa.8HND5g.NGg.5mGXqj2yzVNzA.spJPu5WpgPZ3mXqJpvdlBX+IpLmX7djrJvh1YJNFbLlRnSNpcSpf6CItZ4anc8vMcabh.lLJPAyUtNitto5htXspSzKcwZqr.YMzibET.xRhmAQWgvv..tOODRgtcRj84.cVZZNL7ylPXz4VHe7HcrYkN3XzOJNSTn7Tvx.0VwzwZNL1zkT6G4WmMCLRdPC1xyAxi1F2Zabmkmqz0ALsLP33vBvfdXpGrRGO65jquzRKAhhO01FXn5P.G+Sfm6p.ZKhUEEEVmrR0eU5f00XdAnZHWes0VClnO0uNQswmUpTkXtaLJs95qCq0BJyOHktSjNwLyhNrdx5jao4njAUUWlxmtP.atW5iCX5YWdE0i34exhgCn1hiULHYI3uvbjtN.mgbSTPHxN8Cnc6BGuRB.KQqc2euC5rw86TOMFiJWXHKxFLDRZpKdHg40GtDWbU2YLOvbkHjrEFfk8opA.VMloJScBIZs5pX6v7J0WrBeoTENTDtjc6QTrTJMmlud8tLH5KCOBKcQA0I23F411hbWfoqikOTdwEwMtOUN.Q0GyskCPMZ0iFf583.S0Izt.ODMB4WLwdtxJqj0drxHng55DQHKAYz8BA9ysNTnJE7.Weke07wJd7lYpxYAuTGhK2CXSmXP9vPT9hiwJr6kjoqtWR9sqyQwE33SIOMcVBN8sIOCmEhmgZ+IMouCDjAN2IMGM5D35.rSN6ImFYAaMi7zhiMA3tRC.O8IrmRUh8YWL9dJSZMokJGW6Jpa1YisydAgvQJN+KT2q6NjGmVtHDepITPMbldPrBrmGyM+BpjCEm7R1mKsFL27eEParZhCwDJpiEpM3PLBzXkdBQlTA7wLjPndXXE+0yQ.EwC0KJ4NvU7pTozjI31wqqCrL35ASgDu78uzT2eZ0hBOLK9ddkUUIBXSxnS0q2DmqYZj1INM1QnfoswxdQtcYAKnKaJcgFElMeqTLO6VojsSOwt+YVnvqkGWtmOy6r5+iQrVzvnvUh4JXoRUSWtZbSWZqRLZvsMJ71lJ.gghgyzarFFmiM+Vlplrkcuey29yV84FOnElmD67SL2.bnO36xQguvlri3VLcefJZtIK7PovGzQoFciBumLtwUZZlECnn7GXlCVYbxPVmz3zgOTtQLCno1uvbzKyNzhazseR28J9VIcHDhW6NsQWJ6vR1IxwWrRST32a9THcxboVpV1yUmL0KRu.t9VXXKXkUUOsMvnhi+RQvgg9vk7gw6Qw5pelgJrepX+cQMz4RSGowuAMnop2q9RwCYTn1YTnO+QMf5i7aC0Lms2ptYa05ZO2klY6q0HLpWONLxrlgRC+gZ.rct60tYMhlj9z.JbyPlZl217gJTUdCfy1cdAdlYMUu3Eu3ASvnbsqcs+03FEXwpCHqx3ZuL7cFg4SyqKvCeHulSzdWsnoNfIJYXZEM92hCU1ZjSG9n75PCiQz5e229s+06lnWMMI12C1ussCa+3D9C26ROOuNbg+7e6UuN7Gl+5RYToOOHiJ8adbd+0ezX9qud8RO90nWpZNM3RUdOdxXh24Fy8kDLl6qngw38P+CMSYorszGgbCUa45idqjBcx579JqO+mWV7Z5XLSlGuxD3QLW1qAdL9si79la0qGTV+PFbVys+suddUHYI+6nI+O2TiuFpnRPWJd4WZNE32TdgW+iy6K7x+b+BuFsJlYOeUw7RdeUydo68Ucdww+3wLMguA81JLSF17ZZ1zzbms2Swa5e6kxM2i6KbnA37aGv9CQLOqLy+NMPXQqgnpF+oFeI8H75otwkukdR6v5CZfrizgAoGZepmUVDXaWg.tSNlGHKX6iZ.ky6ukGEDc6rGx9CngX45PU+4NF3X6H1khMqooiv5vrS1puGb+Y8U.xNdSUulSD.06rsMjVUG5+wlqtLbIlJ89X7y0aBebq8d077OjnW0ltM+JmanIX9IolbDgdILQflKSAd+GjKiiEWx7gL.MgTD4uLO9CwS5AgrNTEKjASF26hriEW42t5BAuH45pctEv3.DuKTGF6jM97MaefRBeaS8umU71U3I7GH734bbOfAkeg8B5LD5IpTTc13vrt4eNjLXDc.MyVdTi1fSZtDY+y6d.ygAQAxVxXdcVBg1gcDTH8XC2LJ3HV1CTQzwFMlLiM9qNuWyyoew6apYbhJH4kO+1qlveZE9kOF78LUl3Kq5uOvLFkeoUAdUyXugKqpvodGhY9u66PbfHBuIc7EhKXd+HW8WQAf5ddLGrAiEtBVvi94p3ypplXd1pGvqvGOYM74BwSVKYRC8gmoKdwupYHkQG0qYezdbniHGSGE2ntUbxPSN8PzIwKJcr+tZrIX8Fl.svLYM.WMIwVa78lge4.Up+eh5YBVrG4yXvckP3ya36KsmkDHeG7ElfeMnxU+Jyk2Q3g3fgCB0Mf0Bc.hmyU2pfFLwo996tMHjSbOsoxH82BqMbEQd4JdtvL++6wcIokI49pQVL4qFo14KkSi+pQNzW6BVs1DEE8khPuY35PObzN4O4qq8MsaLJF5hWjphlGP85yvPzs77ij5mJ7VSuknYiHLdSoML5nZzmdQA46z5j6T5O84F6EIGReybz2vHG8Q04zoO3NCn7DxrQ3uiEHFM50k0Tb4vkklFtLWK7y1GuWgWi3LwnpdRbFsTn0aDLp4ze0GSGif8HIGFExhAIFjpDCSEKNhuPiKHV7J+uPoLuIngK0JP7j3W5O5+7NpQ.41S8eOfhfuC7Lo1XunULZD+IVV4Opw13RWzMdqK5FW9htwUtnab0K5F+zK5FW6kuQrPkMhfvO5PvFF6t+V5NFVHsckPL8+Mfb8YkG

[DanH]

@Christoph-Hart So in my project I get a straight crash when clicking the 'Add' button in the ModulationMatrixControler floating tile. A simple project is fine.

I've removed all styling scripts for any modulation floating tiles, knobs etc - anything that interacts with the mod matrix. I've removed all global modulators. I'll keep removing things to see if I can find the source of the crash but in case you have a second to look at the crash report below you might be able to suggest something more specific for me to look at... The crash is identical each time and has been happening on UI elements too from time to time.

Thread 0 Crashed:: JUCE Message Thread Dispatch queue: com.apple.main-thread
0   HISE-5.9                      	       0x100627204 hise::MatrixIds::Helpers::IntensityTextConverter::IntensityTextConverter(hise::MatrixIds::Helpers::IntensityTextConverter::ConstructData const&) + 80
1   HISE-5.9                      	       0x1007d8b38 hise::MatrixBase::RowBase::updateIntensityConverter() + 1252
2   HISE-5.9                      	       0x1007d67ac hise::MatrixContent::Row::updateValue(juce::Identifier const&, juce::var const&) + 676
3   HISE-5.9                      	       0x10167e3ac hise::valuetree::PropertyListener::handleAsyncUpdate() + 196

[Christoph Hart]

@DanH Hmm, I can't spot anything obvious. If you can dumb it down to a pasteable snippet that reproduce the crash it should be pretty easy to fix.

[DanH]

@Christoph-Hart ok will give that a go, thanks.

[DanH]

@Christoph-Hart Stripped back the project to bare bones - just a few ui elements. Have emailed you link to the project. Many thanks for looking if you find time

[Christoph Hart]

@DanH yup I could reproduce the crash - the fix was trivial, but I'm not sure if it also fixes the actual project, so feel free to check it out.

[DanH]

@Christoph-Hart ah lovely, will do

[DanH]

@Christoph-Hart so it seems to have fixed the project I sent you but now I can't open my main project at all Want me to send the stack trace? Or try something else?