Colours added/removed in UI XML

[dannytaurus]

I've noticed colours being added or removed in the UI XML files, even when I haven't touched the components being altered.

Seems to be something in the source that adds/removes these colours for some reason.

// XmlPresetBackups/SublimeUIData/SublimeDesktop.xml

// After one save, bgColour and itemColour are removed from the XML:
 <Component type="ScriptLabel" id="lblHeaderSource" x="0" y="0" width="180"
                  height="14" parentComponent="pnlSource" fontName="Eurostar" fontSize="15.0"
                  alignment="centredTop" text="SOURCE" textColour="4291611852"
-                 itemColour2="0" editable="0" bgColour="0" itemColour="0"/> // 👈 old line
+                 itemColour2="0" editable="0"/> // 👈 new line
      
// Then later, after another save, they're added back in again:
 <Component type="ScriptLabel" id="lblHeaderSource" x="0" y="0" width="180"
                  height="14" parentComponent="pnlSource" fontName="Eurostar" fontSize="15.0"
                  alignment="centredTop" text="SOURCE" textColour="4291611852"
-                 itemColour2="0" editable="0"/> // 👈 old line
+                 itemColour2="0" editable="0" bgColour="0" itemColour="0"/> // 👈 new line

It causes lot of git noise. Any idea what's causing it?

[David Healey]

@dannytaurus Maybe I'm misunderstanding but bgColour and itemColour are present in both of those blocks you posted.

[dannytaurus]

@David-Healey That's a git diff. The - lines represent the removed lines and the + lines are the added lines.

It shows after the first save, the bgColour and itemColour properties were removed. Then later, after another save they were added back in.

I guess if you don't use git on the command line you probably don't recognise the format, sorry!

EDIT: edited the original to show the old/new lines

[Orvillain]

Probably some tinyXML serialization type thing. I notice a lot of floating point values often change to ints and back again, from commit to commit. Tis a bit annoying.

[David Healey]

@dannytaurus said in Colours added/removed in UI XML:

That's a git diff.

Oh I see it now!

[dannytaurus]

@Orvillain Yeah, I made a PR that casts all x, y, width and height values to int before saving the XML.

PR here: https://github.com/christophhart/HISE/pull/831

But I can't pin down why the colours are added and removed.

[dannytaurus]

@David-Healey Sorry, shoulda been more explicit about what I was posting!