HISE Logo Forum
    • Categories
    • Register
    • Login

    Parametric EQ Sticks when deleting a band

    Scheduled Pinned Locked Moved Bug Reports
    12 Posts 4 Posters 75 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • iamlampreyI
      iamlamprey @Chazrox
      last edited by

      @Chazrox Yeh I thought it was related to this post but maybe it's something on my end. Strange that a reinstall didn't fix it.

      ChazroxC Oli UllmannO 2 Replies Last reply Reply Quote 0
      • ChazroxC
        Chazrox @iamlamprey
        last edited by

        @iamlamprey

        @iamlamprey said in Parametric EQ Sticks when deleting a band:

        Strange that a reinstall didn't fix it.

        super.

        1 Reply Last reply Reply Quote 0
        • Oli UllmannO
          Oli Ullmann @iamlamprey
          last edited by

          @iamlamprey
          I still have the same behavior. Did you compile HISE from source?

          iamlampreyI 1 Reply Last reply Reply Quote 0
          • iamlampreyI
            iamlamprey @Oli Ullmann
            last edited by

            @Oli-Ullmann always 🙂

            Oli UllmannO 1 Reply Last reply Reply Quote 0
            • Oli UllmannO
              Oli Ullmann @iamlamprey
              last edited by

              @iamlamprey
              Okay, I'll try the last commit. :-)
              What did you do to get rid of the problem? Just compiled the last commit?

              iamlampreyI 1 Reply Last reply Reply Quote 0
              • iamlampreyI
                iamlamprey @Oli Ullmann
                last edited by

                @Oli-Ullmann said in Parametric EQ Sticks when deleting a band:

                What did you do to get rid of the problem?

                I didn't, it's still occuring for me (Windows)

                Oli UllmannO 1 Reply Last reply Reply Quote 0
                • Oli UllmannO
                  Oli Ullmann @iamlamprey
                  last edited by

                  @iamlamprey
                  Ah ok, for me too. On Mac.

                  1 Reply Last reply Reply Quote 1
                  • dannytaurusD
                    dannytaurus @iamlamprey
                    last edited by

                    @iamlamprey Same here on Mac, on an older HISE version c623b06d from Oct 9th.

                    To be more specific, the issue I see is only when deleting the last band.

                    Example

                    1. Open snippet and expand EQ panel
                    2. Add two EQ bands
                    3. Delete one band > path is redrawn
                    4. Delete the last band > path is NOT redrawn

                    Meat Beats: https://meatbeats.com
                    Klippr Video: https://klippr.video

                    iamlampreyI 1 Reply Last reply Reply Quote 0
                    • iamlampreyI
                      iamlamprey @dannytaurus
                      last edited by

                      @dannytaurus Actually yeh you're right, it's the last band.

                      It's probably as simple as a missing repaint() call when the last band is deleted but I haven't looked at the source just yet

                      dannytaurusD 1 Reply Last reply Reply Quote 1
                      • dannytaurusD
                        dannytaurus @iamlamprey
                        last edited by dannytaurus

                        @iamlamprey Fixed with this PR: https://github.com/christophhart/HISE/pull/793

                        Changes repaint(), which I believe uses a cached path, to refreshAsync(), which forces a proper repaint.

                        Meat Beats: https://meatbeats.com
                        Klippr Video: https://klippr.video

                        1 Reply Last reply Reply Quote 2
                        • First post
                          Last post

                        22

                        Online

                        2.0k

                        Users

                        12.8k

                        Topics

                        110.8k

                        Posts