parameterId mixup with Waveform Generator

[Morphoice]

Parameters on the Oscillator seem to be mixed up.
I have to select parameterID "Mix" to access the PulseWidth1 with a knob...

PulseWidth1 parameter actually enables/disables the SyncSecondOscillator

[dannytaurus]

@Morphoice That might be my fault. I added the SemiTones feature to the Waveform Generator recently and may have messed up the parameter IDs.

You're on the latest develop build, right?

[Morphoice]

@dannytaurus Yes, sir! Are there some other things I may suggest to add, since you’re at it? ;-) like a modulation source for the pulsewidth?

Also a thing that confuses me is the sinewave actually displaying a cosine icon, which might give phase issues when mixing the two oscs but I’ll have to scope that. Might be a good idea to have sine and cosine available, but I recon for speed it uses a lookup table or polynominal approximation anyways and not a real math sin function

More of a generall question: Is it at all possible to add other waveforms like a morevintage looking saw that's curved not straight for example? Though a PolyshaperFX node would probably be able to change the waveform in that way... I'll have to give that a try

[Morphoice]

@dannytaurus or a t least a button to shift the phase of either one of the two oscillators would go a long way shaping the waveform when they're synced

[Morphoice]

@dannytaurus I can confirm I got the waveforms just the way I want them using the polyshaperfx... brilliant! don't bother, but a modulation source for the pulsewidth would be ever so awesome.

[dannytaurus]

@Morphoice Looks great! Congratulations!

I also would love to modulate the pulse width but I think I might be a bit out of my depth there. I'll certainly take a look and see if I can implement it though

[DabDab]

Bump Bump Please Fix the Mess....
Tip : Only Solution till now is to use.. "Enable automatic parameter assignment mode"

[dannytaurus]

@DabDab Could you post a simple snippet that shows the issue please? Something I can use while I'm fixing the problem. Thanks!

[Christoph Hart]

@dannytaurus it's fixed now. We just forgot to change the parameter ID definitions after we shuffled the semitone parameters to the end to ensure backwards compatibility.

[dannytaurus]

@Christoph-Hart Cools