HISE plugins crasshing DAWs

[ulrik]

@HISEnberg said in HISE plugins crasshing DAWs:

So something is buggy, I will start going back a few commits but this very simple delay plugin is causing my DAWs to crash.

If someone is kind enough to take the time to compile this project and let me know their results I will appreciate it!

I compiled this project and I had no problems to load it in to Logic, Ableton Live or Reaper, on Mac OS

[HISEnberg]

@ulrik wonderful thank you very much @ulrik

[HISEnberg]

@d-healey Okay now I am running debug standalone builds in XCode and using the debugger. This is based off of the master branch of HISE. Here is what I am seeing:

/Users/.../HISE/JUCE/modules/juce_core/containers/juce_ArrayBase.h

[d.healey]

@HISEnberg Try going back a bit through the stack trace and see if you can find out the function that is calling that function, keep working your way back until you get to something meaningful and then step through the code bit by bit and see if any variables have unexpected values.

[HISEnberg]

@d-healey unfortunately for me I wasn't able to discover much of value. As far as I can tell, numUsed might be pointing to an invalid memory address or uninitialized memory. The ArrayBase object is either improperly constructed or has been corrupted. This is as far as I could get.

[HISEnberg]

@Morphoice I am thinking it could be what you mentioned here, something fishy about using the Script Fx node. I experienced the same issues on Windows.

I just recompiled my wonderful delay example I posted her, moved it into a hardcoded fx node and it actually opened for me and works inside of Ableton.

[Straticah]

@HISEnberg i had this issue aswell when saving scriptnodes.

I think i fixed it by deleting the saved scriptnode and recompiling without the saved node again.

I guess you tried that already but there is definitely some error potential when saving scriptnodes instead of them being saved by HISE project.

[HISEnberg]

@Straticah Right, interesting. Is this causing the plugins to crash, or the HISE project to fail? Everything works fine for me inside of HISE, it's just compiled plugins that won't work

This is a pretty serious issue for me at the moment, I was surprised to find the issue has only come up for a few developers so far.

@Christoph-Hart I hate to bug you without having more information for you, but I thought you should be aware that I am experiencing consistent crashes across platforms/DAWs with scriptnode based projects. The hardcoded slot seems to be somewhat more stable but I haven't looked into this too much.

This is true on both the develop and master branch, I've rebuilt hise quite a number of times today.

David was kind enough to lead me in debugging in XCode but I couldn't find much useful information past what I have posted above. I'll post more if I can find anything.

[Straticah]

@HISEnberg the HISE compilation worked fine. Its just when you open it in your DAW it gets an error and shows no UI at all. Cleaning build directory, deleting all saved scriptnodes (if there are any inside the DspNetworks\Networks folder) and compiling dlls (without saving nodes - only project).

Usually this fixed it for me most of the time. I only had this issue when using multiple saved or compiled nodes inside other nodes or when going from hardcodedFX back to scriptnode.

Question, do you save the scriptnode before compiling and this might cause the error?

[Morphoice]

@HISEnberg super weird. i'm trying a few experiments with the scriptnodes turned off, on, different nodes and report back, but so far it looks like whenever there is scriptfx it crashes... I remember weeks ago I read somewhere that scriptnodes always have to be compiled into a DLL and used as hardcoded in order to work properly but I could be mistaken as many people stated it would work just as fine without... is there an official statement from christoph somewhere?

[Lindon]

@Morphoice said in HISE plugins crasshing DAWs:

@HISEnberg super weird. i'm trying a few experiments with the scriptnodes turned off, on, different nodes and report back, but so far it looks like whenever there is scriptfx it crashes... I remember weeks ago I read somewhere that scriptnodes always have to be compiled into a DLL and used as hardcoded in order to work properly but I could be mistaken as many people stated it would work just as fine without... is there an official statement from christoph somewhere?

if this were the case then routing.global_send would be a pointless node to have added, as it wont work inside a compiled network/hardcodedFX -- no you cna leave your scriptnode network uncompiled - its just a less efficient that way, or if you are using the global send/receive nodes then - well- cause you have to...

[HISEnberg]

@Straticah Hmm yes, I will resave a Scriptnode if I make any changes to the network then recompile, and I usually leave the "Enable Compile" flag on. Typically this should just overwrite any existing of the .cpp and .h files.

So you have been removing the networks from your project once you are done editing them? I've never done this before and haven't had this issue, but if it works it works.

@Morphoice I am not sure Christoph has made a statement about it, but for some context I have released several products with just the Script_Fx before. Also hardcoded slots only came about some time after Scriptnode was introduce, so that you can dynamically switch networks. So @Lindon makes a valid point but I can see why you are skeptical if you only started using scriptnode recently.

I am going to spend some time migrating some projects to Hardcoded Slot Fx today to see if it resolves the issue, will report back here.

Thanks for all your input in the meantime!

[Morphoice]

@Lindon @HISEnberg I get a feeling that the problem is only with the Master Chain FX. I can use scriptfx on a Synthesizer Group and did so successfully before when I started using HISE a few weeks ago
I will have to do some testing to confirm, but I wont be home for a while