ScriptNode Feedback After a Month of Heavy Use

[HISEnberg]

@aaronventure Wow thanks, it was staring me right in the face

[aaronventure]

Thanks for the snippet.

@Christoph-Hart said in ScriptNode Feedback After a Month of Heavy Use:

// iterate all channels
for(auto& ch: data)
{
// create an from the iterator object ch
for(auto& s: data.toChannelData(ch))
{
s = Math.random();
}
}

Do you think it's a good idea to put this structure in the base template? I can't imagine a scenario where I wouldn't want stereo linking without offering a stereo linked version as well.

[aaronventure]

@Christoph-Hart said in ScriptNode Feedback After a Month of Heavy Use:

You can already "move" chains to an external file. Click on the package icon and Choose Wrap into DSP Network. The UX is all over the place and you need to press resave after performing this step, then unload and reload the network, but the basic functionality is exactly what you suggested - it even retains the parameter connections.

I think part of the issue of this being hidden is that it's only visible in the package icon in the main toolbar, and not if you right click the node.

[griffinboy]

@HISEnberg Yes! I would love a buffer! Insane granular experiments would ensue

[aaronventure]

@Christoph-Hart since you seem to be on a bug killing spree and have grazed Scriptnode, I feel like now's a good time to mention this.

2 things.

1. With the new improved clarity regarding hidden nodes, what do you think about further improving this (or having an option for it in the toolbar) by printing the differentiating node hierarchy in a namespace way when hovering a connection? https://forum.hise.audio/post/81634

2. Is there something that can be done regarding UI performance of Scriptnode when working with big networks? If you have 200 nodes, adding another one or collapsing any one makes the whole network do a visual refresh: the display engine loops through every single parameter of every single node, one step at a time, refreshes it, checks its min/max, and refreshes the graphic. This effectively freezes the network until the process finishes. This is a complete non-issue in smaller networks but when going big, it does become problematic. Can these be grouped into a smaller number of draw calls? Would the CSS renderer help here? You mentioned it bypassing the message thread issue that LAF seems to be running into. Any other ideas?

[Christoph Hart]

@aaronventure sure why not.

1. I've added the full path of all non-equal parents like you suggested. However I realized that the label I've added clashes with the tooltip so I'll remove the label and put the string in the global tooltip (there's also a problem with the tooltips appearing at the wrong position when zooming the scriptnode UI so that has to be fixed anyways).
2. Sure there is some room for optimizations in the scriptnode UI. I've noticed that it still creates all child nodes even if the container is folded. I'll try what happens if I don't do that, as this might heavily increase the performance of big patches (assuming you're a good boy and don't work with the entire network being visible like a complete maniac)....

[aaronventure]

@Christoph-Hart said in ScriptNode Feedback After a Month of Heavy Use:

(assuming you're a good boy and don't work with the entire network being visible like a complete maniac)....

Yup, I'm making good use of chains to fold groups into groups. Network this big, organisation really is key.

Thanks.

[Christoph Hart]

@aaronventure Alright, please have a go at it, I've just commit a change that skips rebuilding all child nodes for folded containers.

Let me know if you run into glitches, these kind of changes are very prone to breaking things.

I've also fixed the tooltip scaling and moved the popup label into the tooltip so that they won't clash anymore.

[aaronventure]

@Christoph-Hart oh yeah this is much faster now. Awesome.

No issues so far with existing networks, adding, removing etc. I'll report if anything happens.

The cabling tooltips and the source highlight is also great. Thanks.

Another issue is now brought forward: since it's now 100% desired to fold down everything not worked on right now in big networks, the folded node visuals are rather unclear. The text is cut off because the node is forced into a preset small width.

Other than the aesthetics of a network with folded nodes, is there a reason why the node width doesn't automatically adjust to display the entire Name property?

Comments could tackle this somewhat, but only for one orientation: swapping orientation doesn't swap comment position, so putting comments on nodes in a horizontal chain makes it that much longer. https://forum.hise.audio/topic/9816/put-node-comments-above-below-nodes-when-the-container-is-laid-out-horizontally

One other thing: the change you pushed a few weeks ago where the Name property was introduced to prevent us from messing up ids, the node's core id has gone missing. So there's no longer a way to tell what is the base name of the node / node type. This is highly problematic for newbies that open existing snippets which have had the node names changed, and somewhat problematic for devs who have a small amount of RAM in their head and commonly find themselves in "what the fuck did I do here" situations.

Do you think adding a non-editable property that mentions the base node name (e.g. container.chain ) somewhere in the node properties window, perhaps right above the new Name property?

[Christoph Hart]

@aaronventure said in ScriptNode Feedback After a Month of Heavy Use:

So there's no longer a way to tell what is the base name of the node / node type.

The tooltip will show the type, ID and name if you hover over the header.

[Christoph Hart]

Alright, the folded (and unfolded) width should now take the length of the node name into account so it won't truncate it anymore.

[aaronventure]

@Christoph-Hart Amazing.

To recap this thread, the only unsolved issues from my original post remain:

• comment location in horizontally oriented nodes (though I understand if this would mess up node ordering as the cables run in the top and bottom)
• navigation (auto-scroll on screen edges while holding left click drag to modulation target)

From my wishlist, it's just:

• logic operators
• unscaled clamping
• variables (which you already laid out the plan for).

Everything else has been addressed, thank you.

[ustk]

@aaronventure @Christoph-Hart Couldn't the comments be shown in a floating tile when hovering a specific area/icon on the node?

[JulesV]

@aaronventure said in ScriptNode Feedback After a Month of Heavy Use:

If you have 200 nodes...

I'm sorry I'm new, but I'm trying to understand how something complex can be done with 200 nodes :)

In my first attempts, I worked with a maximum of 20 nodes :)

[griffinboy]

@Christoph-Hart
Oh hell yeah. Will it also work for when you enable the cpu usage label? That often gets cut off for me

[aaronventure]

@JulesV a lot of parameters driving a lot of mini-algorithms that all talk to each other. It adds up very quickly.

[Christoph Hart]

Alright, I spend a bit more time on the scriptnode UX front:

• added "variables". However I went against your objection and named them local_cables because I think that's exactly what they are. Variables would suggest that they store data, which isn't the case, they just forward any value you send into it (just like a normal cable does but without the serial killer vibes when you use them in a big patch). There are a few helper functions that lets you convert cable connections to local cable nodes and vice versa (and on compilation all local cables will be replaced by normal cables so I don't add complexity to the C++ builder). Docs are here
• added a toggle button for hiding all help texts and replace them with a comment button. If you click on the comment button next to the node it will expand the comment (and hovering over the comment button will show the first line of the comment as tooltip).
• changed the layout of the help with flipped containers to be below the node.
• added a few items to the DSP node list component (to the left of the network editor). Local cables are listed now at the top with the same appearance as global cables do in the global Patch browser.
• the root chain parameters are now also listed in the Node list alongside with a slider that you can use for quickly inspecting / changing the value, a label to rename it (double click!) and a drag element that lets you create connections
• parameters of a chain have now a fixed UI element for dragging to create connections. Before you always had to enable the weird edit mode (which is now solely used to delete parameters).
• added some funky drag animation because why not.

[ustk]

@Christoph-Hart Nice additions there!
I know it's already a real nice improvement, but I'd like to add two things:

• Adding a default value property to parameters for easy reset (double-click or modifiers). I miss this all the time when developing SNEX nodes, but with stock nodes too

• Make the zoom sensibility adjustable as it is a nightmare on mac. This has been asked a long ago already but I imagine it slipped through. This would probably be a global setting though because the story is the same with the Interface Editor

[Christoph Hart]

@ustk said in ScriptNode Feedback After a Month of Heavy Use:

Make the zoom sensibility adjustable as it is a nightmare on mac. This has been asked a long ago already but I imagine it slipped through. This would probably be a global setting though because the story is the same with the Interface Editor

Can you reference the forum topic where we discussed this? I can't remember it but for my the zooming works fine on macOS.

Adding a default value property to parameters for easy reset (double-click or modifiers). I miss this all the time when developing SNEX nodes, but with stock nodes too

Yes this is reasonable, it's not entire trivial because I have to account for the possibility of people changing the range so that the initial default value lies outside the limits, but nothing impossible.

[Christoph Hart]

Alright, double click to return works now. A few notes:

• it will be stored as separate property in the value tree
• if there is no DefaultValue property present (like when you load older networks) it will use the current value as default value
• when you save the network it will remove all DefaultValue properties that are equal to their value (so that the XML tree will not get poluted with too much redundant noise)
• There's a new item in the popup menu of the range editor that lets you store the current value as double click value (Set as default value)
• if you change the range so that it's doesn't contain the default value, the double click feature will be deactivated until you set a new default value that's in the range).