OpenGL ComboBox, And "NO" By Default

[Natan]

@Christoph-Hart Could You Please Give Me A Hint?

[orange]

@Natan said in OpenGL ComboBox, And "NO" By Default:

@orange Mate, Saw A Post From You, Here
Did you get This Going?

Since the only way to see this combobox is to set HISE_USE_OPENGL_FOR_PLUGIN=1 , the combobox setting will be "true" by default.

Also, CustomSettings Floating Tile can't be saved in a preset. The value is stored in the GeneralSettings.xml file of the project in appdata folder.

So firstly, you need to use HISE_USE_OPENGL_FOR_PLUGIN=1 and build the plugin with that.

Then in order to make the OPEN_GL="0" on the plugin start, you need to distribute the modified GeneralSettings.xml file (with OPEN_GL="0" modification) to the appdata folder. with the installer. So while installing the plugin, this GeneralSettings.xml file will be created before the plugin initialization and plugin will start with OPEN_GL="0".

[Natan]

@orange Thank A Ton Mate for Your Detailed Comment :folded_hands:

Yeah, I guess there's no Other way to Set it to No, on the other hand Having it On the FlotingTile.
So That is The Solution,
For now, I'll ship It With Yes, and Combobox On, And Note On Settings Page Regarding the Open Gl Option.

[Christoph Hart]

No just change the default value in the source code, no need to ship the modified xml.

[Natan]

@Christoph-Hart Thanks A Lot Christoph
Could you please Let me What Line?
And What Cpp?

[Natan]

Here >>>
https://github.com/christophhart/HISE/blob/e4b8330a3c6b19b333b3544e9f4f599f3ce9726d/hi_components/plugin_components/StandalonePopupComponents.cpp#L377

is Thi Correct?

[Natan]

@Christoph-Hart said in OpenGL ComboBox, And "NO" By Default:

No just change the default value in the source code, no need to ship the modified xml.

@Christoph-Hart No Idea Where it Located :/

[Natan]

No After A Few Hours, Still Can't Find Where It Located, There is Tons of OpenGL Command Lines On Source Code, And No Help Here :/

[d.healey]

Try standalonePopupComponents.cpp line 128 (in develop branch). Just removing the ! should give you what you want.

#if !HISE_USE_OPENGL_FOR_PLUGIN
	properties[(int)Properties::UseOpenGL] = false;
#endif

[ustk]

@Natan I just replied to your PM. As @orange said, it is OPEN_GL you want to look for. If you have searched with this exact string you would have found only one file (2 in fact, but the other one can't be related) with only 3 entries in it.

Unless @d-healey way is the best one? Haven't tried myself...

[Natan]

Excellent, Thank you guys @d-healey @ustk
I’ll give a try right now

[Natan]

@orange @ustk @d-healey
This is Excellent,
Just Removed The ! And Open Gl Popped Up On Floating TIle, With Value no

Thanks A Ton SIr David You're Rock :folded_hands:

Update: Compiled And works like charm on My Plugin.
And no need for extra Flag on Preferences,
It’s Disabled by Default

[ustk]

@Natan Cool!
although it might be better to just remove the statement and write:

properties[(int)Properties::UseOpenGL] = HISE_USE_OPENGL_FOR_PLUGIN;

Otherwise, it won't be set to false when needed the same way it was never set to true

[d.healey]

@ustk He want's the option there but he wants it set to false. I think your suggestion will set it to true

[ustk]

@d-healey Only if HISE_USE_OPENGL_FOR_PLUGIN has been declared true

[ustk]

@d-healey Nope sorry! You're right ;)

[d.healey]

@ustk Which it will be if he wants it to show up in the Settings tile, no?

[Natan]

@d-healey said in OpenGL ComboBox, And "NO" By Default:

@ustk He want's the option there but he wants it set to false. I think your suggestion will set it to true

Yeah, Sir David, You're Right.

And Added "GraphicRendering": true, into the CustomSettings Floating Tile.
And The Option Is There Also On Hise, Not Just Compiled Plugin, And It's Set To NO,
Just Tested, And Works Like A Charm

[ustk]

The combobox goes away as soon as you set DebugMode to false

Also, I don't see where adding GraphicRendering changes anything...

[Dan Korneff]

@ustk said in OpenGL ComboBox, And "NO" By Default:

The combobox goes away as soon as you set DebugMode to false

Was just doing some testing. At least one other item needs to be set to "true" for the OpenGL combo to appear.
After poking around a little, adding this to StandalongPopupComponents.cpp and trashing HISE preferences makes it work properly on my rig:

openGLSelector->setLookAndFeel(&blaf);