Installing Samples Dialog....

[Dan Korneff]

I'm trying to simplify the initial dialog for HISE plugins here. I checked out the HI_LookAndFeels.h but didn't see anything related to the "install" or "locate" buttons that show up on first launch.
I did, however, find the data in:
hi_components\plugin_components\FrontendBar.cpp
Line 50+

addAndMakeVisible(installSampleButton = new TextButton("Install Samples"));

I tried commenting this line out, but it removes the entire GUI from my plug when I compile.
@Christoph-Hart any hints?

[Christoph Hart]

@dustbro said in Installing Samples Dialog....:

I tried commenting this line out, but it removes the entire GUI from my plug when I compile.

Yes you are creating the object in this line and commenting this out will lead to a null pointer access later so you can be happy that it didn't crash.

Without going to deep into what you're trying to do, what you wanted to do can be achieved by putting

installSampleButton->setVisible(false);

somewhere after this line. I can't say whether this is helpful for your intentions though - what do you want to prettify exactly?

[Dan Korneff]

@Christoph-Hart said in Installing Samples Dialog....:

what do you want to prettify exactly?

I don't plan on using the HRx format for distribution, so I don't want to confuse the end user with access to a button to install them. All I need is 1 button to locate the sample folder on first launch.

[tomekslesicki]

Do I have to build Hise from source in order to remove the "Install Samples" button or can it be set before the VST export? And if it can be set before the export - how? I've added the line of code as @Christoph-Hart mentioned but it doesn't seem to do anything...

[d.healey]

@tomekslesicki Yes you'll need to rebuild from source

[tomekslesicki]

@d-healey Great, thanks!

[tomekslesicki]

Ok, I've added the "installSampleButton->setVisible(false);" under line 50 in the hi_components > plugin_components > FrontendBar.cpp and built Hise from source again, but the button is still there. What am I not getting?

[d.healey]

@tomekslesicki Is your project pointing to the correct HISE source code?

[tomekslesicki]

@d-healey Yeah, it is. I've just double checked, built Hise again, checked then, tried to export and the button is still there :-(

[Christoph Hart]

I've added a few compiler flags that decide what dialog to show. Just put these two in the Extra Definitions Windows / OSX properties of your project before compiling:

// If you want to hide the install button
HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=0

// If you want to bypass the entire thing and use a default location for the samples
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

[tomekslesicki]

@Christoph-Hart said in Installing Samples Dialog....:

I've added a few compiler flags that decide what dialog to show. Just put these two in the Extra Definitions Windows / OSX properties of your project before compiling:

// If you want to hide the install button
HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=0

// If you want to bypass the entire thing and use a default location for the samples
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

Tried that and still doesn't work :-(

[d.healey]

@tomekslesicki Did you rebuild HISE using the latest version from GitHub today?

[Christoph Hart]

And you need to make sure that HISE uses this source code for compilation (in this case rebuilding HISE doesn‘t make a difference)

[tomekslesicki]

I've re-downloaded the Hise source code, re-compiled, added the code to the project, exported again and the button is still there. He's a tough one, that's for sure!

[d.healey]

@tomekslesicki said in Installing Samples Dialog....:

added the code to the project

Could you clarify what you mean? Just so I understand the situation better.

[tomekslesicki]

@tomekslesicki said in Installing Samples Dialog....:

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=0

Sure! I meant I've added the "HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=0" line to Extra Definitions:

[d.healey]

@tomekslesicki Have you pointed the project to the correct version of the HISE source code?

[tomekslesicki]

@d-healey Yup, the one I've built from - downloaded from github, as you've suggested.

[d.healey]

Well I'm out of ideas... I haven't tested it myself yet.

[tomekslesicki]

@d-healey Did you get the "installSampleButton->setVisible(false);" thing to work, though? It doesn't work here either, unfortunately, but maybe you've succeeded with that?