set VoiceLimit of sine Wave Generator

[Chazrox]

@rglides i found something weird...

this script "works" kinda lol....but for some reason the value doesnt reflect visually on the module's text label.
If you paramter dump after each value change, you can see that it is in fact changing it.

try this and see what happens. Move Knob1 then close and open OSC1 module and you'll see it changes. I imagine you can figure out whats happening from that. Its kinda weird. Buggy??

const var OSC1 = Synth.getChildSynth("OSC1");
const var Knob1 = Content.getComponent("Knob1");


inline function onKnob1Control(component, value)
{
		
	local LimitNOW = OSC1.getAttribute(2);	
	if (value)
	{
		OSC1.setAttribute(2, value);
		Console.print(LimitNOW);	

	}
};
Content.getComponent("Knob1").setControlCallback(onKnob1Control);

HiseSnippet 1157.3ocyW0saaaCElx1LaVcKXsnWrKEB1EtCcAx4ulhfg4Dmjsf1jXDklsqVGsDkMWnH0jnxl2Pd21ixdD1av1gTxQxoNNtdsESAH.776GO7vuCcuDoOMMUlfrrOeTLEY8IXuQB0vtCILA5n8QVKiOljpnIN4h1aTLIMkFfrrp+sZAVMafLe+82rGgSD9zRQHzERlO8krHlpTZuNufw4GRBnmyhpX8FcNxWJ5J4xL.O0wtnXh+kjAzSHZypgQeGIcHx5KwqsVn+1ttau95a5RHqGPHazlt9yogaE5uo6ycC5uoK72VHqkNHfojIdJhhlhrZrmLXj2P4uJxSvErTVeNUunMxCxbt3Ck7.8VTKE0cHiGzabgJEgrv8JKa0yKaOFeLKfci7xx2mYT3T5Q0BnUsIgW8IfW66BdSARVUfTibH8PrmeBKVUpQimGfOR.mlgD3bpJTxsEU6qpg6JAKDpUiHWROLAVbiGs1x08oNv+dxN11vYUpx4JRhyodca670NlFmUGPUF3YV0ZEstU.yKs9EBYes4iSi1AYTrT.KZshQq1AaalfyDTmvLguhIENRgQo1uDIuk+XmdJDVdF8I1+gcyl1M4ReB2wzycxoeOjHMDzYYWkJg0OSQasxZPF.SYgNsJ7so1Yiko2xxwgeGv.H2oRNc03DF.1w4vDqlFvsp+PhX.MnkQ101Wui8L2m5rUrg5R379PCeqI2m5RQkRvIRE8TQKyl09ZamaqJLbp5JBFmlLU05KhIyxwVhrn9zjpkZsgPy1jcvKMecv940jJFJEGIXpSioEqm8UPTQQU24WfPvTkoue4h9dONKflfXPP9HrohhLf+FBGmepC5UGsOQQFGFHhPVhoIJldyXsO8Jf9J+5TS79zzKUxXisEmiPnu2j9a2jv+Jpynxr+ychXAAbZOYJSWrKIB+wN.garG62g.iwsW0EEQJiBJtC5MusC7LxfLNQMI4ilhtPgNEUuwquUKfTOpJE9aAij6LYjlWH9PbOlxe3zwXsofQ3r58AFK3w+T7AggTeUI.afO7GVTR64O8Kmm9Gf8.JOC0oI4Kg0TR28P2+7hNy2PWnWedF5ZiCCCWKH.ZaO0WQthddBQjFKSmH9dzH14P+eZUguJEFVP+kyzGhU6n5JII2gpCg85TT.IfnxRLcC6FIyDpIN8qOqQ52IiyjWDpX+TFl138078FyWqx8v88++K+S7bjliwnGKJlSOPbEkCbrFL9HfTMjjwUikNYu9wRgLdnTv7q1AbFElNOX.MoJ1m5FBliCCTKk73NmQ4TR0t4unyKgtPRBTmnKXs3s+oYS875yw4v0QeA04+x41Gz1rYRfWetHvemi2EmL+cCTNSloXhAGSfFUXvM9jrHOfe0mBHQHnbHQXqZ5mwju1UuNmYUDXV7OvWgx150VEJaOV4GjbDQ7Sju1O+AV5d4O1HA12ByOIqI7aCg0N29kUvG71F1q88mLTugiqsnNt9h53FKpiatnNt0h53yVTG299cTOzZ2LkLJ+JKBcbuCLuD1x5.AA53M2NP+KTMLew.

If I chang the knob while im playing, I can tell its working because if you go from 1 voices to 3 you can hear the polyphony changing.

[rglides]

@Chazrox oh!! so it does! Thanks man!

[Chazrox]

@rglides Yeet!

[Chazrox]

@rglides just remove the .changed();. not needed, I was being hacky. lmao

[rglides]

@Chazrox hehe hackerman to the rescue. Getting weird audio glitches in the generators now, not sure it's related, will keep playing around

[rglides]

@rglides Ah it's cos I set the saturation to max when testing earlier. All good, this really helps, thanks again!

[Chazrox]

@rglides lol.

I think Voice Limit does falls into the category of one of those features that cause zipping if you adjust in real time.

[Chazrox]

@rglides oh SWEET! so its not what I said. Thats great news. haha.

[rglides]

@Chazrox that could be true, I know setting to 1 probably isn't a good idea too. But no, I was getting some really strange sounds cos of the max saturation for sure - EDIT changing in real-time sounds fine actually, very smooth

[Chazrox]

@rglides I was just playing with it and it doesnt have a problem with zero even so I really dont know. hahaha

[Chazrox]

@rglides shiiid. You're all good then!

[rglides]

@Chazrox oh interesting, yeah I would have thought that'd be some kind of mute hack but nope

[d.healey]

@Chazrox said in set VoiceLimit of sine Wave Generator:

Voice Limit" is paramter [2]

Avoid the magic number, use the parameter name instead OSC1.VoiceLimit

[Chazrox]

@d-healey ah, are these the proverbial "magic numbers" I hear about? It worked either way, I just chose the short version obviously thinking it was better. Thank You!

[d.healey]

@Chazrox Yeah a magic number means you're using the value of a constant instead of the constant itself. So to anyone else looking at your code - or you in the future when you've forgotten what your code does - they just see a number that magically does something but have no idea what it refers to.

[Chazrox]

@d-healey That makes sense. Now I know wth that means. haha Ty. Hope all is blessed!

[rglides]

Yeah it's true, I did update to this

inline function onknb_OSC1_VoiceLimitControl(component, value)
{
		OSC1.setAttribute(OSC1.VoiceLimit, value);
};
Content.getComponent("knb_OSC1_VoiceLimit").setControlCallback(onknb_OSC1_VoiceLimitControl);

but it was very helpful to discover that the function was always working, just not updating in real-time in module window, so the help was massive edit: 'update' I mean revert hehe

[dannytaurus]

@d-healey It would be even better if instead of this:

OSC1.setAttribute(OSC1.VoiceLimit, value);

we could do this:

OSC1.VoiceLimit = value;

but I'm guessing that's too dynamic (or something) for C++?

[d.healey]

@dannytaurus OSC1.VoiceLimit is a constant with a value of 2. So what you're suggesting wouldn't work.

[dannytaurus]

@d-healey Yeah, it's quite different to what I'm used to in Ruby and Rails.