Note Release - randomly gets stuck

[Lindon]

@audiolyf said in Note Release - randomly gets stuck:

@Adam_G I will try it out on FL Studio later too, turns out Pro Tools is just stuck note hell in general.

Yeah I have users reporting this occasional problem - especially in ProFools...

[audiolyf]

@Lindon Do you have anything in place at all to prevent it? It's completely unusable imo, any time you stop the transport in the middle of a note it hangs and the plugin must be bypassed/unbypassed. Read some rumor about Pro Tools not using note-offs and instead translating it to velocity = 0 but I have no idea if that's true, it doesn't seem to make any difference having a sample map blank at 0 velocity. It's driving me nuts.

[Lindon]

@audiolyf

well this seems to help a bit...

const var th = Engine.createTransportHandler();

inline function onStop(isPlaying)
{
    if(!isPlaying)
    {
       Engine.allNotesOff();
    }
};
th.setOnTransportChange(true, onStop);

[d.healey]

@audiolyf said in Note Release - randomly gets stuck:

I will try it out on FL Studio later too, turns out Pro Tools is just stuck note hell in general.

Are you testing with the snippet and MIDI that @Adam_G posted?

[Adam_G]

@d-healey the midi really doesnt matter because it happens with any midi i use. i have quite a bit.

[Adam_G]

@Lindon said in Note Release - randomly gets stuck:

@audiolyf

well this seems to help a bit...

const var th = Engine.createTransportHandler();

inline function onStop(isPlaying)
{
    if(!isPlaying)
    {
       Engine.allNotesOff();
    }
};
th.setOnTransportChange(true, onStop);

@Lindon added this to my oninit but still happening unfortunately. should it be somewhere else?

[Lindon]

@Adam_G nope thats where it goes - it will help for held notes when the transport is stopped only...

[Adam_G]

@Lindon ah 10-4 thank you

[d.healey]

@Lindon Does it need to be in an undeferred script?

[Lindon]

@d-healey it is for me, but really the major issue here is these stuck notes in some DAWS (ProFools and FL Studio for a kick off..)

[Adam_G]

@Lindon said in Note Release - randomly gets stuck:

@d-healey it is for me, but really the major issue here is these stuck notes in some DAWS (ProFools and FL Studio for a kick off..)

abelton and cubase as well apparently :face_with_head-bandage:

[Lindon]

@Adam_G okay so here's a simple little trial - its trying to capture any

Velocity == 0

events and turn them into "real" note off events - try this with your midi file...

HiseSnippet 1479.3oc0X0raabCDdWKsoQJMAMAFE8HqQNHi5HK47SKZga7exABwN1wxwo2Ro1cVIBuK4VtT1QnH.4MnmxgbquC8ROFza8VeBJ5iPeAJZGtq9gahjijhS.pNHHxYFxu4+gZeovEhiERK6BG1MBrr+XmFc4p1a1lx3V02xx9hN6KgXPYsQ2HZbL3YYam6dZp1Exak74uu6Fz.J2EFtkk0QBlKrCKjoFt69qceVPv1TO3PVnA22Zs5tB9lh.QGDI4bpXEQcOl1Bd.Uy1bNV1WnlGSIjMTTEDaYmeCgW2FsEmxS4+HVLqY.nWT0pAdPoausHvSiX8tVa1lE3seeMN1xx1Y+g5etT8edmcYdrA6OzN7IIDHCkvzdXOWV3kKC7pZBuJFvaDPx1.R4SgzUcZ3JYQpgTz34RN04JP5SQytITR40ZteIuylBjCtpbH8XXaItXfDkt0sqrDYkaWYwuoXQzzGqHmPkDtPAGJQSOHIqRpwaw3PYWIfJkV42gEqJgRXvVYezgV5FUydN6PaBAUwinOBZApMEgQBNtnzBojWPKieGtqhI3DA+A3otGuzhE+whEX9jR6h5JFBnk8HHP3xTcKsH4aIUVrXAjEjmRl.QyFMnCXJm9HePmvlfrzhKR97UIHPQI0RWX4kaGFRBERfnZS0..RzeRSfwaQhBncAOBUgTARLFGRTXLa4xox1DTnojDqDQIL31QJQcKnahf5CPeVZdSRmJqWsmu+FcqcBxVcuoC5nkpPgmo+Z4kEGShEDI3Jjd3UyhSQMMNCvKm.TyKI9sbIKYreePldwEK7rhEz9jw3RVc0A9jkWlbZaAcIRa.sqmBjVBxVq+XRLv8zfKFiV5RNAjwnOOlH7SAuv2OAuuytThuPRnY7A3WbHwGEfmRpc47yoLcl3j7DTnzD.M+kVPAOUsvRjERLSn4AS4hiI.2UzQmsl3JKqUqTkI4n95EHeAYb3JIVQ6ydVQxqmd46mleM8nN6goyqkhf.Mc848Zj0U2GMkdBVJUOVBqVf27.FwRdYqi5L95nlk4cSKyXvnfWmyT6EA7wU72pWsIrlatdnB+kJoh6U5UwsQ.yCjVLrv5G4betnYUqD.2qy02+S+1+bWqIV3UxH7O+xW96Sgv2Liv+0C+0+7tVOp9VTEU2znmtf5WDHULsoydK3DrCbZKjBNaAwGiEqPK7fBwXu82p59zgMou9ZcGr34GsVn4D.y+pPpAqyuVTeKcc7v9TmFXTM4wzS.x8.NHonKtJ1iWhkUwXbMOW0YOWEx.FUxiiDwf1AMw.cESf5cF.sTVfVZ5A5kbZ.grCQfEmAhW3s5.GduuRlEhSMHtlSCppCRAypVOTWoXTlqK2CKIkaRfxEcRK8Xfkm+PCrf1tSYdp1Xlm8crsrZCrVsU5UyiD0kpRlFqYq9ypU3Bu3EuX0zg6diAWvQlDdcBz32bNJ8vi8HfvOyvK5AT3wXaEygKO2FtZRg3Uc1mobaOZLN2HvHlB99.i8FI8xN078AW0P.l2Y6u68y7mlW+URu9KkDOlzwL4xGS743edveLoOOHZhedvqWqvHZYX1ows8nXb.X3GNP6MM2eSAUNFRaiJ4HI7FYdFkjsycVOSo5L9Lk7uudlR9IKL4rg2+CR7y7ppB8wXCVXT.TieBNJKtiFiWC6S5S6Dn5ua135cEbQTaAm4ZFPb.njrVs.oI1GoBstRgybY1m7.H.nlAvWescv.OpDsSvLZKpN0uvbj9qOyIEtDcxH4cwu8AML6LKdmahJdeti2YuP94CTNPzQguGZWJFnhc9cvQ6af0RcADIbNDnmz1dNc8vz0UzqSp0guaKYw+he5QrpdscOhU6S7CxcDRckhm3lNyrNV9hI6f5MO4OJpfyt50jAio63TobEqPrh3Sbc0l6af1mQKyJyfL2bFj4VyfL2dFj4NyfLe4LHyWclxnaFsdGkHLMUD2X+ZIOZw1tFmhQxIQ8V+Gv2VnpH

[Adam_G]

@Lindon thanks for the help. just tested it in fl studio and its still happening :(

[Lindon]

@Adam_G well its not velocity == 0 events then...

[Lindon]

@Adam_G so when you say this:

"periodically while the exported vst is playing back midi in the daw a single note will get stuck and play for an extended time with no release. it seems to mostly happen with c5 and f5 for whatever reason"

this stuck note, it plays "forever"? i.e. it never gets a note off? Or it stops at some point? randomly? When another of the same note is triggered? when?

[Adam_G]

@Lindon it doesnt play forever. sounds like it holds it for a bar or so, maybe less but it seems to be the same amount of time each time and it plays over the other notes.

[Adam_G]

tested the snippet (both my original and the one @Lindon provided) in bitwig and the issue doesnt occur. at least not during my testing. strange

[Adam_G]

Ive confirmed this is indeed a bug in newer (2023) versions of Hise and it also effects the Sampler. Everyone using 2023 (as of right now) versions will experience this issue.

I replaced the Sine Wave Gen in my snippet with a sampler and it still happened, so I exported the same project with a Hise build from May of 2022 that I still have and the issue does not occur.

This is massively frustrating because the main project im building which i have spent tons of time on requires the newest Hise build to work properly because of SNEX.

But whats the point in using Hise if @Christoph-Hart is going to go silent when its broken? :(

[d.healey]

@Adam_G Find the commit that introduced the issue, that will make it a million times easier to fix.

[Adam_G]

@d-healey i can try but i might be compiling all night