Note Release - randomly gets stuck

[Adam_G]

@Lindon ah 10-4 thank you

[d.healey]

@Lindon Does it need to be in an undeferred script?

[Lindon]

@d-healey it is for me, but really the major issue here is these stuck notes in some DAWS (ProFools and FL Studio for a kick off..)

[Adam_G]

@Lindon said in Note Release - randomly gets stuck:

@d-healey it is for me, but really the major issue here is these stuck notes in some DAWS (ProFools and FL Studio for a kick off..)

abelton and cubase as well apparently :face_with_head-bandage:

[Lindon]

@Adam_G okay so here's a simple little trial - its trying to capture any

Velocity == 0

events and turn them into "real" note off events - try this with your midi file...

HiseSnippet 1479.3oc0X0raabCDdWKsoQJMAMAFE8HqQNHi5HK47SKZga7exABwN1wxwo2Ro1cVIBuK4VtT1QnH.4MnmxgbquC8ROFza8VeBJ5iPeAJZGtq9gahjijhS.pNHHxYFxu4+gZeovEhiERK6BG1MBrr+XmFc4p1a1lx3V02xx9hN6KgXPYsQ2HZbL3YYam6dZp1Exak74uu6Fz.J2EFtkk0QBlKrCKjoFt69qceVPv1TO3PVnA22Zs5tB9lh.QGDI4bpXEQcOl1Bd.Uy1bNV1WnlGSIjMTTEDaYmeCgW2FsEmxS4+HVLqY.nWT0pAdPoausHvSiX8tVa1lE3seeMN1xx1Y+g5etT8edmcYdrA6OzN7IIDHCkvzdXOWV3kKC7pZBuJFvaDPx1.R4SgzUcZ3JYQpgTz34RN04JP5SQytITR40ZteIuylBjCtpbH8XXaItXfDkt0sqrDYkaWYwuoXQzzGqHmPkDtPAGJQSOHIqRpwaw3PYWIfJkV42gEqJgRXvVYezgV5FUydN6PaBAUwinOBZApMEgQBNtnzBojWPKieGtqhI3DA+A3otGuzhE+whEX9jR6h5JFBnk8HHP3xTcKsH4aIUVrXAjEjmRl.QyFMnCXJm9HePmvlfrzhKR97UIHPQI0RWX4kaGFRBERfnZS0..RzeRSfwaQhBncAOBUgTARLFGRTXLa4xox1DTnojDqDQIL31QJQcKnahf5CPeVZdSRmJqWsmu+FcqcBxVcuoC5nkpPgmo+Z4kEGShEDI3Jjd3UyhSQMMNCvKm.TyKI9sbIKYreePldwEK7rhEz9jw3RVc0A9jkWlbZaAcIRa.sqmBjVBxVq+XRLv8zfKFiV5RNAjwnOOlH7SAuv2OAuuytThuPRnY7A3WbHwGEfmRpc47yoLcl3j7DTnzD.M+kVPAOUsvRjERLSn4AS4hiI.2UzQmsl3JKqUqTkI4n95EHeAYb3JIVQ6ydVQxqmd46mleM8nN6goyqkhf.Mc848Zj0U2GMkdBVJUOVBqVf27.FwRdYqi5L95nlk4cSKyXvnfWmyT6EA7wU72pWsIrlatdnB+kJoh6U5UwsQ.yCjVLrv5G4betnYUqD.2qy02+S+1+bWqIV3UxH7O+xW96Sgv2Liv+0C+0+7tVOp9VTEU2znmtf5WDHULsoydK3DrCbZKjBNaAwGiEqPK7fBwXu82p59zgMou9ZcGr34GsVn4D.y+pPpAqyuVTeKcc7v9TmFXTM4wzS.x8.NHonKtJ1iWhkUwXbMOW0YOWEx.FUxiiDwf1AMw.cESf5cF.sTVfVZ5A5kbZ.grCQfEmAhW3s5.GduuRlEhSMHtlSCppCRAypVOTWoXTlqK2CKIkaRfxEcRK8Xfkm+PCrf1tSYdp1Xlm8crsrZCrVsU5UyiD0kpRlFqYq9ypU3Bu3EuX0zg6diAWvQlDdcBz32bNJ8vi8HfvOyvK5AT3wXaEygKO2FtZRg3Uc1mobaOZLN2HvHlB99.i8FI8xN078AW0P.l2Y6u68y7mlW+URu9KkDOlzwL4xGS743edveLoOOHZhedvqWqvHZYX1ows8nXb.X3GNP6MM2eSAUNFRaiJ4HI7FYdFkjsycVOSo5L9Lk7uudlR9IKL4rg2+CR7y7ppB8wXCVXT.TieBNJKtiFiWC6S5S6Dn5ua135cEbQTaAm4ZFPb.njrVs.oI1GoBstRgybY1m7.H.nlAvWescv.OpDsSvLZKpN0uvbj9qOyIEtDcxH4cwu8AML6LKdmahJdeti2YuP94CTNPzQguGZWJFnhc9cvQ6af0RcADIbNDnmz1dNc8vz0UzqSp0guaKYw+he5QrpdscOhU6S7CxcDRckhm3lNyrNV9hI6f5MO4OJpfyt50jAio63TobEqPrh3Sbc0l6af1mQKyJyfL2bFj4VyfL2dFj4NyfLe4LHyWclxnaFsdGkHLMUD2X+ZIOZw1tFmhQxIQ8V+Gv2VnpH

[Adam_G]

@Lindon thanks for the help. just tested it in fl studio and its still happening :(

[Lindon]

@Adam_G well its not velocity == 0 events then...

[Lindon]

@Adam_G so when you say this:

"periodically while the exported vst is playing back midi in the daw a single note will get stuck and play for an extended time with no release. it seems to mostly happen with c5 and f5 for whatever reason"

this stuck note, it plays "forever"? i.e. it never gets a note off? Or it stops at some point? randomly? When another of the same note is triggered? when?

[Adam_G]

@Lindon it doesnt play forever. sounds like it holds it for a bar or so, maybe less but it seems to be the same amount of time each time and it plays over the other notes.

[Adam_G]

tested the snippet (both my original and the one @Lindon provided) in bitwig and the issue doesnt occur. at least not during my testing. strange

[Adam_G]

Ive confirmed this is indeed a bug in newer (2023) versions of Hise and it also effects the Sampler. Everyone using 2023 (as of right now) versions will experience this issue.

I replaced the Sine Wave Gen in my snippet with a sampler and it still happened, so I exported the same project with a Hise build from May of 2022 that I still have and the issue does not occur.

This is massively frustrating because the main project im building which i have spent tons of time on requires the newest Hise build to work properly because of SNEX.

But whats the point in using Hise if @Christoph-Hart is going to go silent when its broken? :(

[d.healey]

@Adam_G Find the commit that introduced the issue, that will make it a million times easier to fix.

[Adam_G]

@d-healey i can try but i might be compiling all night

[d.healey]

@Adam_G Compile debug builds. It shouldn't take too long to find the commit.

Start with a commit half way between May 2022 and now.
If the bug isn't there try one half way between that commit and now.
If the bug is there then try a commit half way between May 2022 and that commit.

Some commits will fail to build, if that happens you can try cleaning the build folder, if it still fails then move on to another commit.

[Adam_G]

@d-healey thats a good idea, ill give it a shot

[Christoph Hart]

Yeah, please do that binary tree checkout logic that David suggested.

I'm not sure what could have caused that because I haven't worked too much on the voice allocation logic in the past year.

[Adam_G]

this is the result of my testing

Master Oct 28 2022 - Does NOT have issue
Master Oct 29 2022 - Compile error
Master Oct 30 2022 - Compile error
Master Oct 31 2022 - Compile error
Master Nov 1 2022 - Compile error
Master Nov 2 2022 - Compile error
Master Nov 3 2022 - Compile error
master nov 4 2022 - Compile error
master nov 5 2022 - Has issue
master nov 14 2022 - Has issue
master nov 26 2022 - Has issue

each day has multiple commits but i used the top one in each so nov 5 was commit a8a6948 and oct 28 was commit 98736f0

im compiling in vs 2022 on windows 10

does that help?

[d.healey]

@Adam_G What buffer size are you using? And does changing it make a difference?

[Adam_G]

@d-healey 512 but lowering to 128 just now didnt make any difference

[d.healey]

@Adam_G I don't see anything obvious in those commits (hopefully Christoph will spot something). The only one I saw that seems slightly related is https://github.com/christophhart/HISE/commit/7955b78dd5e3f297098eda89767ed4e334cbfc7e