Note Release - randomly gets stuck

Adam_G

this is the same issue reported by @yall in this post https://forum.hise.audio/topic/7019/note-release

periodically while the exported vst is playing back midi in the daw a single note will get stuck and play for an extended time with no release. it seems to mostly happen with c5 and f5 for whatever reason

some info:

DAWs tested: fl studio and cubase, also tested in reaper per @d-healey instruction and the issue does not occur

issue occured with both a sampler and sine wave generator. with the latter it occured in a completely empty project with ONLY a sine wave generator in it.

the issue does not occur in hise. it does not occur when midi is being played within the vst either with a keyboard or midi player. it only occurs when the exported vst plugin is playing midi in the daw.

im using the most recently posted Develop build of hise as of 18/4/23

@Christoph-Hart could you please look into this and verify if there is a bug?

Adam_G

also is there anyone else having this issue? @yall and i cant be the only ones haha

clevername27

@Adam_G Does it happen with other virtual instruments? Stuck notes are very common when using hardware controllers with virtual instruments.

Adam_G

@clevername27 no as i mentioned the issue only occurs when midi is being played in the DAWs piano roll and is isolated to this vst

well, this vst and the sine wave generator i exported for testing. clearly this is a new bug within hise

clevername27

@Adam_G Huh. Are you dealing with note-offs in the UI or Real-time thread?

Adam_G

@clevername27 i actually dont have any code in the note off, but the sine wave generator having the same issue doesnt have any code at all.

if you use fl studio i recommend trying it. export a vst with only a sine wave generator and no code, then in the piano roll add a few c5 and f5 notes. let it play for 2-3 minutes and you will hear notes will stick. that cant be related to the project or hardware

Adam_G

i would love to hear from @yall and if they ever resolved or found out the cause of this issue

Adam_G

2 seconds from making a post with an annoying youtube clickbait title just to get some feedback here lol.

could any fl studio studio user out there test this to see if they get the same issue at least? here is a snippet and demo midi. all you have to do is export it as a vst then let the midi play for a minute or 2 and see if you hear a note that plays longer than the rest. its pretty noticeable.

HiseSnippet 1009.3ocyW0raaaDDdokVWK61f3.ihdjGxAEfz.IG6l.zCQ1xRABI1VvzIsnWBVSNxZgI2kc4R2JDj2M+HjGk7FjNKoj4pDJYYkeP4ItyOb+lY+1YF1WI8gjDoh3T6zQw.w4GodiD5gsGx3BRuCHNqQ6qfDPS1eTLKIABHNNUdtQqSspjrmO7r8YgLgOTHhPdsj6CujGw0ER625E7vvtr.3Tdjk06zpmuTzVFJSQjTg1fDy7ufcNbDyX1JThypcB3ZoxSyzPBwo59xfQdCk+iH29WyS3mEBlEMId3GJWbWYXfAwFoj1C4gA8mDwIDhCseQ7WIO92hdHOfes7h7vcyT3V3gc9vYkogWkofWyYAuRfjiEjplCoMod9JdrtPiAOaP6IzfZ.CS61PI2VhyUz1Rz.g9QQrKftJbw0NTemca7P2s2swC98AoBeMWJbkhijZ3XQ8Gr9aWu15uac2OU0fAkpyrMJYXHnJUs4jVMOGqKRiNCTOz8RVXJbsgX3OcNc0EKm5mG0VFJE8Db8wwv30ymTPFm1vyhJiQH9lN6j3NiOI7B4AfhvwOxOPegPdVSRF3s4+jE14s+Rb9wk37q5c.SyLjowwBFewfRyMoQmCfKwal4TqZzCfjKzx3rfMJVJLQtyZ2X39uEa38aMBuI47W3qQ1UE15pHlkYa0JdRVtG9g9YpGW.t+A6Rv84f.TL7ntIduWgW4QZpwlMoG6qQCNUwDIwxDvjWVXPtsMHClAHqOMHqe6A4FTOHheJBpjof2p23AWw9dkp.d2Z.bOpGSmhZvaU6EISMT2OuHBV9RFjFZ72tlloP9XEn6SUHwTsPjv0irKzeKJz0XtE5VTHtIsOW6OrbLtRIXDo8eKv331C+DsyfAfut.fUoc+yksWvhu82Ie62HiOj0gNaymA+X1spe+h1pNdgaU+o2Qs9vE2LrD9pDraD72mXNMsk2VxTkp5COqKFjk5ymw7soAUl2HCyr+wz2Hrrujl0U+VM+P0EiybCcx9+eUfoF2o1DL5wihCgNhKgPruUFFuG1nZ.KMTOQ5zj7CkBY7Pof6ay.NAzJ94mCJarWZ.smViCbZ2r5DHDX1r4625kHKjov7Drj4ha+nekdd8Kzb35ZtY59kbt8cklM2J4UVnJ4e0w6xWU+qCTNQlp4hyOjgDUbb.5QoQdXgUe.QhP.gIloBVwTbLecCy57JqhfrEeDeFqroYsyXkMmn76xdDw7Ux23mOzpgKuVlDLtEY+AWM5gl0tWOmLk13QMvQwB3uw22jt+UL+TtOauD973kvmcVBe1cI742VBedxR3ySmqOllQ6kpkQ4WEQA86j8WCNNcDLjImw5I+GSIEOoB

any midi will work but here is one that i know for sure produces the bug

https://www.dropbox.com/s/gp95ijo69yxa4sz/test mid.mid?dl=0

audiolyf

Happens in Pro Tools as well

Adam_G

@audiolyf thanks for checking.

@Christoph-Hart you have 3 separate users with 3 different daws all reporting the same issue. clearly this is a bug in Hise. could you at least acknowledge if youre looking into it or not? youve been silent on this one :downcast_face_with_sweat:

trillbilly

@Adam_G I've had this happen in Ableton, FL as well as within HISE itself. Never figured out why or how it was happening.

audiolyf

@Adam_G I will try it out on FL Studio later too, turns out Pro Tools is just stuck note hell in general.

Lindon

@audiolyf said in Note Release - randomly gets stuck:

@Adam_G I will try it out on FL Studio later too, turns out Pro Tools is just stuck note hell in general.

Yeah I have users reporting this occasional problem - especially in ProFools...

audiolyf

@Lindon Do you have anything in place at all to prevent it? It's completely unusable imo, any time you stop the transport in the middle of a note it hangs and the plugin must be bypassed/unbypassed. Read some rumor about Pro Tools not using note-offs and instead translating it to velocity = 0 but I have no idea if that's true, it doesn't seem to make any difference having a sample map blank at 0 velocity. It's driving me nuts.

Lindon

@audiolyf

well this seems to help a bit...

const var th = Engine.createTransportHandler();

inline function onStop(isPlaying)
{
    if(!isPlaying)
    {
       Engine.allNotesOff();
    }
};
th.setOnTransportChange(true, onStop);

d.healey

@audiolyf said in Note Release - randomly gets stuck:

I will try it out on FL Studio later too, turns out Pro Tools is just stuck note hell in general.

Are you testing with the snippet and MIDI that @Adam_G posted?

Adam_G

@d-healey the midi really doesnt matter because it happens with any midi i use. i have quite a bit.

Adam_G

@Lindon said in Note Release - randomly gets stuck:

@audiolyf

well this seems to help a bit...

const var th = Engine.createTransportHandler();

inline function onStop(isPlaying)
{
    if(!isPlaying)
    {
       Engine.allNotesOff();
    }
};
th.setOnTransportChange(true, onStop);

@Lindon added this to my oninit but still happening unfortunately. should it be somewhere else?

Lindon

@Adam_G nope thats where it goes - it will help for held notes when the transport is stopped only...

Adam_G

@Lindon ah 10-4 thank you

Note Release - randomly gets stuck

25

1.9k

10.7k

93.0k