Major Issue with Split Node in Scriptnode
-
@Casey-Kolb And can you pinpoint it to a certain host / OS combination apart from Bitwig and Cubase (I don't have those to test).
-
@Christoph-Hart I can set you up with a Virtual Machine that has cubase/bitwig for you to test with.
-
@Christoph-Hart Bitwig has a free trial you can use, same with Cubase I think. We also had reports that it happens in Logic and Ableton Live on certain machines, but Bitwig and Cubase were more consistently reproducible. I'll let you know if there are more – I'm assuming it's broken in FL Studio too because...well...everything is always broken in FL Studio
-
same with Cubase I think.
Yeah, no.
I can set you up with a Virtual Machine that has cubase/bitwig for you to test with.
Thanks, but I think setting up the remote debugger is more pain than installing the bitwig demo :)
-
@Christoph-Hart I have good news: Wrapping the split in a frame container seems to have fixed the issue. What does the frame container do?
-
@Casey-Kolb It processes the child nodes one sample at a time. This is not a "fix" as it will vastly increase the CPU usage, but it shows me that there is something wrong with the block processing code in the split container.
I'm compiling the example as FX plugin to load into Bitwig, so let's see if I can find anything.
-
@Christoph-Hart Noted. For a basic bitcrusher effect I'm assuming this won't be an issue temporarily?
-
@Christoph-Hart said in Major Issue with Split Node in Scriptnode:
same with Cubase I think.
Yeah, no.
Try Cubase 14 free for 60 days
Sign up for free to try all music production features of Cubase.
(www.steinberg.net)
-
Start your free 30-day trial version
We're way past that :)
Anyways, I've fired up bitwig and it seems to play back fine, the only thing I'm noticing is that if I switch the audio driver to generic, it will use 441 samples as buffer size (here we go again), and this leads to some crackle noises on the right channel. I'll investigate more, but which buffer size are you using on Bitwig?
-
Alright, forget all DAWs:
HISE -> Tools -> Simulate varying buffer size
Add the compiled bitcrusher code => complete mayhem.
Nice job HISE, you magnificient debugging beast!
-
Alright, it's fixed. It was indeed an issue where the split container expected a full buffer length so when a buffer with something less than this is processed, it started pointing to uninitialised memory which resulted either in silence or (worse) junk signal.
-
-
@Christoph-Hart Woohoo! Thank you
-
@Christoph-Hart Will confirm on our end after merging.
-
@Casey-Kolb The fix with the commit was incomplete (forgot to check HISE compilation), so make sure you pull the latest state.
-
@Christoph-Hart Back in business
Works without frame container now. -
@Christoph-Hart said in Major Issue with Split Node in Scriptnode:
Alright, it's fixed.
You're awesome!
@Casey-Kolb Nice catch
-
@Matt_SF said in Major Issue with Split Node in Scriptnode:
@Christoph-Hart said in Major Issue with Split Node in Scriptnode:
Alright, it's fixed.
You're awesome!
@Casey-Kolb Nice catch
+1
-
Since pulling in these changes, when I try to compile the effects as DLL I get the following error:
could this be related to the latest commits?
-
@Jlev777 Oops, I forgot to fix this line. Please try again, should work now.
