Expansions & Favourites

[DanH]

Should favourites be working in Expansions (in the Preset Browser)? Cos they aint here...

[Dan Korneff]

@DanH I'm experiencing the same

[d.healey]

Yep, just discovered this bug too. Has anyone reported it on github yet?

[DanH]

@dustbro yep favourites and next / previous preset buttons are the two things I’d to see work.

[d.healey]

@DanH Do you mean you want preset next/previous to change expansion? I think that's something you'd have to handle from script.

[DanH]

@d-healey no I want it to change preset within an expansion - this has been discussed before. Christoph asked for a minimal project which I haven’t got round to making.

[d.healey]

@DanH

no I want it to change preset within an expansion

Oh, I didn't know that didn't work

[DanH]

@d-healey I'm pretty sure you do. Seem to remember you in the conversation

[d.healey]

@DanH I've been to sleep since then :)

[d.healey]

@Christoph-Hart I've tried looking into this today but I don't quite understand how the preset database stuff works.

The problems are:

The favourite buttons for presets in expansions don't work. When you press the button nothing happens and when you go back to a non-expansion presets afterwards and press their favourite buttons nothing will happen either. You have to restart HISE to get it to work again for non-expansion presets. Solved!

The search bar only searches in non-expansion presets or the presets of a currently loaded expansion, it doesn't allow you to search all presets from all expansions.

@DanH Also mentioned the load next/prev preset won't cycle through expansions - actually this is the behavior I'd prefer but I can see why it would be good to have it go through expansions in some scenarios. So if you do change this, make it optional :)

Here is a test project: ExpansionPresetsDemo.zip

[d.healey]

Aha I think I'm getting somewhere!

Pushed to this branch/PR - https://github.com/christophhart/HISE/pull/368

I think I know what needs to be done for getting the search working across all expansions. It looks like it will require some brain power though so I'm not going to tackle it today.