Expansions & Favourites

[DanH]

Should favourites be working in Expansions (in the Preset Browser)? Cos they aint here...

[Dan Korneff]

@DanH I'm experiencing the same

[d.healey]

Yep, just discovered this bug too. Has anyone reported it on github yet?

[DanH]

@dustbro yep favourites and next / previous preset buttons are the two things I’d to see work.

[d.healey]

@DanH Do you mean you want preset next/previous to change expansion? I think that's something you'd have to handle from script.

[DanH]

@d-healey no I want it to change preset within an expansion - this has been discussed before. Christoph asked for a minimal project which I haven’t got round to making.

[d.healey]

@DanH

no I want it to change preset within an expansion

Oh, I didn't know that didn't work

[DanH]

@d-healey I'm pretty sure you do. Seem to remember you in the conversation

[d.healey]

@DanH I've been to sleep since then :)

[d.healey]

@Christoph-Hart I've tried looking into this today but I don't quite understand how the preset database stuff works.

The problems are:

The favourite buttons for presets in expansions don't work. When you press the button nothing happens and when you go back to a non-expansion presets afterwards and press their favourite buttons nothing will happen either. You have to restart HISE to get it to work again for non-expansion presets. Solved!

The search bar only searches in non-expansion presets or the presets of a currently loaded expansion, it doesn't allow you to search all presets from all expansions.

@DanH Also mentioned the load next/prev preset won't cycle through expansions - actually this is the behavior I'd prefer but I can see why it would be good to have it go through expansions in some scenarios. So if you do change this, make it optional :)

Here is a test project: ExpansionPresetsDemo.zip

[d.healey]

Aha I think I'm getting somewhere!

Pushed to this branch/PR - https://github.com/christophhart/HISE/pull/368

I think I know what needs to be done for getting the search working across all expansions. It looks like it will require some brain power though so I'm not going to tackle it today.

[bendurso]

@d-healey Is this working now on the develop branch? I can’t filter the presets using the favorite button or the search bar within expansions.

[d.healey]

@bendurso might only work for full expansions, not sure as I haven't used it in a while

[bendurso]

@d-healey Oh I'm using encrypted expansions. What are you using for searching presets and saving favs?

[d.healey]

@bendurso I'm no longer using the expansion column in the preset browser so the search for me just works like with any regular (non-expansion based) project.

[rzrsharpeprod]

@d-healey do you mean that you are still using expansions but somehow getting the list of expansions into the 'regular' preset banks column so the standard search works or do you mean that you are no longer using expansions at all?

If it's scenario number 1 then I'd be interested to know how that works as searching across expansions of probably the number 1 user request we get asked about.

Thanks in advance

[bendurso]

@rzrsharpeprod He's using expansions.

You can get the expansion list with Engine.getExpansionList, and set an expansion with Engine.setCurrentExpansion. So there's no need for the preset browser expansion selector.

[rzrsharpeprod]

@bendurso said in Expansions & Favourites:

@rzrsharpeprod He's using expansions.

You can get the expansion list with Engine.getExpansionList, and set an expansion with Engine.setCurrentExpansion. So there's no need for the preset browser expansion selector.

I got expansions working sometime last year (with the help of David actually) but I mean the search doesn't work across all expansions, only the currently selected one. I was trying to figure out if David - or anybody else had got this to work as it is a regularly requested feature

[bendurso]

@rzrsharpeprod Oh, sorry — you meant the 'search' function in the preset browser. Yeah, as far as I know, that's only available for selected expansions. Maybe I'm wrong. Maybe you could change the source code to make it possible.

[d.healey]

@rzrsharpeprod Yeah the preset browser search bar will only search within the current expansion. In my plugin that's ok because the expansions are loaded outside of the preset system.