Saving MIDI CC assignments in user presets?

[dannytaurus]

@ustk Yes, 'active' is too ambiguous a word to have used in the first place. My bad.

[ustk]

@dannytaurus The honour of badness is mine

[David Healey]

@ustk said in Saving MIDI CC assignments in user presets?:

So the working solution is

I think there's more to it, at least if you're saving/loading it from a file.

setUpdateCallback is triggered before on init and setPreCallback is only triggered when loading a preset.

So we need it to be that when we make a change to automation we save the the object to a file.
Then at init we load that object from the file using setAutomationDataFromObject
And during preload we pass the object into preset data.

[ustk]

@David-Healey Absolutely, then the mah.setUpdateCallback allows you to easily write the file, that's why I said "or just rewrite what you already saved" in the post above

[David Healey]

@ustk Yeah I've got it working now. I've set it to fall back to the preset's automation if the one loaded from the file is empty. That way I can setup my "defaults" in the preset file.

[ustk]

@David-Healey said in Saving MIDI CC assignments in user presets?:

That way I can setup my "defaults" in the preset file.

Clever!

[ustk]

@David-Healey Till today I wasn't aware of this setEnableUserPresetPreprocessing, this will save me from other situations where I was tinkering with the pre/post save/load in order to keep parameters persistent...
I'll keep that in mind now!

[Christoph Hart]

the Midi CC settings are part of the data model of a user preset that is saved in the DAW project, otherwise it would loose the connections when you reload a DAW project.

If you want to clear the Midi assignments when browsing user presets, you can easily just clear it in the post load callback and guard it behind the !uph.isInternalPresetLoad() check.

And any Midi CC connection reacts the same way as note input, so if you have armed multiple tracks it will control multiple instances. Feature, not a bug.

[dannytaurus]

@Christoph-Hart said in Saving MIDI CC assignments in user presets?:

the Midi CC settings are part of the data model of a user preset that is saved in the DAW project

Are you referring here to the saved DAW session, or the saved user preset? Or both?

Saving as part of the DAW session is cool, I just don't want them saved in the user presets.

[Christoph Hart]

@dannytaurus HISE treats a user preset and a DAW state exactly the same - it reloads everything in the data model including the CC assignments.

If you want to distinguish between the two, you need this method:

https://docs.hise.audio/scripting/scripting-api/userpresethandler/index.html#isinternalpresetload

I wouldn't start hacking around in the source code for this, the data model needs to stay consistent, this is just an UX problem while preset browsing that you can solve easily on the script level.

[dannytaurus]

@ustk From what Claude says, this is minimally useful for my situation.

Although you can preprocess the preset data before loading it, you still have to set all the values to something, meaning you can't just say "don't overwrite the existing CC assignments". I suppose you could read the current assignments, then preprocess to replace the preset assignments with the current ones. Phew!

But as I replied to David earlier, that leads to there being lies on disk.

[dannytaurus]

@Christoph-Hart I don't really want lies in my user preset data. Might be confusing to anyone who read/edits the XML

[dannytaurus]

@Christoph-Hart said in Saving MIDI CC assignments in user presets?:

If you want to distinguish between the two, you need this method:

https://docs.hise.audio/scripting/scripting-api/userpresethandler/index.html#isinternalpresetload

Personally, I don't need to distinguish between a DAW session reload and a preset load. I just want no MIDI CC data saved to, or loaded from, user presets.

[ustk]

So my solution is incomplete because it doesn't restore CC with session... Back to Chris solution...

[Christoph Hart]

@dannytaurus said in Saving MIDI CC assignments in user presets?:

Personally, I don't need to distinguish between a DAW session reload and a preset load. I just want no MIDI CC data saved to, or loaded from, user presets.

Of course you need to distinguish between a DAW session and a user preset, you want the CC assignments to be retained when loading a DAW project, no?

It's pretty simple: the data model that drives the plugin state MUST include the CC assignments. If you want you can strip it out of the user preset system with the script callbacks (or you can hack around in your local source code but there's no chance of this making it upstream).

[dannytaurus]

@Christoph-Hart said in Saving MIDI CC assignments in user presets?:

Of course you need to distinguish between a DAW session and a user preset, you want the CC assignments to be retained when loading a DAW project, no?

Not if someone wanted a truly global system. But that use case has too many downsides for me, so I'm going for per-instance restore and no CC in preset data.

[dannytaurus]

Here's the PR with the preprocessors. I already closed it but leaving it rather than deleting in case the specifics help anyone.

https://github.com/christophhart/HISE/pull/995

The two preprocessors:

HISE_MIDI_AUTOMATION_IN_USER_PRESETS // load/save CC mappings from preset data?
HISE_MIDI_AUTOMATION_IN_PLUGIN_STATE // load/save CC mappings from session data?

Allow you to set up any of four scenarios:

1. U=1, P=1 (default): "I want CC mappings to be part of the sound, recalled with every preset, and I also want each plugin instance to remember them in the DAW session."

2. U=0, P=1 (per-instance): "I don't want browsing presets to touch the user's CC mappings, but I do want each instance to remember its own mappings when the DAW session reopens."

3. U=0, P=0 (global, script-owned): "I don't want presets or DAW sessions storing CC mappings at all, because I want one global mapping file that my script owns and every instance shares."

4. U=1, P=0 (odd but technically valid): "I want CC mappings treated purely as patch data that loads with each preset, but I don't want sessions keeping their own separate copy that could drift from whatever preset is loaded."

I'm going for the per-instance approach plus manual [Save As Default Map] and [Load Default Map] buttons in my UI.

Feels like the best approach for my synth, and what I would want as a user.

[David Healey]

@dannytaurus I think option 3 is what I want. I'd like it to be seamless. The user assigns a CC to a control and that's it. They can change presets, add new instances, reload the DAW sessions, etc. and their assignments stick.

I'm trying to get it working just via scripting but it's actually a real pain, the settings keep getting overwritten. It might be because I'm using expansions rather than it being a plugin. I'll keep trying.

[David Healey]

Finally got it working. I had to add several flags to guard against my save to file function running and overwriting the stored CC values.

[David Healey]

I'm still hitting some bugs with this.

@Christoph-Hart I think you should take a look into this because it is a very good point.

So far I haven't really ran into this situation because most of my projects only have one or two presets. But I'm developing a project at the moment that might have 100 or more presets and this will definitely be an issue.

If a user has a set of CCs they like to work with then they likely want to set it up once for the entire instrument (all presets past, present, and future) and forget about it. They don't want to have to redo it each time they add an instance of the plugin.

With this instrument wide setup I don't see a reason to distinguish between daw load or user preset because the source of truth will be a separate file that can be read in both situations.

I'm currently trying to implement a working solution through scripting but I'm running into annoying issues with setUpdateCallback because it fires at init - it fires multiple times when using full instrument expansions. I'm gating it currently with flag variables but still haven't got it working reliably yet, and the code is a tangle.

-- Should also include macros and MPE assignments too.