Polyphonic Custom Filters (scriptnode) how?

griffinboy

Yep haha, thank you though.

I wish I didn't have to ask such questions, but I am slow to understand the Hise source code : (

ustk

@griffinboy Yep tested and working here

ustk

@griffinboy Don't be harsh on yourself, no one has publicly advanced on the C++ topic as you did!
I wouldn't have made my first steps without you!

griffinboy

@ustk

Ah my code will probably not work when run it has a dependency, I should probably include it in this post.

I might rewrite this post to make it easier for christoph to help me out
I just need to figure out how to create an instance of a class for each voice, and process audio through that

ustk

@griffinboy said in Polyphonic Custom Filters (scriptnode) how?:

Ah my code will probably not work when run it has a dependency

Well I just commented out the dependancy and it kinda works...

I just need to figure out how to create an instance of a class for each voice

But that's what the wrapper does with NV, isn't it?

griffinboy

@ustk

I don't believe so, or at least not for my node. It was not producing any audible effect, wheras inside a regular scriptfx (non poly) it was working.

I have just realised that I may have solved this before, I wrote a pretty bad sampler a few months ago using ai, and had unwittingly used polydata, which I stole the usage of from the regular sampler inside of hise. I'm going to investigate that now.

Christoph Hart

Code looks OKish on the first glance, but you need to call updateCoefficients in your prepare callback too though so that it can initialize the coefficients when the sample rate is set (otherwise it might be zero because the parameters might or might not be set before or after the call).

griffinboy

@Christoph-Hart

I'll try with a more simple effect.

ustk

@griffinboy Well in my video above it works, and it is just your pasted code, node inserted in a poly FX

@Christoph-Hart noticed that the coeff weren't updated as they should but I got lucky having the filter working straight ahead

griffinboy

@ustk

Okay maybe I should update my version of hise.
I'm very surprised that everything seems to be in order lol.

For me it still only works when used in monophonic.

ustk

@Christoph-Hart Jus noticed that when two+ notes are held, changing the resonance makes the freq to be updated to last note value for all notes. What could be done to prevent this?

ustk

@griffinboy Strange indeed...

griffinboy

@ustk

The fact that it works without dependencies means that the ai has removed some of my optimisations, I'll release a proper version of this filter when it's done lol.

I'm amused that it's (somewhat) working for you

Christoph Hart

Yup it works here too, but you definitely need to put the function call into prepare().

us noticed that when two+ notes are held, changing the resonance makes the freq to be updated to last note value for all notes.

That's intended - any UI interaction will be applied to all voices. If you want to use different values, you have to modulate it, then it will be applied for each voice:

HiseSnippet 1763.3oc2Y0zSiaDFdbfIrjkVs6psRcukC8.aEBk.rvh1CD9JaQcCDQnnsmPC1SHSi8Lt1N.YqpTkZOr2548V+azSs+ApTk5uf9Of+AsuiGarcrARLeraaPBxLuy63G+9wy7XSSGgN00U3fzJsWeaJRaJbq9buNq2gv3ns1.o8w3FDWOpSY0Tq02l35RMPZZi8R4DZSNNx+yYqrFwjv0oQSgP6KX5zWwrXdQy1r1WxLMqSLn6wrhs5EpsktfutvTzCvyX3JHahdWxQzsIxkU.i9BhaGj1miq7rEozklusgAY94MVbwEW94KuvxUIsqr.4vpKt7BysvRy87kZizJtoAyS3zxi3QcgMcMgQ+VcDmvUWf8YtrCMoxAUQsfqrZZz5cXlFMCCNtHjFtYTnZLUn5w3FLC14yGExdfugxQdDOnoU3xfT0Q.RZwfz3JH8PbKcGlsWjEIdtOdKNjAaSfbSbnnVKR62wqKfEv8l0hzkV2AFbtCSuXkJyTF90SeQ6dbcOlfWVv2V3Q2gO8SK8cklrz2Wp7flZ2NSaxKiivzj5joYY4fyk43z7dVGRclo7wDydzyWHb6mLlVb3ho5p65XKTv2hy71wlFLttvzPFqjeOcF.ED1fu8UasAwiHSJAyAqyl53wjvQaC5wPafJEMIdCpaWOgMzHjJ+AUNBidlDujkSxFs.CP7HQNTln3tLu9waDGgZrJWZM1vBwGhax7z6jMFKjAFgH0sAFC5L+H7lsaS08h.3335uNusgUF41vRAsgv0TdwmJXX45utZlMfuEGUra6PsINz8DMMI8m1kXYaR2Ev3LkOzTn2sE6MzzcH1JHrlbESq2gv4TS27zHU7FhbBsqnmGieTChmC6Tf9b6dVs.dcc55AnClSqfrGRMthbrrtnEka3O3efOAFqJGqEXrZnwXseaS8NQ3z0OcD7cj1DpXuqeP9f1mBvm53JKN0l.WYV3GzpllhSVWXYyBJagjh+bMEl8s6H3Lc4TpUDB8UsD8fqZ.9gyj1ivLk04s54BLGF6vaAK1+fPYc11BC3aSTmnCA19MIdcj8KRtGn3j5Lq94EoIvZ75D0AfILKSJMINfAfn1UkFjWoviOUAS.3VxHj7vSXa.69MLQ9IKeCGANoNsHZlFL99xJDvjLhgZPN87wUgwIFrAsMomoWh474C4T+xufd0PZQUmibDvKTPc+uk69Rq5DyvsFhwqIDcsHpragvAAtLAFJt61Ob0OB6xNZNKgwKHFFuvlR5hPC3QIrcOGZ4cb0CcZJrvUGTjHozt9L4SFRAoZt8US4mceRvLbHKT1eZpKyk5T8RzT8mCqlJ6gVSUHmyL3qAuv3CGuPxyshs9LnQK9dPf0MygeuGOeNwgOSFhwVL4gFaxOlZBkt9X7Q3ftyvYSV00PvEgzcQEZ6RAx6iNRxLDg8LugV0yCjpGMyiqsK0jRbiUI9Y0dEP2QbZ3SGlqXwnqGNy70mhUvsrrUo7+c0UM1+q0UMrgn6g27TOGR0O.ydAPat6Rn8ghtqmDHVQdZ2AtwOsa3zbU3Zn4JkLuPQXEGBQXWLvSqH6hW6UIEKO5fBjuozwA2LpkFS6Rp6NG5rwLmkhxXlGEHKMAGwbZnToMXt1viqrVOfdPwEmXF48E2fdZXEzlfHCC3Aq8cOrpJgpzhwTkNQjJzHZtHkngy8fZs7n1xmOJdmUqtzSTwkDGhAgthX+ihFXWNakjxXithnKGRKTKEjd6eMHj9k28teMMjp8iV+wJJo20cneaOnNt+.35G5VKSbAyeE35rURGppLhgpo7wU4ck8qCa.6rUPidND.wHlCeIPXdmCIfP7BgzD3lcjBeRs04rt5l.SE8UnNBgoXLLkvviSonGSvu73XrmmuhzTLwb+1jSTKFhKhg3ocRzdeEanugzfLviq.fimfALRS1dDmindtnDOravYNaYHUM0PHN5f5LSYN97rszzivq2ySztc4n99acp0wtj5Me9oT0a094giGKFeQSpCSX3+rno1qrq595Z2AMB2G+JgvFTY438AWCZ93wjkhwp8m.aAqmgtPgNJyoaABcbjTAD18UHABxfrHsTqrPvcKMAb8fGQc.USSgsf+NqxRlXz2xUfwBIhRW3qa6V6DH0FjiB7AplRxbkHP8IXaGw2.bcyFeIoiXI2h7G2JDKtcubp95JDSjAYbxcrvukM2EvosJ3IT4n9+cbSPXT6ueyOsxkQjsK0Uv8e0f4LOmXPr2wZ9dCn2EO2oEQ2Qbft5UUJKJtm+L.m.2uVaRbC43xUQGO3stEyfcftdxsJkiykWGmOuNtPdc7Y40wEyqiKkWGe9U6n704FzBI0NAcHM2TofQaSN4PSEiB5eoxNyhG

ustk

@griffinboy Well, if you could develop things that are working for me and not for you, I can be nothing less than grateful...

griffinboy

@ustk

Hahaha, okay I'm going to make a fresh build of hise and hopefully close this topic if it works after that

griffinboy

@Christoph-Hart

Okay I've gotten it to work in a fresh project - this seems to be a recurring theme to me! I've got a few projects where features are completely broken, but work perfectly in fresh projects. I should do an investigation and find out why. It might be something to do with the way I use c++ nodes.

griffinboy

@Christoph-Hart

I think there might be a glitch here somewhere. Another one of my projects has suddenly stopped working with my polyphonic filters. I'll do some investigations

Polyphonic Custom Filters (scriptnode) how?

33

1.9k

10.5k

91.6k