Sample not triggered if MIDI overlaps

[d.healey]

I like the choice of sample ;)

I built it as a VSTi plugin and had no issues with overlap. Did you try adding an interface?

[Dan Korneff]

@d-healey interesting. Which daw? I'm going to post some videos today.
I didn't add an interface to this test, but my other samples had interfaces.
Thanks for checking it out

[Dan Korneff]

@d-healey @Christoph-Hart
https://youtu.be/yh-XXllG3ew
Here's a video

[d.healey]

@dustbro I used Reaper too, but I don't have the plugin version of HISE so I just exported your demo project to a VSTi and tested that. Can you do the same and see if the problem is still there?

What version of HISE are you using?

[Dan Korneff]

@d-healey Exported VSTi has the same result
https://youtu.be/nxSNOx3_3VM

I'm using HISE 2.0

[Christoph Hart]

Hmm, I can't replicate this in either Reaper or Cubase - overlapping notes still are triggered here.

[Dan Korneff]

@christoph-hart @d-healey
I appreciate you guys looking into this. I'm not really sure where to look next to solve this issue. It's happening on my MAC and PC, as well as 6 other users computers I use for beta testing.

I just compiled the latest version on a completely new system and I can't even get the sampler to play. Sine generator works fine. Check out this video... got me scratching my head. It doesn't appear the be a plugin vs. standalone issues either. It happens on both.
https://youtu.be/_uxAoG9o8xI

would you guys mind uploading your test vsti so I can check here?

[Dan Korneff]

@Christoph-Hart I'm also noticing some sampler inconsistencies when printing audio from the vsti (as well as using the freeze function in Cubase)
check this out:
https://youtu.be/OgGNEWWKaOs

[d.healey]

@dustbro said in Sample not triggered if MIDI overlaps:

would you guys mind uploading your test vsti so I can check here?

Mine is GNU/Linux so I don't think it will be much use to you

[Dan Korneff]

@d-healey bummer! It's literally the last thing holding me up from releasing this product :(
@Christoph-Hart this is going to be a closed project, by the way, so I'll be in touch soon.
If there's anything else you can think of that I could do to help track this down, let me know.

[Dan Korneff]

@christoph-hart said in Sample not triggered if MIDI overlaps:

Hmm, I can't replicate this in either Reaper or Cubase - overlapping notes still are triggered here.

Can you post a video so I can check it out? Does it look like I'm doing something wrong with the stuff I've already posted?

[Dan Korneff]

@Dominik-Mayer The embedded youtube video feature is awesome!

[Dan Korneff]

Maybe I could use a Timer to send a noteOff command directly after a noteOn is received?
What would that look like? Is there an example that shows how the timer works?

[d.healey]

@dustbro That might work but it doesn't solve the problem. This is a very strange issue. It would be good if someone else could recreate it.

[Dan Korneff]

@d-healey From what I've read on the JUCE forums, this behavior may be by design. Apparently, playing a 2nd note without first receiving a noteOff would result in a midi note stuck on.
I believe that the first noteOff message isn't received when it gets overlapped by the next note.
For instance:
Note on = play 1st sample
Note on = play 2nd sample
note off = stop 1st sample
2nd sample is now stuck on.

[Dan Korneff]

I've had a couple beta testers say the instrument would cut out randomly (I guess similar to the video I posted above where the samples get cut off). I'm wondering if this is a result of note on/off messages getting outta whack by overlapping notes?

[Dan Korneff]

@Christoph-Hart @d-healey Are there any documents that explain how the Timer works?
I've been looking at some scripts on the forum, but can't quite wrap my head around it.
I'd like to experiment with using the noteOn to trigger a noteOff command at a timed interval (maybe 40ms) to see if it stops the issue I'm having.

Here's what I've been tinkering with, but it's just not working:

const var storeNoteNumber = -1;

inline function AutoNoteOff()
{

    Synth.startTimer(40);
};

function onNoteOn()
{
    storeNoteNumber = Message.getNoteNumber();
    
    AutoNoteOff();
}
function onNoteOff()
{
    if(Message.getNoteNumber() == storeNoteNumber)
    {
        Synth.stopTimer();
        storeNoteNumber = -1;
    }
}
function onController()
{
    
}
function onTimer()
{
    
    if(storeNoteNumber != -1)
    {
        Synth.noteOff(storeNoteNumber);
	storeNoteNumber = -1;
    }
    else
    {
        Synth.stopTimer();
    }
}

function onControl(number, value)
{
    
}

[Christoph Hart]

1. You can‘t change a const var defined number. Use reg instead.
2. the startTimer argument is in seconds - this is highly inconsistent with the UI timers which are controlled in milliseconds, but I can‘t change it for backwards compatibility reasons. Use 0.04.

[Dan Korneff]

@Christoph-Hart

Synth.noteOff(storeNoteNumber);

This line is giving me an error.
Illegal operation in audio thread: String creation

[d.healey]

@dustbro said in Sample not triggered if MIDI overlaps:

This line is giving me an error.
Illegal operation in audio thread: String creation

That error message usual means you have a typo in a variable name