Callback when preset saved??

[d.healey]

@Dan-Korneff I was thinking that a broadcaster might be the answer, but I don't think there is a suitable one available so would require some work by Christoph.

Another idea (which I don't yet see a problem with) is it could just trigger the existing post callback.

[d.healey]

I added this at the end of the save preset function so that it triggers the post callback and it works nicely here

chain->getMainController()->getUserPresetHandler().postPresetLoad();

@Christoph-Hart Any reason why I shouldn't do this?

I've also fixed the bug where renaming a preset deselects it :)

[Christoph Hart]

@d-healey yes the name of the function suggests that it happens after a preset load which might be used for all kinds of things, so running this after you saved a preset is very irritating.

[d.healey]

@Christoph-Hart Should I look at adding a presetSaved callback or do you think a broadcaster based solution would be better?

[Christoph Hart]

@d-healey I would add a UserPresetHandler.setPostPresetSaveCallback(onPresetSaveCallback) function.

[d.healey]

@Christoph-Hart Thanks, I'll give it a go

[d.healey]

@Christoph-Hart I've started implementing it on a separate branch but when I'm compiling I'm getting an error that I haven't been able to figure out as it seems unrelated to anything I've touched.

In file included from ../../../../../HISE/hi_components/hi_components.cpp:42,
from ../../JuceLibraryCode/include_hi_components.cpp:9:
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp: In constructor ‘hise::PresetBrowser::PresetBrowser(hise::MainController*, int, int)’:
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:531:57: error: invalid new-expression of abstract class type ‘hise::TagList’
531 | addAndMakeVisible(tagList = new TagList(mc, this));

[d.healey]

@Christoph-Hart Any tips? This C++ stuff is not my comfort zone :)

[d.healey]

Ha I've done it! I need to do a little clean up then I'll make a pull request.

[Dan Korneff]

@d-healey you should make videos of your debugging journeys for Patreon.

[d.healey]

@Dan-Korneff I'll have a think and see if I can come up with a way of showing that in an interesting way. A lot of it is me in bed or in the shower just thinking things over until I realise where to target my effort.

Then at the computer I'm just reading a lot through the existing code and trying to figure out which bits to copy/paste and where I need to add new stuff. Then I compile and test, then do that some more. It's quite tedious.

[d.healey]

Dang, I I haven't quite done it. I'm hitting an infinite loop now that ends in a segfault..

[d.healey]

@Christoph-Hart I've got it triggering my callback when a new preset is added.

But when clicking the save button in the preset browser I've hit a snag.

In the function void PresetBrowser::ModalWindow::buttonClicked(Button* b)

I'm calling my callback caller after the replace action completes

getMainController()->getUserPresetHandler().postPresetSave();

But this goes into an infinite loop and I don't know why.

This is the caller (it's the same as your changed caller, I just altered the name of the listener).

void MainController::UserPresetHandler::postPresetSave()
{
	auto f = [](Dispatchable* obj)
	{
		auto uph = static_cast<UserPresetHandler*>(obj);
		auto mc_ = uph->mc;
		ignoreUnused(mc_);
		jassert_dispatched_message_thread(mc_);

		ScopedLock sl(uph->listeners.getLock());

		for (auto l : uph->listeners)
		{
			uph->mc->checkAndAbortMessageThreadOperation();

			if (l != nullptr)
				l->presetSaved(uph->currentlyLoadedFile);
		}

		return Status::OK;
	};

	mc->getLockFreeDispatcher().callOnMessageThreadAfterSuspension(this, f);
}

[Dan Korneff]

@d-healey said in Callback when preset saved??:

A lot of it is me in bed or in the shower just thinking things over until I realise where to target my effort.

Awesome! You can do Patreon AND OnlyFans content.

[d.healey]

Bump bump

[ustk]

@d-healey Why don't you call your method from saveUserPresetInternal ?

[Christoph Hart]

I've added that function.

[d.healey]

@Christoph-Hart Woohoo! Thanks!

[d.healey]

Getting a build error:

../../../../../HISE/hi_backend/../hi_modules/../hi_scripting/../hi_sampler/../hi_components/../hi_dsp/../hi_core/hi_core/MainControllerHelpers.h:116:53: error: no matching function for call to ‘hise::MidiControllerAutomationHandler::clear()’
  116 |         void resetUserPresetState() override { clear(); }

[d.healey]

Ah I see the problem. Do we want to sendNotification here?