HISE Logo Forum
    • Categories
    • Register
    • Login

    [bug] Full expansion audio files not being pooled.

    Scheduled Pinned Locked Moved Solved Bug Reports
    audio filesexpansionimpulseloadingembed
    21 Posts 3 Posters 2.1k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • d.healeyD
      d.healey @Dan Korneff
      last edited by

      @Dan-Korneff Probably some kind of caching issue.

      Free HISE Bootcamp Full Course for beginners.
      YouTube Channel - Public HISE tutorials
      My Patreon - HISE tutorials

      Dan KorneffD 1 Reply Last reply Reply Quote 0
      • Dan KorneffD
        Dan Korneff @d.healey
        last edited by

        @d-healey I'm getting 2 error in PresetHandler.cpp

        Screenshot 2023-05-31 113334.jpg

        Screenshot 2023-05-31 113504.jpg

        Is this normal?

        Dan Korneff - Producer / Mixer / Audio Nerd

        1 Reply Last reply Reply Quote 0
        • d.healeyD
          d.healey
          last edited by d.healey

          That might be because there isn't a Samples folder in appData. What is the value of dir?

          Free HISE Bootcamp Full Course for beginners.
          YouTube Channel - Public HISE tutorials
          My Patreon - HISE tutorials

          Dan KorneffD 1 Reply Last reply Reply Quote 0
          • Dan KorneffD
            Dan Korneff @d.healey
            last edited by

            @d-healey Samples (5)

            Dan Korneff - Producer / Mixer / Audio Nerd

            d.healeyD 1 Reply Last reply Reply Quote 1
            • d.healeyD
              d.healey @Dan Korneff
              last edited by

              @Dan-Korneff Adding a Samples folder to appData should solve that.

              Free HISE Bootcamp Full Course for beginners.
              YouTube Channel - Public HISE tutorials
              My Patreon - HISE tutorials

              1 Reply Last reply Reply Quote 0
              • d.healeyD
                d.healey
                last edited by

                I'm guessing the problem can be traced from ScriptingApi::Engine::loadAudioFilesIntoPool()

                It's like it looks in the binary (Rhapsody) but not in the expansion hxi.

                Free HISE Bootcamp Full Course for beginners.
                YouTube Channel - Public HISE tutorials
                My Patreon - HISE tutorials

                Christoph HartC 1 Reply Last reply Reply Quote 1
                • Christoph HartC
                  Christoph Hart @d.healey
                  last edited by

                  @d-healey Spot on!

                  https://github.com/christophhart/HISE/commit/01c1780c17a51e5608b2837c0ceb2e315ab70a55

                  d.healeyD 1 Reply Last reply Reply Quote 1
                  • d.healeyD
                    d.healey @Christoph Hart
                    last edited by

                    @Christoph-Hart Thank you!

                    Free HISE Bootcamp Full Course for beginners.
                    YouTube Channel - Public HISE tutorials
                    My Patreon - HISE tutorials

                    1 Reply Last reply Reply Quote 0
                    • d.healeyD
                      d.healey
                      last edited by

                      @Christoph-Hart I think I've hit another similar problem. This time I'm using the loop player. I save a preset with a file (from the expansion's samples folder) loaded but when I open the preset in the player the file isn't there.

                      I've been poking around in ExternalFilePool.cpp and think I'm in the right location but do you have any pointers?

                      Free HISE Bootcamp Full Course for beginners.
                      YouTube Channel - Public HISE tutorials
                      My Patreon - HISE tutorials

                      1 Reply Last reply Reply Quote 0
                      • d.healeyD
                        d.healey
                        last edited by

                        @Christoph-Hart I've narrowed it right down now.

                        The problem is here - https://github.com/christophhart/HISE/blob/develop/hi_core/hi_core/ExternalFilePool.cpp#L538

                        There isn't any handling for the sampleFolderWildcard.

                        So as a test I added this:

                        		else if (input.startsWith(sampleFolderWildcard))
                        		{
                        			if (auto e = mc->getExpansionHandler().getCurrentExpansion())
                        			{
                        				input = input.replace(sampleFolderWildcard, "/media/dave/Projects/projectName/Samples/");
                        			}
                        		}
                        

                        And it works. However when I try to use the expansion wildcard instead of the absolute path it still doesn't resolve. Can you suggest the last bit of the solution?

                        Free HISE Bootcamp Full Course for beginners.
                        YouTube Channel - Public HISE tutorials
                        My Patreon - HISE tutorials

                        1 Reply Last reply Reply Quote 0
                        • d.healeyD
                          d.healey
                          last edited by

                          Aha!

                          input = input.replace(sampleFolderWildcard, e->getSubDirectory(FileHandlerBase::Samples).getFullPathName() + "/");

                          Free HISE Bootcamp Full Course for beginners.
                          YouTube Channel - Public HISE tutorials
                          My Patreon - HISE tutorials

                          Dan KorneffD 1 Reply Last reply Reply Quote 2
                          • Dan KorneffD
                            Dan Korneff @d.healey
                            last edited by

                            @d-healey giphy.gif

                            Dan Korneff - Producer / Mixer / Audio Nerd

                            1 Reply Last reply Reply Quote 1
                            • d.healeyD d.healey marked this topic as a question on
                            • d.healeyD d.healey has marked this topic as solved on
                            • First post
                              Last post

                            14

                            Online

                            2.0k

                            Users

                            12.6k

                            Topics

                            109.8k

                            Posts