Component List - expanded

[David Healey]

@danh said in Component List - expanded:

Should it not be closed like before?

It's been like this for over a year.

Oh actually looks like there was a change to this last year, but maybe it was changed again...

https://github.com/christophhart/HISE/commit/61685593ce29e7720b30490ef800ee4936f40bb3

[DanH]

@d-healey so when you open a project is the component list all expanded or all collapsed?

[David Healey]

@danh They are all expanded, but according to that commit from ustk they shouldn't be... My preference would be to have them closed by default and remember the way I had them the next time I open the project.

[DanH]

@d-healey this is also my pref....

[Dan Korneff]

+1
The first thing I have to do when I open a project is collapse the Component List tree

[ustk]

I will check if I can do the same pull request, don't know why it slips from the new layout migration...

[David Healey]

@ustk said in Component List - expanded:

I will check if I can do the same pull request, don't know why it slips from the new layout migration...

The code is still there, but it must work differently in new_layout it seems.

[ustk]

@d-healey Could you point me to the location, please? I can't find it...

[David Healey]

@ustk https://github.com/christophhart/HISE/commit/81530de6db1acdd3b0cddecaaac11ced616f056a

Here it is in develop branch - https://github.com/christophhart/HISE/blob/develop/hi_backend/backend/debug_components/ScriptComponentList.cpp#L439

[ustk]

@d-healey Thanks, I might have found the reason... building now...

[ustk]

Alright, pull request made :)

[lalalandsynth]

Also happens if you switch from interface to Scriptnode and back.

[ustk]

@lalalandsynth Now it collapses again each time the list rebuilds (once the pull request is merged of course)

[David Healey]

@ustk Does it remember the last state when you save the project?

[lalalandsynth]

Might be useful to have an Expand/Collapse all button as well.

[ustk]

@d-healey said in Component List - expanded:

@ustk Does it remember the last state when you save the project?

I don't think it is possible without implementing the whole thing, that's actually a good thing I can look at in order to learn how it works, although don't expect me to succeed…

@lalalandsynth said in Component List - expanded:

Might be useful to have an Expand/Collapse all button as well.

At least you can collapse all for now. Just fold/unfold Root

[lalalandsynth]

@ustk said in Component List - expanded:

At least you can collapse all for now. Just fold/unfold Root

Yes, but that expands all when root is expanded again. :)

[ustk]

@lalalandsynth

@ustk said in Component List - expanded:

(once the pull request is merged of course)

[ustk]

Alright guys, @Christoph-Hart has just merged it :)

[lalalandsynth]

@ustk Sweet !