HISE Logo Forum
    • Categories
    • Register
    • Login

    Pretty weird problem with the Preset Browser ?

    Scheduled Pinned Locked Moved General Questions
    45 Posts 5 Posters 2.8k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • d.healeyD
      d.healey @lalalandsynth
      last edited by

      @lalalandsynth

      Is there an ETA on V.3 HISE ?

      Nope

      Libre Wave - Freedom respecting instruments and effects
      My Patreon - HISE tutorials
      YouTube Channel - Public HISE tutorials

      1 Reply Last reply Reply Quote 1
      • ustkU
        ustk
        last edited by ustk

        Bottom of the third post:
        https://forum.hise.audio/topic/2555/scriptnode-breaking-changes/3
        But it seems compromised since @Christoph-Hart isn't working on it for a moment...

        Can't help pressing F5 in the forum...

        1 Reply Last reply Reply Quote 1
        • LindonL
          Lindon @lalalandsynth
          last edited by Lindon

          @lalalandsynth said in Pretty weird problem with the Preset Browser ?:

          @d-healey said in Pretty weird problem with the Preset Browser ?:

          @lalalandsynth I don't use the broken parts. The stock preset browser and its controls work fine, but if you try to use the api functions you'll meet the bugs. Save/load, next/previous, etc. are buggy or just don't work.

          Do you always use 3 columns as renaming does not work for me using 2 columns ?
          And that is just the stock browser.

          I've never come across ANY problems with the Preset Browser - and I've implemented fwd/back buttons that use the API - but I've ALWAYS used the 3 column version - maybe that's the issue?

          HISE Development for hire.
          www.channelrobot.com

          lalalandsynthL 1 Reply Last reply Reply Quote 1
          • lalalandsynthL
            lalalandsynth @Lindon
            last edited by lalalandsynth

            @Lindon The 3 column one I am using does not show one of the selected presets when the preset browser is open and you are scrolling through using prev/next, it loads it ,admittedly usually its closed when using the prev next. .......So with the preset browser closed you might not even notice it , but when using Prev/next and you hit the one it skips , the name in your getCurrentUserPresetName and the one in the preset browser will not match when its opened.

            Potentially very confusing for a user.
            SEE GIF.
            3 column display.gif

            HiseSnippet 3088.3oc6a07aabbEeWIM1VLVxNNoAsnWVv1CRvNxb4GhjwMvq9hNxQRjVT1wtoANi1cH41rbW58CYSGXTglKsmZO1.zCFs+Cjy8jZuUfdnn8efbr.Env+Gj9lY1k6r7CIJ4OhUaXfMx9lYd6u2Gy68l2rtlqiNwyywURd5c51gHIedT8t19sVoE1zVZ8UkjeKz8vM6hUpaZPzoTUJJsb2NXOOhgjr7j2fNQ4omRh86YWeYrE1VmDSRR5NNl5jMLaa5GSsl1GZZYUAaP1wrsvryqstti8JNVNA.nlDkQpCV+yvMIagoSaBjj7YVyvz2wstO1m3IIO0xNFcq2x4g174eGSOycsHzGTkpCLhSthikAEwTpRqzxzxnVjv6IIIipEqJljqJdazllFl8nGqRtHa.k3UHpOjm3vfmpH7xL9vSV.dSwg2ahpq6Z1wOdDJ1dCz519D2FXvDHBK9bkl3OeVzJNvLr8WnM9yHUbgG5sh4JoV9JJKple9qMSJ5+c0qpTsCwFDUhGwm976dr+Q4CXR87U1C6pzAaSrTUdekHTfMLpQoMWZ9PouhRoL.HxPwvUuZ7J4XXUSuNV3tBLnIweEm1cbrgGlKchYklyCkO9l0qtU3q9Sn3IZsvTA0WGhquIwCzEsoST.Ie9LoTTR+PSC+VoeOkEyk+JLBsHlMa4CTxqlkSwzmzl6zBTyzOsrThyj5Ib0pnP0B1UQcNRpPVNv22wdtzQixji3EA.1lKmiTMDOkzB1RtdnkgCiqexQpGD3xUTJjg+GtNwEaX5bCWmfNfrkNS5dR2LoLssLsIJMBr08McrUbri4C8E55XMmcP6cItWADGq.x7yjhwT9OtxeAO.gQylOqqo.uD5KHlcKDyxUvVV6BgJlaHutH8N0GZOErsgxVjG4G5Qov01dmbu6gaB1kw1kbccd31L2k4GNZ6edIv7f5xQL84zidyCnTMavUfJu+6qnNOmF+uWytIv8ErbvFTExs8HtbcxbMvVdDJDdRnQ8HkwMHMFGQjNswWBEl8yq.RM8lNAdCJjWSbEO4ERPNF+2.uKwZj6PElS5QuygOq5VPf.2CSQnDs+IRinLWnrSeqAttvzikbZtz4lmptRmd93cdJiCToV34R6CtKPLgzpLryWLAzlOOL6HAb7qh6Wx++NrWCWwMJ2xgnb4VBJiELBa43SpZO27o97TSm5IoFXnFMF5Xgrzh3Nzgo083dXKrufjQSDJ.HYEFnQWggXAP5b8jvDcrW21zmlfeT0cHEpbgJPlNDUvT8Y0eLaX8Gb8mjITlwERPRUhA7vZ6d5Ws0eRS5XyjrIXxA+sb+iS.SxkfIe8eLyGdvwmI4SvD9uQwDdJkDLgSRsel7rqGyjo3LYlvUrClZEo7XVQJpChCCrOVRlfJlcgj+1qZit3GTN2FVcKtBixFk2ZoK2nvM6r3JrwsWduMt7tePPS131Uu6daemKWqwkWnHeb3ufGfek4OOVx7ah5KF9IS0cIT+I6NF7QvNNKRbm9P3wsWeUpFDpSNzeOtXHf1pPhCcBun6oQqR79LemNfgsWzFI4ylzxsda3.KIrbLJpROR701U7AVMl8H7690Z7ZL6QIyWn0vzJ7TPWF8401t5MWakctekpar5Za+D9YzpDXYo3Y9XhRAEnT9E5X2jpf5AyY7COXCGTUf7h9l1M2wLzO66MjAR.ZMsXPq8.sjf9qw8CZselVnBM5vkK8AqVe6a3h6zRZ2lhmxKtX49eNK8PMKVnXlLkJmqnDMYQzDmFsXobEJVNuDy9I+dHdwo8BgstAs5T1KERurGwBLqPc8rIstsA4QvvuqJjMQ38kSRNERMetLpEKjOg567icfuXU19UDTYOseUlzOteUlz8z5Did5Vo9PObdXWvI.NwFc3ygVx2GxlI0FG+N+U+SMO+tzL.oP2g5FqisRpPmFoppVJeI0D58oQ4xUnP974NQRcVQottfT+UGsTevcOVR8Ygcg53tuDE5KL1YVdjn29wRn2+3IzSipG34S6AgnXC+ZK1.l6cPaGiv.U5lPQVvvFFVjZNdlzxKhm45G7sfSRdA8kxtuj0WaSrHXOxKQ2jTicZeg8FKIH1ROtew9ZCDQXAs3PkPjoEKVrXV0Bi.ciPT7.wjTAq6yZ0Gqdru7K+qWeHlviUxAw87JsDjqCtSex0AOd.4ROYxgKfVJvvzYIarUWnveg7CCS5nISxVJegREKsX4xIEaPIkKWw7EyqlHaAS2snZlbEBSWjaDoKBQP+IJxRySbHN8BV+yih6Agno+Ahl9h8oh1e0ATQum1wHKIkfn7ReFpYnsmOfNdIIx+vApbv2Ea6wpTvCuGY8HPyVsnvdtjk3v5YGSVOGh2wFpbhjqwKrAI+SDJp4LOdBt7zS9NyuWlSIgW7YhBokzKtGY4IFMfFQMWYGUtXob8o9+W+x9U+e5izfHJvKS7sFIswUi8iFPmF1XIOcWBw9ERUXh4Y1WLOizp8IFOcfMZO0s+MZb7sLTUcxMZz5dJmqPFU091okOaoREUKmsXgjlF5HkyWt.DlIZS0eHbSE8bl0AOJ9tBX6iua.4J8Fh0ua2dCxZES7nziU6MHY54dC6V2fLDumiK.N50GjXvsBn3MnMaM4n6gE2jjP1Fs0dHa6OxioEawx3JXw1+98Yw9sdCTNzGqMfZVMGD2uXFHImXNvKh1nRUkMcLBrvPrcUAiYnsYwhYKWXPyoZg7EJjMmjuiikuIbblyfLBfBG1S75IFx9+w5zdBkm7KNrHdRYGHhWYsiSHKSuMcZCvC61MpEFiChGxAKELV6+sGjmNoqEqKYLDOCRnuYBf8.h1vNFIR1VHZKRtB7D0qmpM1h7vnNemL+HKN62P4RCHbQc3Xjwb95ZCAlG8QsYoDjhRIj.f5I.3Ugm545IOIwltEhcwUCGgRCdeXWD0aaf3U0QuexvAnk+JdmXz68xFJKtqX6Xdob+ciKbeSTMSe8VCGuSLD7RyI9RFug2F5Ln0Zzfn6GC1oPUt6qfq9bBArf3XIEpWUh767rWIaIvyxA.hcS5HefF6h.HOLreNgjunl7jIA+jiWWUGhtaam.ZZ6MwPDA5F.HATcv8Um.pNaHaBsksxzBhBeNSzdi5DaC1CeC7KbPU5yxgCpFMnn84b8t3dy1crH2Hx7LaHAEJE0C4N6gZHHV3DNUeTxXd2SaH2p+5vwtb8q4Xgc62k7EkpTdpwdeCUjTdd1mO434rdD2M+rbPhnokCC.0WB5iDXUbIOHfXqGQb++8s.hXCn173VM7az9Hn1pFNtsS5G+rquAoI7hDorCABbWuqstnMpdaGG+VrpKE+7KdasMbb5rVT32XlTqEbR5pMZvNaPLaVIvy2ocDVdU0C559jN7pM+Xzh4WH434p9h4YoigGxQ3FOwX5F+VLmkddET2lWySXwQbOW1SAH9RHVzNkSM0DbIDKZ7oG.eQTMr8qAv8Ubd3vP+uAj10lv9H5XZi2g8rBMDoxMH1D2ASCjLc7eeb+D55L1eBcU08gW+NzyfzwwKAiqSZatCTVumHwa6Qnao2lZ9RDs2A6NzgfDTfPNz0TG6G3x7CVpsSfs+gUnvTiWD1infwods9S46U2IWdwTQyE3X7r7lsGVsU+MdWDaaR+.rZ4XalndisIvtvlMIthHdnhA+BsVIvcORxZT0wcGfZ3seI7IFvorAAfl3D+.vnL.6D+pBhtbEguQfn6OP.bqo6rI+9UNIp8inLAzX5ZLS3k9ov12+5cxfYivJ2h75MXOO+dEOMnWuPzsAdpPwNazcwcZP0dnMgYxSaMg4ESVfv+0AbIDbd+t7n6ULs7Ca.yzH9CYOztLLvAa+KW9KztknYOYn0EztU.1JglVQaYyNzNNLVVgW98c3cPIN5y+607gOsQi+yX27guu12tMe31nEyLPyG1Ys673R67yq9fRzC2e2p+T7MyTVnYBq2p4thMWnWy.B+8cMa36Z1vyQpjm69R9JEu+.TX7UlV9zCtmEcq+OogCuJdGsw5tN2Wm+g0RCobNFEPtsYevCSi1j9rRuuDYDJyBYnenYl2WWmVSx6B5mgulrmf0j6Drl7mf0T3DrlEOAqo3IXMkNz0PahwRAPxPt+OPn1Z7bVxqEeUpR+W.7tdUr.
            

            The renaming issue is definitely a 2 column problem, It will allow renaming 10% of the time , which just makes it stranger :)
            But there is also the weird behaviour when using the next prev in the 2 column where it jumps back to directory ..see gif.
            Preset 2 Columns prev next.gif

            https://lalalandaudio.com/

            https://lalalandsynth.com/

            https://www.facebook.com/lalalandsynth

            https://www.facebook.com/lalalandsynth

            1 Reply Last reply Reply Quote 0
            • lalalandsynthL
              lalalandsynth
              last edited by

              BTW,. tested the renaming on the VST version of B3 Collab Organ which has 2 columns , and renaming does not work.

              https://lalalandaudio.com/

              https://lalalandsynth.com/

              https://www.facebook.com/lalalandsynth

              https://www.facebook.com/lalalandsynth

              ustkU 1 Reply Last reply Reply Quote 0
              • ustkU
                ustk @lalalandsynth
                last edited by

                @lalalandsynth I might have found the problem for the 2 columns renaming issue

                Not sure for the prev/next selection issue though…
                Can you please tell if this happens in 2 columns mode as well?

                Can't help pressing F5 in the forum...

                lalalandsynthL 1 Reply Last reply Reply Quote 0
                • lalalandsynthL
                  lalalandsynth @ustk
                  last edited by

                  @ustk You mean 3 columns mode as well ?
                  I tested 3 columns the other day , no renaming problem there but I will verify .

                  https://lalalandaudio.com/

                  https://lalalandsynth.com/

                  https://www.facebook.com/lalalandsynth

                  https://www.facebook.com/lalalandsynth

                  ustkU 1 Reply Last reply Reply Quote 0
                  • ustkU
                    ustk @lalalandsynth
                    last edited by

                    @lalalandsynth Ok so I fixed the 2 columns renaming issue as well as preset highlighting inconsistency on prev/next (for both 2 & 3 cols)
                    Although I'm still struggling with preset disappearing on prev/next in 2 columns mode...
                    But it's late and night is the mother of counsel! I'll have fun with that tomorrow :)

                    Can't help pressing F5 in the forum...

                    lalalandsynthL 1 Reply Last reply Reply Quote 3
                    • lalalandsynthL
                      lalalandsynth @ustk
                      last edited by lalalandsynth

                      @ustk excellent !!

                      https://lalalandaudio.com/

                      https://lalalandsynth.com/

                      https://www.facebook.com/lalalandsynth

                      https://www.facebook.com/lalalandsynth

                      1 Reply Last reply Reply Quote 0
                      • ustkU
                        ustk
                        last edited by ustk

                        Ok so now it's working, so I'm trying to extend this to the 1 column style that is broken too...

                        Can't help pressing F5 in the forum...

                        lalalandsynthL 1 Reply Last reply Reply Quote 1
                        • lalalandsynthL
                          lalalandsynth @ustk
                          last edited by lalalandsynth

                          @ustk Are you somehow fixing this within Hise or in c++ ?

                          https://lalalandaudio.com/

                          https://lalalandsynth.com/

                          https://www.facebook.com/lalalandsynth

                          https://www.facebook.com/lalalandsynth

                          ustkU 1 Reply Last reply Reply Quote 0
                          • ustkU
                            ustk @lalalandsynth
                            last edited by

                            @lalalandsynth In the source code so C++

                            Can't help pressing F5 in the forum...

                            lalalandsynthL 1 Reply Last reply Reply Quote 1
                            • lalalandsynthL
                              lalalandsynth @ustk
                              last edited by

                              @ustk yep, thought so , sweet !

                              https://lalalandaudio.com/

                              https://lalalandsynth.com/

                              https://www.facebook.com/lalalandsynth

                              https://www.facebook.com/lalalandsynth

                              1 Reply Last reply Reply Quote 0
                              • ustkU
                                ustk
                                last edited by

                                Now everything works except I have just noticed another bug. (actually, we can see it in your screen gif)
                                In 2 columns mode, you can't rename the Bank...
                                Taking a pause then back on it :)

                                Can't help pressing F5 in the forum...

                                1 Reply Last reply Reply Quote 2
                                • ustkU
                                  ustk
                                  last edited by

                                  Ok so after scrutinizing the code for hours, I need help for this one (rename & delete don't appear in 2 columns mode)

                                  I know it is because listbox->getNumSelectedRows() > 0 returns false for some reason... But what reason is beyond my skills 🙃

                                  void PresetBrowserColumn::updateButtonVisibility()
                                  {
                                  	editButton->setVisible(false);
                                  
                                  	const bool buttonsVisible = showButtonsAtBottom && !isResultBar && currentRoot.isDirectory();
                                  	const bool fileIsSelected = listbox->getNumSelectedRows() > 0;
                                  
                                  	addButton->setVisible(buttonsVisible);
                                  	deleteButton->setVisible(buttonsVisible && fileIsSelected);
                                  	renameButton->setVisible(buttonsVisible && fileIsSelected);
                                  }
                                  

                                  Can't help pressing F5 in the forum...

                                  lalalandsynthL 1 Reply Last reply Reply Quote 0
                                  • lalalandsynthL
                                    lalalandsynth @ustk
                                    last edited by lalalandsynth

                                    @ustk What do you mean by "delete" not appearing in 2 columns ?
                                    Delete works for me...

                                    Although its annoying that if I delete it goes back to category and I have to select that to see the presets again.

                                    EDIT: This going back to category is another sometimes issue..?

                                    https://lalalandaudio.com/

                                    https://lalalandsynth.com/

                                    https://www.facebook.com/lalalandsynth

                                    https://www.facebook.com/lalalandsynth

                                    ustkU 1 Reply Last reply Reply Quote 0
                                    • ustkU
                                      ustk @lalalandsynth
                                      last edited by

                                      @lalalandsynth said in Pretty weird problem with the Preset Browser ?:

                                      @ustk What do you mean by "delete" not appearing in 2 columns ?
                                      Delete works for me...

                                      Bottom of the left column, there are no Rename and Delete only in 2 columns mode:

                                      Although its annoying that if I delete it goes back to category and I have to select that to see the presets again.

                                      EDIT: This going back to category is another sometimes issue..?

                                      Will check that tomorrow, might be a lucky day :)

                                      Can't help pressing F5 in the forum...

                                      lalalandsynthL 1 Reply Last reply Reply Quote 1
                                      • lalalandsynthL
                                        lalalandsynth @ustk
                                        last edited by

                                        @ustk Ah, You mean delete and rename Category ! hehe.
                                        I hadnt even noticed that yet ....indeed

                                        https://lalalandaudio.com/

                                        https://lalalandsynth.com/

                                        https://www.facebook.com/lalalandsynth

                                        https://www.facebook.com/lalalandsynth

                                        ustkU 1 Reply Last reply Reply Quote 1
                                        • ustkU
                                          ustk @lalalandsynth
                                          last edited by ustk

                                          @lalalandsynth Yep, I meant:

                                          In 2 columns mode, you can't rename the Bank....

                                          :)

                                          Can't help pressing F5 in the forum...

                                          1 Reply Last reply Reply Quote 1
                                          • ustkU
                                            ustk
                                            last edited by

                                            The preset browser is fixed. Although I'm a C++ noob, so it certainly could have been done in a better way, so feel free to make it better and teach me at the same time :)

                                            Here's my fork so it can be tested before I make a pull request to Dave's fork:
                                            (My fork is up to date with Dave's one, so only the preset browser is different...)
                                            https://github.com/ustk/HISE/tree/develop

                                            Still, the last remaining issue is that Rename and Delete buttons don't appear in the bank column when in 2 columns mode. I still need help with this one...

                                            Can't help pressing F5 in the forum...

                                            d.healeyD 1 Reply Last reply Reply Quote 2
                                            • First post
                                              Last post

                                            29

                                            Online

                                            1.8k

                                            Users

                                            12.0k

                                            Topics

                                            104.7k

                                            Posts