Pretty weird problem with the Preset Browser ?

[lalalandsynth]

@ustk You mean 3 columns mode as well ?
I tested 3 columns the other day , no renaming problem there but I will verify .

[ustk]

@lalalandsynth Ok so I fixed the 2 columns renaming issue as well as preset highlighting inconsistency on prev/next (for both 2 & 3 cols)
Although I'm still struggling with preset disappearing on prev/next in 2 columns mode...
But it's late and night is the mother of counsel! I'll have fun with that tomorrow :)

[lalalandsynth]

@ustk excellent !!

[ustk]

Ok so now it's working, so I'm trying to extend this to the 1 column style that is broken too...

[lalalandsynth]

@ustk Are you somehow fixing this within Hise or in c++ ?

[ustk]

@lalalandsynth In the source code so C++

[lalalandsynth]

@ustk yep, thought so , sweet !

[ustk]

Now everything works except I have just noticed another bug. (actually, we can see it in your screen gif)
In 2 columns mode, you can't rename the Bank...
Taking a pause then back on it :)

[ustk]

Ok so after scrutinizing the code for hours, I need help for this one (rename & delete don't appear in 2 columns mode)

I know it is because listbox->getNumSelectedRows() > 0 returns false for some reason... But what reason is beyond my skills

void PresetBrowserColumn::updateButtonVisibility()
{
	editButton->setVisible(false);

	const bool buttonsVisible = showButtonsAtBottom && !isResultBar && currentRoot.isDirectory();
	const bool fileIsSelected = listbox->getNumSelectedRows() > 0;

	addButton->setVisible(buttonsVisible);
	deleteButton->setVisible(buttonsVisible && fileIsSelected);
	renameButton->setVisible(buttonsVisible && fileIsSelected);
}

[lalalandsynth]

@ustk What do you mean by "delete" not appearing in 2 columns ?
Delete works for me...

Although its annoying that if I delete it goes back to category and I have to select that to see the presets again.

EDIT: This going back to category is another sometimes issue..?

[ustk]

@lalalandsynth said in Pretty weird problem with the Preset Browser ?:

@ustk What do you mean by "delete" not appearing in 2 columns ?
Delete works for me...

Bottom of the left column, there are no Rename and Delete only in 2 columns mode:

Although its annoying that if I delete it goes back to category and I have to select that to see the presets again.

EDIT: This going back to category is another sometimes issue..?

Will check that tomorrow, might be a lucky day :)

[lalalandsynth]

@ustk Ah, You mean delete and rename Category ! hehe.
I hadnt even noticed that yet ....indeed

[ustk]

@lalalandsynth Yep, I meant:

In 2 columns mode, you can't rename the Bank....

:)

[ustk]

The preset browser is fixed. Although I'm a C++ noob, so it certainly could have been done in a better way, so feel free to make it better and teach me at the same time :)

Here's my fork so it can be tested before I make a pull request to Dave's fork:
(My fork is up to date with Dave's one, so only the preset browser is different...)
https://github.com/ustk/HISE/tree/develop

Still, the last remaining issue is that Rename and Delete buttons don't appear in the bank column when in 2 columns mode. I still need help with this one...

[d.healey]

@ustk Good work, I'll have a look later today and see if I can track down the rename/delete buttons.

[ustk]

@d-healey Cool! if you haven't seen my post about it, here it is:
https://forum.hise.audio/topic/2766/pretty-weird-problem-with-the-preset-browser/28
When removing the second condition (fileIsSelected), they are showing back...

[ustk]

@ustk I think listboxmight be the issue...

[ustk]

@d-healey That's all fixed, the buttons were not updated when there's no category column...
I'm working to make the column width customizable

[lalalandsynth]

@ustk is there a build for these fixes , my plugin is nearing completion, would love to have a fix for this issue.

Edit: just saw there is a fork but is everything working now ?

[ustk]

@lalalandsynth Everything seems to be working. You can find my fork 6 posts above. You can use it, but if @d-healey is ok to merge, we'll keep only his fork so things are tidy...